From: Haotian Zhang <vulab@iscas.ac.cn>
To: Bin Liu <b-liu@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Haotian Zhang <vulab@iscas.ac.cn>
Subject: [PATCH] usb: musb: ux500: Fix PHY resource leak in error path
Date: Mon, 3 Nov 2025 10:02:04 +0800 [thread overview]
Message-ID: <20251103020204.796-1-vulab@iscas.ac.cn> (raw)
The ux500_musb_init() function calls usb_get_phy() to obtain a PHY
resource, but fails to release it with usb_put_phy() when
usb_register_notifier() fails. This leads to a resource leak as the
PHY reference count is not properly decremented.
Add usb_put_phy() call in the error path before returning to ensure
the PHY resource is properly released when notifier registration fails.
Fixes: 0135522c4898 ("usb: musb: ux500: add otg notifier support")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
drivers/usb/musb/ux500.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
index 8c2a43d992f5..14c5e986937e 100644
--- a/drivers/usb/musb/ux500.c
+++ b/drivers/usb/musb/ux500.c
@@ -155,6 +155,7 @@ static int ux500_musb_init(struct musb *musb)
status = usb_register_notifier(musb->xceiv, &musb->nb);
if (status < 0) {
dev_dbg(musb->controller, "notification register failed\n");
+ usb_put_phy(musb->xceiv);
return status;
}
--
2.50.1.windows.1
next reply other threads:[~2025-11-03 2:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 2:02 Haotian Zhang [this message]
2025-11-03 2:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103020204.796-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®