mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fushuai Wang <fushuai.wang@linux.dev>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org
Cc: hpa@zytor.com, peterz@infradead.org, brgerst@gmail.com,
	kai.huang@intel.com, wangfushuai@baidu.com,
	andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org,
	Fushuai Wang <fushuai.wang@linux.dev>
Subject: [PATCH] x86/process: Use guard() macro in process.c
Date: Mon,  3 Nov 2025 23:12:27 +0800	[thread overview]
Message-ID: <20251103151227.25950-1-fushuai.wang@linux.dev> (raw)

The guard() macro will automatically execute cleanup when
leaving the scope. So this patch use guard() to simplify
to code.

Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
---
 arch/x86/kernel/process.c | 29 +++++++++--------------------
 1 file changed, 9 insertions(+), 20 deletions(-)

diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 4c718f8adc59..481010fb3aee 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -294,26 +294,24 @@ void flush_thread(void)
 
 void disable_TSC(void)
 {
-	preempt_disable();
+	guard(preempt)();
 	if (!test_and_set_thread_flag(TIF_NOTSC))
 		/*
 		 * Must flip the CPU state synchronously with
 		 * TIF_NOTSC in the current running context.
 		 */
 		cr4_set_bits(X86_CR4_TSD);
-	preempt_enable();
 }
 
 static void enable_TSC(void)
 {
-	preempt_disable();
+	guard(preempt)();
 	if (test_and_clear_thread_flag(TIF_NOTSC))
 		/*
 		 * Must flip the CPU state synchronously with
 		 * TIF_NOTSC in the current running context.
 		 */
 		cr4_clear_bits(X86_CR4_TSD);
-	preempt_enable();
 }
 
 int get_tsc_mode(unsigned long adr)
@@ -363,7 +361,7 @@ static void set_cpuid_faulting(bool on)
 
 static void disable_cpuid(void)
 {
-	preempt_disable();
+	guard(preempt)();
 	if (!test_and_set_thread_flag(TIF_NOCPUID)) {
 		/*
 		 * Must flip the CPU state synchronously with
@@ -371,12 +369,11 @@ static void disable_cpuid(void)
 		 */
 		set_cpuid_faulting(true);
 	}
-	preempt_enable();
 }
 
 static void enable_cpuid(void)
 {
-	preempt_disable();
+	guard(preempt)();
 	if (test_and_clear_thread_flag(TIF_NOCPUID)) {
 		/*
 		 * Must flip the CPU state synchronously with
@@ -384,7 +381,6 @@ static void enable_cpuid(void)
 		 */
 		set_cpuid_faulting(false);
 	}
-	preempt_enable();
 }
 
 static int get_cpuid_mode(void)
@@ -594,21 +590,19 @@ static __always_inline void amd_set_core_ssb_state(unsigned long tifn)
 
 		msr |= x86_amd_ls_cfg_ssbd_mask;
 
-		raw_spin_lock(&st->shared_state->lock);
+		guard(raw_spinlock_irq)(&st->shared_state->lock);
 		/* First sibling enables SSBD: */
 		if (!st->shared_state->disable_state)
 			wrmsrq(MSR_AMD64_LS_CFG, msr);
 		st->shared_state->disable_state++;
-		raw_spin_unlock(&st->shared_state->lock);
 	} else {
 		if (!__test_and_clear_bit(LSTATE_SSB, &st->local_state))
 			return;
 
-		raw_spin_lock(&st->shared_state->lock);
+		guard(raw_spinlock_irq)(&st->shared_state->lock);
 		st->shared_state->disable_state--;
 		if (!st->shared_state->disable_state)
 			wrmsrq(MSR_AMD64_LS_CFG, msr);
-		raw_spin_unlock(&st->shared_state->lock);
 	}
 }
 #else
@@ -687,20 +681,16 @@ static unsigned long speculation_ctrl_update_tif(struct task_struct *tsk)
 
 void speculation_ctrl_update(unsigned long tif)
 {
-	unsigned long flags;
-
 	/* Forced update. Make sure all relevant TIF flags are different */
-	local_irq_save(flags);
+	guard(irqsave)();
 	__speculation_ctrl_update(~tif, tif);
-	local_irq_restore(flags);
 }
 
 /* Called from seccomp/prctl update */
 void speculation_ctrl_update_current(void)
 {
-	preempt_disable();
+	guard(preempt)();
 	speculation_ctrl_update(speculation_ctrl_update_tif(current));
-	preempt_enable();
 }
 
 static inline void cr4_toggle_bits_irqsoff(unsigned long mask)
@@ -961,9 +951,8 @@ void amd_e400_c1e_apic_setup(void)
 {
 	if (boot_cpu_has_bug(X86_BUG_AMD_APIC_C1E)) {
 		pr_info("Switch to broadcast mode on CPU%d\n", smp_processor_id());
-		local_irq_disable();
+		guard(irq)();
 		tick_broadcast_force();
-		local_irq_enable();
 	}
 }
 
-- 
2.36.1


                 reply	other threads:[~2025-11-03 15:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251103151227.25950-1-fushuai.wang@linux.dev \
    --to=fushuai.wang@linux.dev \
    --cc=andrew.cooper3@citrix.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kai.huang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=wangfushuai@baidu.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®