mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Michal Pecio <michal.pecio@gmail.com>
Cc: x86@kernel.org, regressions@lists.linux.dev,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Eric DeVolder <eric.devolder@oracle.com>,
	linux-kernel@vger.kernel.org
Subject: Re: AMD topology broken on various 754/AM2+/AM3/AM3+ systems causes NB/EDAC/GART regression since 6.14
Date: Tue, 4 Nov 2025 10:23:51 -0500	[thread overview]
Message-ID: <20251104152351.GB452990@yaz-khff2.amd.com> (raw)
In-Reply-To: <20251103181245.7745621f.michal.pecio@gmail.com>

On Mon, Nov 03, 2025 at 06:12:45PM +0100, Michal Pecio wrote:
> On Mon, 3 Nov 2025 09:38:51 -0500, Yazen Ghannam wrote:
> > > I have this AM4 system with some proprietary HP BIOS:
> > > 
> > > [02Fh 0047 001h]               Local Apic ID : 10
> > > [037h 0055 001h]               Local Apic ID : 11
> > > [03Fh 0063 001h]               Local Apic ID : 12
> > > [047h 0071 001h]               Local Apic ID : 13
> > > 
> > > domain: Thread     shift: 0 dom_size:     1 max_threads:     1
> > > domain: Core       shift: 4 dom_size:    16 max_threads:    16
> > > domain: Module     shift: 4 dom_size:     1 max_threads:    16
> > > domain: Tile       shift: 4 dom_size:     1 max_threads:    16
> > > domain: Die        shift: 4 dom_size:     1 max_threads:    16
> > > domain: DieGrp     shift: 4 dom_size:     1 max_threads:    16
> > > domain: Package    shift: 4 dom_size:     1 max_threads:    16
> > > 
> > > It seems that pkgid is 0x1 here, which is not a problem because
> > > it's single socket, but dunno if HP or somebody else couldn't do
> > > similar things in an 8-socket system and end up with pkgid > 8.
> > >   
> > 
> > So is this another bogus case?
> 
> No, it isn't bogus. It's a quad-core Carrizo APU with its four LAPICs,
> but their numbers start from 0x10 rather than 0x00. And AFAIU, the
> calculated pkgid vaule will be 1.
> 

Oh I see. That's interesting.

Though something still feels off about it, because these systems never
had 16 threads/cores.

> If HP or other vendor would do similar thing on an 8-socket system,
> the assumption that (pkgid < 8) could no longer hold, even if the CPUs
> are completely real.

The proposed check only applies to older systems. Were there any
8-socket AMD systems in production? I'm only aware of systems up to 4
sockets from those days. Hence the arbitrary value check.

Now there are systems with 8 "AMD nodes". However, before Zen these
would be 2 AMD nodes per socket. With 4 sockets you'd get 8 AMD nodes.
Naples had 4 AMD nodes per socket, but the max system had 2 sockets.

But I think I see your point that this check would break if the pkgid
values can start from an arbitrary number. If such a case is reported,
then this could be a new quirk or rework of the existing quirks.

Thanks,
Yazen

      reply	other threads:[~2025-11-04 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251024204658.3da9bf3f.michal.pecio@gmail.com>
2025-10-24 21:32 ` Yazen Ghannam
2025-10-27 16:18   ` Mario Limonciello
2025-10-28 14:36     ` Yazen Ghannam
2025-11-03  7:40   ` Michal Pecio
2025-11-03 14:38     ` Yazen Ghannam
2025-11-03 17:12       ` Michal Pecio
2025-11-04 15:23         ` Yazen Ghannam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251104152351.GB452990@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=bp@alien8.de \
    --cc=eric.devolder@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=michal.pecio@gmail.com \
    --cc=mingo@redhat.com \
    --cc=regressions@lists.linux.dev \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®