mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: viro@zeniv.linux.org.uk, brauner@kernel.org, hansg@kernel.org,
	ilpo.jarvinen@linux.intel.com
Cc: jack@suse.cz, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org
Subject: [PATCH 3/4] platform/x86: wmi: Remove extern keyword from prototypes
Date: Tue,  4 Nov 2025 21:45:39 +0100	[thread overview]
Message-ID: <20251104204540.13931-4-W_Armin@gmx.de> (raw)
In-Reply-To: <20251104204540.13931-1-W_Armin@gmx.de>

The external function definitions do not need the "extern" keyword.
Remove it to silence the associated checkpatch warnings.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
 include/linux/wmi.h | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/include/linux/wmi.h b/include/linux/wmi.h
index 10751c8e5e6a..665ea7dc8a92 100644
--- a/include/linux/wmi.h
+++ b/include/linux/wmi.h
@@ -36,13 +36,10 @@ struct wmi_device {
  */
 #define to_wmi_device(device)	container_of_const(device, struct wmi_device, dev)
 
-extern acpi_status wmidev_evaluate_method(struct wmi_device *wdev,
-					  u8 instance, u32 method_id,
-					  const struct acpi_buffer *in,
-					  struct acpi_buffer *out);
+acpi_status wmidev_evaluate_method(struct wmi_device *wdev, u8 instance, u32 method_id,
+				   const struct acpi_buffer *in, struct acpi_buffer *out);
 
-extern union acpi_object *wmidev_block_query(struct wmi_device *wdev,
-					     u8 instance);
+union acpi_object *wmidev_block_query(struct wmi_device *wdev, u8 instance);
 
 acpi_status wmidev_block_set(struct wmi_device *wdev, u8 instance, const struct acpi_buffer *in);
 
@@ -81,9 +78,9 @@ struct wmi_driver {
  */
 #define to_wmi_driver(drv)	container_of_const(drv, struct wmi_driver, driver)
 
-extern int __must_check __wmi_driver_register(struct wmi_driver *driver,
-					      struct module *owner);
-extern void wmi_driver_unregister(struct wmi_driver *driver);
+int __must_check __wmi_driver_register(struct wmi_driver *driver, struct module *owner);
+
+void wmi_driver_unregister(struct wmi_driver *driver);
 
 /**
  * wmi_driver_register() - Helper macro to register a WMI driver
-- 
2.39.5


  parent reply	other threads:[~2025-11-04 20:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 20:45 [PATCH 0/4] platform/x86: wmi: Prepare for future changes Armin Wolf
2025-11-04 20:45 ` [PATCH 1/4] fs/nls: Fix utf16 to utf8 conversion Armin Wolf
2025-11-04 20:45 ` [PATCH 2/4] platform/x86: wmi: Use correct type when populating ACPI objects Armin Wolf
2025-11-04 20:45 ` Armin Wolf [this message]
2025-11-04 20:45 ` [PATCH 4/4] platform/x86: wmi: Move WMI core code into a separate directory Armin Wolf
2025-11-05  9:41   ` Ilpo Järvinen
2025-11-05 22:10     ` Armin Wolf
2025-11-10 10:54       ` Ilpo Järvinen
2025-11-04 20:52 ` [PATCH 0/4] platform/x86: wmi: Prepare for future changes Mario Limonciello
2025-11-05 22:16   ` Armin Wolf
2025-11-10 11:00     ` Ilpo Järvinen
2025-11-10 11:03       ` Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251104204540.13931-4-W_Armin@gmx.de \
    --to=w_armin@gmx.de \
    --cc=brauner@kernel.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®