From: Christian Brauner <brauner@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Jan Kara <jack@suse.cz>, "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-block@vger.kernel.org,
Joseph Qi <joseph.qi@linux.alibaba.com>,
guanghuifeng@linux.alibaba.com, zongyong.wzy@alibaba-inc.com,
zyfjeff@linux.alibaba.com,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: question about bd_inode hashing against device_add() // Re: [PATCH 03/11] block: call bdev_add later in device_add_disk
Date: Wed, 5 Nov 2025 13:30:24 +0100 [thread overview]
Message-ID: <20251105-elstern-wippen-3af38a8f40f3@brauner> (raw)
In-Reply-To: <83b9dac8-815e-4990-8cc7-5aaf4ba85f42@linux.alibaba.com>
On Fri, Oct 31, 2025 at 10:44:53PM +0800, Gao Xiang wrote:
>
>
> On 2025/10/31 22:34, Greg Kroah-Hartman wrote:
> > On Fri, Oct 31, 2025 at 08:23:32PM +0800, Gao Xiang wrote:
> > >
> > >
> > > On 2025/10/31 18:12, Gao Xiang wrote:
> > > > Hi Greg,
> > > >
> > > > On 2025/10/31 17:58, Greg Kroah-Hartman wrote:
> > > > > On Fri, Oct 31, 2025 at 05:54:10PM +0800, Gao Xiang wrote:
> > > > > >
> > > > > >
> > > > > > On 2025/10/31 17:45, Christoph Hellwig wrote:
> > >
> > > ...
> > >
> > > > > > > But why does the device node
> > > > > > > get created earlier? My assumption was that it would only be
> > > > > > > created by the KOBJ_ADD uevent. Adding the device model maintainers
> > > > > > > as my little dig through the core drivers/base/ code doesn't find
> > > > > > > anything to the contrary, but maybe I don't fully understand it.
> > > > > >
> > > > > > AFAIK, device_add() is used to trigger devtmpfs file
> > > > > > creation, and it can be observed if frequently
> > > > > > hotpluging device in the VM and mount. Currently
> > > > > > I don't have time slot to build an easy reproducer,
> > > > > > but I think it's a real issue anyway.
> > > > >
> > > > > As I say above, that's not normal, and you have to be root to do this,
> > > I just spent time to reproduce with dynamic loop devices and
> > > actually it's easy if msleep() is located artificiallly,
> > > the diff as below:
> > >
> > > diff --git a/block/bdev.c b/block/bdev.c
> > > index 810707cca970..a4273b5ad456 100644
> > > --- a/block/bdev.c
> > > +++ b/block/bdev.c
> > > @@ -821,7 +821,7 @@ struct block_device *blkdev_get_no_open(dev_t dev, bool autoload)
> > > struct inode *inode;
> > >
> > > inode = ilookup(blockdev_superblock, dev);
> > > - if (!inode && autoload && IS_ENABLED(CONFIG_BLOCK_LEGACY_AUTOLOAD)) {
> > > + if (0) {
> > > blk_request_module(dev);
> > > inode = ilookup(blockdev_superblock, dev);
> > > if (inode)
> > > diff --git a/block/genhd.c b/block/genhd.c
> > > index 9bbc38d12792..3c9116fdc1ce 100644
> > > --- a/block/genhd.c
> > > +++ b/block/genhd.c
> > > @@ -428,6 +428,8 @@ static void add_disk_final(struct gendisk *disk)
> > > set_bit(GD_ADDED, &disk->state);
> > > }
> > >
> > > +#include <linux/delay.h>
> > > +
> > > static int __add_disk(struct device *parent, struct gendisk *disk,
> > > const struct attribute_group **groups,
> > > struct fwnode_handle *fwnode)
> > > @@ -497,6 +499,9 @@ static int __add_disk(struct device *parent, struct gendisk *disk,
> > > if (ret)
> > > goto out_free_ext_minor;
> > >
> > > + if (disk->major == LOOP_MAJOR)
> > > + msleep(2500); // delay 2.5s for all loops
> > > +
> >
> > Yes, so you need to watch for the uevent to happen, THEN it is safe to
> > access the block device. Doing it before then isn't a good idea :)
> >
> > But, if you think this is an issue, do you have a patch that passes your
> > testing to fix it?
>
> I just raise it up for some ideas, and this change is
> buried into the code refactor and honestly I need to
> look into the codebase and related patchsets first.
>
> Currently I have dozens of other development stuffs
> on hand, if it's really a regression, I do hope
> Christoph or other folks who are familiar with the code
> could try to address this.
If it's easy to do without much of a regression or performance risk then
the device node should only show up once the device is actually ready.
It's certainly best-practive to wait for the uevent though.
next prev parent reply other threads:[~2025-11-05 12:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210818144542.19305-1-hch@lst.de>
[not found] ` <20210818144542.19305-4-hch@lst.de>
[not found] ` <43375218-2a80-4a7a-b8bb-465f6419b595@linux.alibaba.com>
[not found] ` <20251031090925.GA9379@lst.de>
[not found] ` <ae38c5dc-da90-4fb3-bb72-61b66ab5a0d2@linux.alibaba.com>
2025-10-31 9:45 ` Christoph Hellwig
2025-10-31 9:54 ` Gao Xiang
2025-10-31 9:58 ` Greg Kroah-Hartman
2025-10-31 10:12 ` Gao Xiang
2025-10-31 12:23 ` Gao Xiang
2025-10-31 12:25 ` Gao Xiang
2025-10-31 14:34 ` Greg Kroah-Hartman
2025-10-31 14:44 ` Gao Xiang
2025-11-05 3:04 ` Gao Xiang
2025-11-05 12:30 ` Christian Brauner [this message]
2025-11-05 14:13 ` Gao Xiang
2025-10-31 14:31 ` Greg Kroah-Hartman
2025-10-31 14:40 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105-elstern-wippen-3af38a8f40f3@brauner \
--to=brauner@kernel.org \
--cc=axboe@kernel.dk \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=guanghuifeng@linux.alibaba.com \
--cc=hch@lst.de \
--cc=hsiangkao@linux.alibaba.com \
--cc=jack@suse.cz \
--cc=jasowang@redhat.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=mst@redhat.com \
--cc=rafael@kernel.org \
--cc=zongyong.wzy@alibaba-inc.com \
--cc=zyfjeff@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®