From: Encrow Thorne <jyc0019@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Troy Mitchell <troy.mitchell@linux.dev>
Cc: linux-kernel@vger.kernel.org, Encrow Thorne <jyc0019@gmail.com>
Subject: [PATCH RFC] reset: fix BIT macro reference
Date: Wed, 05 Nov 2025 21:35:02 +0800 [thread overview]
Message-ID: <20251105-rfc-reset-include-bits-v1-1-d7e1bbc7e1ab@gmail.com> (raw)
RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
include bits.h or bitops.h. This causes compilation errors when
including reset.h standalone.
Include bits.h to make reset.h self-contained.
This patch is sent as RFC to discuss whether including bits.h in
reset.h is appropriate.
Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
---
include/linux/reset.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 840d75d172f6..d3102eef085e 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -5,6 +5,7 @@
#include <linux/err.h>
#include <linux/errno.h>
#include <linux/types.h>
+#include <linux/bits.h>
struct device;
struct device_node;
---
base-commit: 8fec172c82c2b5f6f8e47ab837c1dc91ee3d1b87
change-id: 20251105-rfc-reset-include-bits-4ec72344d1a3
Best regards,
--
Encrow Thorne <jyc0019@gmail.com>
next reply other threads:[~2025-11-05 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 13:35 Encrow Thorne [this message]
2025-11-05 14:14 ` Philipp Zabel
2025-11-05 14:28 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105-rfc-reset-include-bits-v1-1-d7e1bbc7e1ab@gmail.com \
--to=jyc0019@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=troy.mitchell@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®