From: Anurag Dutta <a-dutta@ti.com>
To: <broonie@kernel.org>, <khairul.anuar.romli@altera.com>,
<vigneshr@ti.com>
Cc: <u-kumar1@ti.com>, <s-k6@ti.com>, <linux-spi@vger.kernel.org>,
<gehariprasath@ti.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] spi: spi-cadence-quadspi: Remove duplicate pm_runtime_put_autosuspend() call
Date: Wed, 5 Nov 2025 21:41:46 +0530 [thread overview]
Message-ID: <20251105161146.2019090-3-a-dutta@ti.com> (raw)
In-Reply-To: <20251105161146.2019090-1-a-dutta@ti.com>
Fix runtime PM usage count underflow caused by calling
pm_runtime_put_autosuspend() twice with only one corresponding
pm_runtime_get_noresume() call. This triggers the warning:
"Runtime PM usage count underflow!"
Remove the duplicate put call to balance the runtime PM reference
counting.
Fixes: 30dbc1c8d50f ("spi: cadence-qspi: defer runtime support on socfpga if reset bit is enabled")
Signed-off-by: Anurag Dutta <a-dutta@ti.com>
---
drivers/spi/spi-cadence-quadspi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index 56906dc76b34..8e0df08609c0 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -2012,7 +2012,6 @@ static int cqspi_probe(struct platform_device *pdev)
}
if (!(ddata && (ddata->quirks & CQSPI_DISABLE_RUNTIME_PM))) {
- pm_runtime_put_autosuspend(dev);
pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev);
}
--
2.34.1
next prev parent reply other threads:[~2025-11-05 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 16:11 [PATCH 0/2] OSPI pm_runtime fixes Anurag Dutta
2025-11-05 16:11 ` [PATCH 1/2] spi: spi-cadence-quadspi: Enable pm runtime earlier to avoid imbalance Anurag Dutta
2025-11-05 16:11 ` Anurag Dutta [this message]
2025-11-14 17:07 ` [PATCH 0/2] OSPI pm_runtime fixes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105161146.2019090-3-a-dutta@ti.com \
--to=a-dutta@ti.com \
--cc=broonie@kernel.org \
--cc=gehariprasath@ti.com \
--cc=khairul.anuar.romli@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s-k6@ti.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®