From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D361432D0C6 for ; Wed, 5 Nov 2025 17:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762363279; cv=none; b=Fgs9IZgNtjC9SD9vWWKT6q1WHzy9uwTyf8EHR6fc2zCsnVqY5W6vfT/toylstyUQK1BzLORKdmlRc5LQEB9ZQ9/huatTkwRp00H7hMYRREZJdordfrssdKKbC7a6bxhr6eXBSMElL54kaRn6vKj6KmjEy2KDLDVARVt3w5qEt+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762363279; c=relaxed/simple; bh=R+scxNFIJ7A2QKHZGih1Ehc3wdUpOLgJ/krGtFdCacU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dn0nKN0yTvwbVZqco0P35lnzOigeaA1tZpcq8sGD5cP1QJNJW3m889pBNgn394rbuUCpEXY3DcGwig5SU0OPpNMLdtNoK+k32SjJtkpF3zFqiuwg4HY8nHMGEQHI0/7bOI+U2jkZ/Cm2D+BAnmk8PAuemOVgbfA+0FTdrrXqWLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=SH8jp2DI; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="SH8jp2DI" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-87bb66dd224so1173426d6.3 for ; Wed, 05 Nov 2025 09:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1762363277; x=1762968077; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2cq2mS+yWhZev0zm4YEm/j+lSP0FbcQSTW4gUm6tSNU=; b=SH8jp2DIufEX3vRN+bltek/lJi75b+p+z6AIN9nyUDWTVYCvATPDIaqoM3LESvI4FD 8nquf5IVH6r6cI33uAXnizUpTqbHvleYQT9kAAY4b0ZbCwQlwYzE3GQuW2Y6sut/vNOW o3iLPOiHZJM+c3dlQjap/e5ySWpcEqF+1Rfwrb/26DtOzWcSjuSoveArv3xqAA9c56eX Wf8nxoHDCzeCmeLzkzXWAQ7WhGjvqn8Wk7ZgL3TfZvDJRS8xIeJ2VQMyPMS2Q/xKQqPz hHDtgt+7wOO5Flg+YPcQTR+oqDeKyusFE0U4bnVdqJ4pi9l3rGcyGzEmTGvr1ZnLdMkg U/QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762363277; x=1762968077; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2cq2mS+yWhZev0zm4YEm/j+lSP0FbcQSTW4gUm6tSNU=; b=NCL5I/8Gd0sHKUIDuU/s0ieO/Tv9mus1/pyuOP9LoaEzwE2jguJQk3GR5NVN/kvtS2 Jgpj0CBsHC6jbiztFdQvWMSYr7QIsW6DnywLiVUjHPuZ7wLgiC8tEC1YTmmwnNFvwj3c 0PjPw2uA/DKkC7f0xUe7H1I8ZTg3Ud9QBbvnehkOtS0FenKDW5+XEJ29CJdM22Nk+Nlw pM8nxhPCbSrivpx+gPErLQdhLC5qM7eoelRhHHr7uZrkctU0gRg+0LKde1gj/N+E3hwW hQo+sByn0TOfs7YtPpjHCseZoqro73sbZF3yshvDUdA1Pai27cx3wOrjboWSyw/rTcmr 4OKA== X-Forwarded-Encrypted: i=1; AJvYcCUT31Cy0T4JVhhcRUdV4Nr9zuxBtDL/hzOgiIkrtnfa2BnpA2k5yntLBWlkzMCPM1JSCloOlh5yG65i2Fw=@vger.kernel.org X-Gm-Message-State: AOJu0YxnlXV/L0sqCG9sf53MjXCgW/mKqksYGWsBya90ShEOraHtjSv3 tlgjQeHgj2KB0dV1VdPwTGub+LLDu/dzVSgZ6Tj8QSPTz519tD79zPL1j4m/RViqf3A= X-Gm-Gg: ASbGncuGeS/3p3rkvzrw9wpj2e3X2HC2/u4GtKY4xqlT9S42Oe5us5ijk432/3XL+SV 9Z6adyC9b/sQMDYrMRfQfRTiyaALkNx2QBwZ9DcssAyPmnTqA5UAxTbYhgi/mJPwa1ixRM1ADgX Ar6a8tPO57QfRcAq/Pw8Sx1O5Sdh6C80faBUsBewXb+PBNmHuqfCqLKuTG0s8FV67k7X2kx3hAS UnJNXcCTh0TW/Qd9R+WBeGRHiyzxfNlCosTypmaAeJVfID8RZzL4MfdCT9wOSRtQ7P+OdvRRRr4 cFyeA/1QErIXq6shEGMmf0oQ2jhhUWtwAFbRP9UV9FV6Bwpg5+2+yXdlsUxHctr0tntwbD9WVbZ +TX7uwezb+I12bW8cyZEe/11E3eDIGMbN5qsOuZhKbmv+rZHZcVGZRR6X6ei6rBwNAu1NtoVMbR xMBFnP+DgNMPxL87loS/t7AAjcwJa+iIJTOTkEiT/VjgrZQA== X-Google-Smtp-Source: AGHT+IGCK5Ht7P6eoqM7YgVZ6ef4jlofMTj5LlbxF9x0JfdkYp0y/H774e8UOGf7CmqXFow5BgQdlA== X-Received: by 2002:ad4:576e:0:b0:880:5779:d489 with SMTP id 6a1803df08f44-88071095623mr52524556d6.3.1762363276490; Wed, 05 Nov 2025 09:21:16 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-880828c457bsm996916d6.5.2025.11.05.09.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 09:21:15 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vGhC7-00000007Bv7-1e20; Wed, 05 Nov 2025 13:21:15 -0400 Date: Wed, 5 Nov 2025 13:21:15 -0400 From: Jason Gunthorpe To: Gregory Price Cc: Lorenzo Stoakes , Andrew Morton , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Sven Schnelle , Peter Xu , Alexander Viro , Christian Brauner , Jan Kara , Arnd Bergmann , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Muchun Song , Oscar Salvador , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Axel Rasmussen , Yuanchu Xie , Wei Xu , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , SeongJae Park , Matthew Wilcox , Leon Romanovsky , Xu Xin , Chengming Zhou , Jann Horn , Miaohe Lin , Naoya Horiguchi , Pedro Falcato , Pasha Tatashin , Rik van Riel , Harry Yoo , Hugh Dickins , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH 02/16] mm: introduce leaf entry type and use to simplify leaf entry logic Message-ID: <20251105172115.GQ1204670@ziepe.ca> References: <2c75a316f1b91a502fad718de9b1bb151aafe717.1762171281.git.lorenzo.stoakes@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Nov 05, 2025 at 09:42:24AM -0500, Gregory Price wrote: > On Mon, Nov 03, 2025 at 12:31:43PM +0000, Lorenzo Stoakes wrote: > > +typedef swp_entry_t leaf_entry_t; > > + > > +#ifdef CONFIG_MMU > > + > > +/* Temporary until swp_entry_t eliminated. */ > > +#define LEAF_TYPE_SHIFT SWP_TYPE_SHIFT > > + > > +enum leaf_entry_type { > > + /* Fundamental types. */ > > + LEAFENT_NONE, > > + LEAFENT_SWAP, > > + /* Migration types. */ > > + LEAFENT_MIGRATION_READ, > > + LEAFENT_MIGRATION_READ_EXCLUSIVE, > > + LEAFENT_MIGRATION_WRITE, > > + /* Device types. */ > > + LEAFENT_DEVICE_PRIVATE_READ, > > + LEAFENT_DEVICE_PRIVATE_WRITE, > > + LEAFENT_DEVICE_EXCLUSIVE, > > + /* H/W posion types. */ > > + LEAFENT_HWPOISON, > > + /* Marker types. */ > > + LEAFENT_MARKER, > > +}; > > + > > Have been browsing the patch set again, will get around a deeper review, > but just wanted to say this is a thing of beauty :] +1 I thought the same thing. So much clearer what is going on here, and I didn't realize we had so many types already.. Jason