mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhi Wang <zhiw@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: <aliceryhl@google.com>, <daniel.almeida@collabora.com>,
	<ojeda@kernel.org>, <alex.gaynor@gmail.com>,
	<boqun.feng@gmail.com>, <gary@garyguo.net>,
	<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
	<a.hindborg@kernel.org>, <tmgross@umich.edu>,
	<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rust: io: cleanup imports and use "kernel vertical" style
Date: Thu, 6 Nov 2025 11:46:22 +0200	[thread overview]
Message-ID: <20251106114622.18ed7628.zhiw@nvidia.com> (raw)
In-Reply-To: <39df4761-d843-4942-9f00-a44fc8436e80@kernel.org>

On Tue, 4 Nov 2025 17:25:11 +0100
Danilo Krummrich <dakr@kernel.org> wrote:

> On 11/4/25 2:32 PM, Danilo Krummrich wrote:
> > diff --git a/rust/kernel/io/poll.rs b/rust/kernel/io/poll.rs
> > index ebc29023d59d..e21ccf98b81a 100644
> > --- a/rust/kernel/io/poll.rs
> > +++ b/rust/kernel/io/poll.rs
> > @@ -5,7 +5,10 @@
> >  //! C header:
> > [`include/linux/iopoll.h`](srctree/include/linux/iopoll.h). 
> >  use crate::{
> > -    error::{code::*, Result},
> > +    error::{
> > +        code::*,
> > +        Result, //
> > +    },
> >      processor::cpu_relax,
> >      task::might_sleep,
> >      time::{
> 
> Should instead be:
> 

LGTM. Tested on the driver-core-testing branch with this extra change.

Reviewed-by: Zhi Wang <zhiw@nvidia.com>

> diff --git a/rust/kernel/io/poll.rs b/rust/kernel/io/poll.rs
> index ebc29023d59d..b1a2570364f4 100644
> --- a/rust/kernel/io/poll.rs
> +++ b/rust/kernel/io/poll.rs
> @@ -5,7 +5,7 @@
>  //! C header:
> [`include/linux/iopoll.h`](srctree/include/linux/iopoll.h).
> 
>  use crate::{
> -    error::{code::*, Result},
> +    prelude::*,
>      processor::cpu_relax,
>      task::might_sleep,
>      time::{
> 


  reply	other threads:[~2025-11-06  9:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 13:32 Danilo Krummrich
2025-11-04 16:25 ` Danilo Krummrich
2025-11-06  9:46   ` Zhi Wang [this message]
2025-11-11  8:53 ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251106114622.18ed7628.zhiw@nvidia.com \
    --to=zhiw@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®