From: Shouping Wang <allen.wang@hj-micro.com>
To: will@kernel.org, robin.murphy@arm.com
Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, allen.wang@hj-micro.com,
andy.xu@hj-micro.com, peter.du@hj-micro.com
Subject: [PATCH 1/2] perf/arm-ni: rename PMU device name
Date: Fri, 7 Nov 2025 16:43:18 +0800 [thread overview]
Message-ID: <20251107084320.555979-2-allen.wang@hj-micro.com> (raw)
In-Reply-To: <20251107084320.555979-1-allen.wang@hj-micro.com>
The PMU device names are arm_ni_1_*,arm_ni_2_*, etc.
The device names change based on the order of registration
for multiple NI instances. By naming the PMU device using
its address, the device name can be made independent of
the registration order.
Signed-off-by: Shouping Wang <allen.wang@hj-micro.com>
---
drivers/perf/arm-ni.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/perf/arm-ni.c b/drivers/perf/arm-ni.c
index 1615a0564031..32eabdbe877a 100644
--- a/drivers/perf/arm-ni.c
+++ b/drivers/perf/arm-ni.c
@@ -53,6 +53,7 @@
#define NI_NUM_COUNTERS 8
#define NI_CCNT_IDX 31
+#define NI_PMU_PA_SHIFT 12
/* Event attributes */
#define NI_CONFIG_TYPE GENMASK_ULL(15, 0)
@@ -115,7 +116,6 @@ struct arm_ni {
struct device *dev;
void __iomem *base;
enum ni_part part;
- int id;
int cpu;
int num_cds;
struct hlist_node cpuhp_node;
@@ -560,7 +560,7 @@ static int arm_ni_init_cd(struct arm_ni *ni, struct arm_ni_node *node, u64 res_s
.read = arm_ni_event_read,
};
- name = devm_kasprintf(ni->dev, GFP_KERNEL, "arm_ni_%d_cd_%d", ni->id, cd->id);
+ name = devm_kasprintf(ni->dev, GFP_KERNEL, "arm_ni_%llx", res_start >> NI_PMU_PA_SHIFT);
if (!name)
return -ENOMEM;
@@ -623,7 +623,6 @@ static int arm_ni_probe(struct platform_device *pdev)
struct arm_ni *ni;
struct resource *res;
void __iomem *base;
- static atomic_t id;
int ret, num_cds;
u32 reg, part;
@@ -674,7 +673,6 @@ static int arm_ni_probe(struct platform_device *pdev)
ni->base = base;
ni->num_cds = num_cds;
ni->part = part;
- ni->id = atomic_fetch_inc(&id);
ni->cpu = cpumask_local_spread(0, dev_to_node(ni->dev));
platform_set_drvdata(pdev, ni);
--
2.43.0
next prev parent reply other threads:[~2025-11-07 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 8:43 [PATCH 0/2] perf/arm-ni: Optimize codes Shouping Wang
2025-11-07 8:43 ` Shouping Wang [this message]
2025-11-24 15:47 ` [PATCH 1/2] perf/arm-ni: rename PMU device name Will Deacon
2025-11-24 18:01 ` Robin Murphy
2025-11-07 8:43 ` [PATCH 2/2] perf: arm-ni: add topology debug info for the clock domain Shouping Wang
2025-11-24 18:28 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107084320.555979-2-allen.wang@hj-micro.com \
--to=allen.wang@hj-micro.com \
--cc=andy.xu@hj-micro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peter.du@hj-micro.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®