From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AB6B25B69F for ; Sat, 8 Nov 2025 19:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762630938; cv=none; b=KlfXi74hPxO1vvpJNE8G14BxfjLO02PARqG08gvEh7fFCpAuH9JHkF0yv6n3bFZBBAqS1cwXCLMgcmXAVRjXUJy8qnApTIFfaVPYtxIreZjKbJ7SDw2B0Cmfj3uUyczkIOOzJEYd8j8g3OGtrry95G/GeEpDA3uAun9RfAsK2pI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762630938; c=relaxed/simple; bh=X8ZNMlar1Ow1eWShjc511gIpn78CLUhuBDckR+OLvWw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fa9b5nL6i1h1ZQpdnjuVvP+Y4GAH9yPgGf9FDMU7Bk/zV6lxfCkXbvTChhiKWMMmXkc6BXBb8Xwnb+dVR8Bg0Bc7WHmm6sNr1mJ3V/GJLRXX5koWl6v/Y5QY1LcfH2iZmH5C4b8FalnJXnnX6rAvV28pfm+RFWLrozaCf+TGpQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m78ub/XP; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m78ub/XP" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-376466f1280so23605261fa.0 for ; Sat, 08 Nov 2025 11:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762630935; x=1763235735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=13aFuuc1GQr46fPnxHYB7JQQ32jMQnvYNiL//B4303c=; b=m78ub/XPYARFiCn1X41kMWCyirwXam48zSHEEhpkCYS2pEjXzk1KGrPIQfIZ6+Sy6+ OwUgLhw8b0puzPaZk1AOZJKMEmZ6hWDof9yREOiaqiQ/jAprOvBEDYtaIUIpPAQ2REgR Bm2kZ55dyrg/w66BUvIrbqwyB/8L54nOzdW5yvYKFITgielw0JftKukmd7gY5CPhuhc4 HjWvIfjTtZUFInIJ1cxBzAJNqJT5n4Evl9oYAodOBRS8pBNaUBWVtFA0DXf1yIsHVB3r DmCsR5QrsMLu4YOIzXT6Hof4biz25iWoPaNO0340paVEXG1kSu/CaPbFwsw/xwpKSUW6 TIeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762630935; x=1763235735; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=13aFuuc1GQr46fPnxHYB7JQQ32jMQnvYNiL//B4303c=; b=U3fFI69wdlDlF1AyO5qdRw1m72hgsm+FmiBRFcd95+dbsLGzB4fId5ELnY/0yABfEP 9w1WqtOXxE12u+XkA3StvCQQ9spxKIrs2zBNO/tvRnjtAYqBlKrNt7E/mfC3rE8rURFM Uy8dfq1c9hZKIqiYg2Yx59QM3mXI+9Msb4cYBoIJbQjnCg3oIboXJYQ68l3Z9HczD4Jh 8+apSIgK910TOgQb/YfptgM0VMLq6pHekzS7SHaBesjH+mZtsl9ucHMJbQjdZsIhXlfT T0Te7l727YO5RhldXCsfLWoJoDNNv3L0SHJcr6e3Sl95/ympDF93FZ2W9YpjM5yK5stc 9IMA== X-Forwarded-Encrypted: i=1; AJvYcCULx5oAdP+Fo7pgHn0Hrb9bDYw/dblxXaCyaPmmrvtoqhcIlLQ5crzw16khKjJCwMUAcFsKYoFwfUvwIKE=@vger.kernel.org X-Gm-Message-State: AOJu0YxgmztPgNqugPDLkNnab3JePIlQ06Hfli4TFqnu7quZHI2/4ayZ nBFSFhnAc5UhGSd8g/F7ruu5p4LrZXw/qDred2eVU7DYj268qs2F4tKO X-Gm-Gg: ASbGncv37vHjfeIG5m8fLqkDT/Rx2AePAtXJ0lIqn1zin+lJls7FbEdjrx6dFPlhlAe eBiomgBkOgIrF7GPOCCD9mb1O/ChOlY0LFO0exT9k3nZIw3IjIAS4abOpuODMshZeStceGpwq// hKml+U/xdDSl2qE0LqDqfpk55knMdjFps+Ul19fXIes9fAKxV5C9uN/K0mCDff658oLH1yQ1HYT IYKKdEVEcWJ25dOVWFiWD1Fnn9q1WgTo6VwsOZL6xEm70cqWV2z6iZVIXIrEqyhugCOVYxnvl2s eMSK24czNTxi7QsVogAbqbf7iIRK4HqjZRlkdMTy7Y5tWJPFsbBUTBNBldF/Tqh7WvGwVh1jE0E n40do+4SDbIHgLKAkMFX1bgE5TRddifdgRY4fyYZVolI2OfFo+1Jc9UHLgf777LvkAFWe2MF4GF epPg== X-Google-Smtp-Source: AGHT+IFnDCuSBk7jK+h8KqudoG4bWkSSmVwNgOJURKDwKCfuB23jHIyPUYE9uyHMOVa5uRsybmgG3Q== X-Received: by 2002:a2e:b535:0:b0:37a:2f61:5f30 with SMTP id 38308e7fff4ca-37a7b30bad5mr6315371fa.35.1762630934396; Sat, 08 Nov 2025 11:42:14 -0800 (PST) Received: from curiosity ([5.188.167.4]) by smtp.googlemail.com with ESMTPSA id 38308e7fff4ca-37a5f0edac3sm22115421fa.38.2025.11.08.11.42.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Nov 2025 11:42:12 -0800 (PST) From: Sergey Matyukevich To: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Oleg Nesterov , Shuah Khan , Thomas Huth , Charlie Jenkins , Andy Chiu , Samuel Holland , Joel Granados , Conor Dooley , Yong-Xuan Wang , Heiko Stuebner , Sergey Matyukevich Subject: [PATCH v4 0/9] riscv: vector: misc ptrace fixes for debug use-cases Date: Sat, 8 Nov 2025 22:41:39 +0300 Message-ID: <20251108194207.1257866-1-geomatsi@gmail.com> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series suggests fixes for several corner cases in the RISC-V vector ptrace implementation: - init vector context with proper vlenb, to avoid reading zero vlenb by an early attached debugger - follow gdbserver expectations and return ENODATA instead of EINVAL if vector extension is supported but not yet activated for the traced process - validate input vector csr registers in ptrace, to maintain an accurate view of the tracee's vector context across multiple halt/resume debug cycles For detailed description see the appropriate commit messages. A new test suite v_ptrace is added into the tools/testing/selftests/riscv/vector to verify some of the vector ptrace functionality and corner cases. Previous versions: - v3: https://lore.kernel.org/linux-riscv/20251025210655.43099-1-geomatsi@gmail.com/T/#u - v2: https://lore.kernel.org/linux-riscv/20250821173957.563472-1-geomatsi@gmail.com/T/#u - v1: https://lore.kernel.org/linux-riscv/20251007115840.2320557-1-geomatsi@gmail.com/T/#u Changes in v4: The form 'vsetvli x0, x0, ...' can only be used if VLMAX remains unchanged, see spec 6.2. This condition was not met by the initial values in the selftests w.r.t. the initial zeroed context. QEMU accepted such values, but actual hardware (c908, BananaPi CanMV Zero board) did not, setting vill. So fix the selftests after testing on hardware: - replace 'vsetvli x0, x0, ...' by 'vsetvli rd, x0, ...' - fixed instruction returns VLMAX, so use it in checks as well - replace fixed vlenb == 16 in the syscall test Changes in v3: Address the review comments by Andy Chiu and rework the approach: - drop forced vector context save entirely - perform strict validation of vector csr regs in ptrace Changes in v2: - add thread_info flag to allow to force vector context save - force vector context save after vector ptrace to ensure valid vector context in the next ptrace operations - force vector context save on the first context switch after vector context init to get proper vlenb --- Ilya Mamay (1): riscv: ptrace: return ENODATA for inactive vector extension Sergey Matyukevich (8): selftests: riscv: test ptrace vector interface selftests: riscv: verify initial vector state with ptrace riscv: vector: init vector context with proper vlenb riscv: csr: define vtype registers elements riscv: ptrace: validate input vector csr registers selftests: riscv: verify ptrace rejects invalid vector csr inputs selftests: riscv: verify ptrace accepts valid vector csr values selftests: riscv: verify syscalls discard vector context arch/riscv/include/asm/csr.h | 11 + arch/riscv/kernel/ptrace.c | 72 +- arch/riscv/kernel/vector.c | 12 +- .../testing/selftests/riscv/vector/.gitignore | 1 + tools/testing/selftests/riscv/vector/Makefile | 5 +- .../testing/selftests/riscv/vector/v_ptrace.c | 754 ++++++++++++++++++ 6 files changed, 847 insertions(+), 8 deletions(-) create mode 100644 tools/testing/selftests/riscv/vector/v_ptrace.c base-commit: e811c33b1f137be26a20444b79db8cbc1fca1c89 -- 2.51.0