From: Yixun Lan <dlan@gentoo.org>
To: Encrow Thorne <jyc0019@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: spacemit: fix comment typo
Date: Mon, 10 Nov 2025 22:12:51 +0800 [thread overview]
Message-ID: <20251110141251-GYD1651402@gentoo.org> (raw)
In-Reply-To: <20251029223337-GYA1549833@gentoo.org>
Hi Encrow,
On 06:33 Thu 30 Oct , Yixun Lan wrote:
> Hi Encrow,
>
> On 00:05 Wed 29 Oct , Encrow Thorne wrote:
> > ccumix.h was copied from ccudiv.h and the comment after #endif was not
> > updated.
> >
> > This patch fixes the incorrect comment to match the filename.
>
> Just describe in imperative mode, see
> (since this is trivial, I could amend it before apply the patch,
> so no need to resend)
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
>
I have no other clock patch queued this cycle, so how about you respin a v2
then let's ping Stephen directly for inclusion?
for commit message, I'd suggest simply as below (short/clean, also enough):
Fix incorrect comment to match the filename.
> >
> > Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> > ---
> > drivers/clk/spacemit/ccu_mix.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/spacemit/ccu_mix.h b/drivers/clk/spacemit/ccu_mix.h
> > index 54d40cd39b27..c406508e3504 100644
> > --- a/drivers/clk/spacemit/ccu_mix.h
> > +++ b/drivers/clk/spacemit/ccu_mix.h
> > @@ -220,4 +220,4 @@ extern const struct clk_ops spacemit_ccu_div_gate_ops;
> > extern const struct clk_ops spacemit_ccu_mux_gate_ops;
> > extern const struct clk_ops spacemit_ccu_mux_div_ops;
> > extern const struct clk_ops spacemit_ccu_mux_div_gate_ops;
> > -#endif /* _CCU_DIV_H_ */
> > +#endif /* _CCU_MIX_H_ */
> >
> > ---
> > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> > change-id: 20251028-b4-fix-ccu-mix-typo-038c19fe30c4
> >
> > Best regards,
> > --
> > Encrow Thorne <jyc0019@gmail.com>
> >
>
> --
> Yixun Lan (dlan)
>
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2025-11-10 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 16:05 Encrow Thorne
2025-10-29 1:03 ` Troy Mitchell
2025-10-29 22:33 ` Yixun Lan
2025-11-10 14:12 ` Yixun Lan [this message]
2025-11-10 16:05 ` Encrow Thorne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110141251-GYD1651402@gentoo.org \
--to=dlan@gentoo.org \
--cc=jyc0019@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®