mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Linu Cherian <lcherian@marvell.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Anil Kumar Reddy <areddy3@marvell.com>,
	Tanmay Jagdale <tanmay@marvell.com>
Subject: drivers/hwtracing/coresight/coresight-tmc-core.c:403:5-8: Unneeded variable: "ret". Return "0" on line 416
Date: Tue, 11 Nov 2025 05:46:44 +0800	[thread overview]
Message-ID: <202511110556.RDLHL0DU-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   4ea7c1717f3f2344f7a1cdab4f5875cfa89c87a9
commit: d58a70bdab575264fe75e4826464aaef0dd096b4 coresight: tmc: Add support for reading crash data
date:   9 months ago
config: arm64-randconfig-r052-20251110 (https://download.01.org/0day-ci/archive/20251111/202511110556.RDLHL0DU-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 0d786b9a207aa0e6d88dde7fd9ffe0b364db69a4)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511110556.RDLHL0DU-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/hwtracing/coresight/coresight-tmc-core.c:403:5-8: Unneeded variable: "ret". Return "0" on line 416

vim +403 drivers/hwtracing/coresight/coresight-tmc-core.c

   400	
   401	static int tmc_crashdata_release(struct inode *inode, struct file *file)
   402	{
 > 403		int ret = 0;
   404		unsigned long flags;
   405		struct tmc_resrv_buf *rbuf;
   406		struct tmc_drvdata *drvdata = container_of(file->private_data,
   407							   struct tmc_drvdata,
   408							   crashdev);
   409	
   410		rbuf = &drvdata->resrv_buf;
   411		spin_lock_irqsave(&drvdata->spinlock, flags);
   412		rbuf->reading = false;
   413		spin_unlock_irqrestore(&drvdata->spinlock, flags);
   414	
   415		dev_dbg(&drvdata->csdev->dev, "%s: released\n", __func__);
 > 416		return ret;
   417	}
   418	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-11-10 21:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202511110556.RDLHL0DU-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=areddy3@marvell.com \
    --cc=lcherian@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=suzuki.poulose@arm.com \
    --cc=tanmay@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®