From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 426CE357A20; Tue, 11 Nov 2025 10:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762858555; cv=none; b=bCLHW2n24dGUtRs8EGpSH626M2IfVx1Iaol8Rjt2A0Mq+iGJEIiAe6d5NI/NwcwXXWCgw7bWLAJDlkR/9ryLUAEpDgn7Tps2OvYD/6kNoaARXLxMSK0VcK9Ie4knwv0qzemXHFg9HEuyNJxQqCezfz8fK1X7qNMCE5oS/tV/3WA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762858555; c=relaxed/simple; bh=SQNuPyry54rGiwTAF83uw3tVzcTs/6Rhfs7Wtk9sekY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VFfwnUW8eLHZBjXlau0uyc54Q3LyFQkuc1BipQJ/Z+3hKmDJ765vMCpk4bT4/AleD+nx4BVg+RRAxht3u3+KKO3fsWVIA0G5cU41ffbEUPHPpdKsO1b+CgVZ4Jm+QKtpcGFiToQvUFkM+KIPu1PQfhEJyGMm9MQQVQcN5/1ET0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=haezqG7D; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="haezqG7D" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6e7yn7s1XQtiRBa03S5N6GS6xIer9ZSlKTyvpE7kXHI=; b=haezqG7DjCoy/XwUDm/4CRUj0D GU73y9BGJ+J06CCZYEAV18NSFvK2+1iGFIiL/EywksGvZSXsOWRT56UfygWcyZdAGVUQaRDygq3fi 5UdtXdRTaTjDec1HPK1hOQDqYq3iN92Mo37Yt4cl72XaGjQzR6U8FtV9PSZCJDpjKW5nfVoJqDZdv /+rbcj2vFPXqZkMQG7l21MB3ps0aAmGRP32UT7wbZbkaYrpnrTaVxJUxOxJrs8ok/5JhocgP+EuF1 4FujX3EDXvOfOmpK5JxM0pYpWwOoQpsVeYLBhYaLzA0Ej269G6KQWwR/jyiK9sQxVnHL6JfSE/gD/ rJWAyfeg==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vIlAg-0000000CyKB-0fBo; Tue, 11 Nov 2025 10:00:18 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 4AEE6300328; Tue, 11 Nov 2025 11:55:45 +0100 (CET) Date: Tue, 11 Nov 2025 11:55:45 +0100 From: Peter Zijlstra To: Will Deacon Cc: James Clark , Catalin Marinas , Mark Rutland , Jonathan Corbet , Marc Zyngier , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Leo Yan , Anshuman Khandual , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v9 1/5] perf: Add perf_event_attr::config4 Message-ID: <20251111105545.GJ278048@noisy.programming.kicks-ass.net> References: <20251029-james-perf-feat_spe_eft-v9-0-d22536b9cf94@linaro.org> <20251029-james-perf-feat_spe_eft-v9-1-d22536b9cf94@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 03, 2025 at 02:33:22PM +0000, Will Deacon wrote: > On Wed, Oct 29, 2025 at 03:46:01PM +0000, James Clark wrote: > > Arm FEAT_SPE_FDS adds the ability to filter on the data source of a > > packet using another 64-bits of event filtering control. As the existing > > perf_event_attr::configN fields are all used up for SPE PMU, an > > additional field is needed. Add a new 'config4' field. > > > > Reviewed-by: Leo Yan > > Tested-by: Leo Yan > > Reviewed-by: Ian Rogers > > Signed-off-by: James Clark > > --- > > include/uapi/linux/perf_event.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > > index 78a362b80027..0d0ed85ad8cb 100644 > > --- a/include/uapi/linux/perf_event.h > > +++ b/include/uapi/linux/perf_event.h > > @@ -382,6 +382,7 @@ enum perf_event_read_format { > > #define PERF_ATTR_SIZE_VER6 120 /* Add: aux_sample_size */ > > #define PERF_ATTR_SIZE_VER7 128 /* Add: sig_data */ > > #define PERF_ATTR_SIZE_VER8 136 /* Add: config3 */ > > +#define PERF_ATTR_SIZE_VER9 144 /* add: config4 */ > > > > /* > > * 'struct perf_event_attr' contains various attributes that define > > @@ -543,6 +544,7 @@ struct perf_event_attr { > > __u64 sig_data; > > > > __u64 config3; /* extension of config2 */ > > + __u64 config4; /* extension of config3 */ > > Please can one of the core perf maintainers ack/nak this extension? Acked-by: Peter Zijlstra (Intel)