From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f100.google.com (mail-oa1-f100.google.com [209.85.160.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 812B432695F for ; Tue, 11 Nov 2025 20:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762894760; cv=none; b=UBRaJmvBNVVy+2lcrtxDpVsTOWquictYZVjIqlELIPd9wHB44J+xtuS0VAVfRgmZ7WS7QL/XZgrX0FMCNHrbkwSZeoHxeXkKJRQ4YvDMoBV3gxPHrG3cglcHYg0Pi3SQ5+eq2UqYrJvZdsP+RMItsdHYabHfNcmsiTe3OuSS9Xg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762894760; c=relaxed/simple; bh=2dT7TDGlrC15m2XrfzBdlAKuJGX3p5VzO4/C1evR7kU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zf8fd55HhqU6XQhQNM81R1YUlVcxbEsgWZ+ndQwtC6GLcKqgl4kZm/MxXMeDBp1rqj2UvhkpLa0i+pYAg7B1tU3IhG7O8mJKN/8eiqjYGFSpcqzbbhKqVKgKywVwlJ3Nb8ulcG7l0sa79Lf5TBoxKM1X/bVO3WwsviJQsBsb9o8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=AekwG2hf; arc=none smtp.client-ip=209.85.160.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="AekwG2hf" Received: by mail-oa1-f100.google.com with SMTP id 586e51a60fabf-3e0f19a38d0so113648fac.0 for ; Tue, 11 Nov 2025 12:59:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762894757; x=1763499557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EhBhDYMouQQVQ5LiIxL7eMqigkNt/V1x95UUJwRltOI=; b=qwSDlE6OTXxhFhwTnpiCf+HweCjemMa+NTm5nPdDfgi+fF/9L4aWonTeh1CqQkOVEU kXJEH268FVbePftpdIOgjs82RSlCaKOknwGBCwO+URGzomG70PMwV90hyscwnkvyS5FV nyrwVRoyVOzXFHQqk4Ox8ygDmqs7h8fWfP1oLhcyClwDWLEAVB7UtqFMmxSu/RC0rGOT Qow+2Cfejm8bJ/URsCgPWfqY0Ykh6kguOHPbyWUZwGTAFiF+e1Elbx4MQDKRHokHjqAb kODX5KVgpewHyqKwlxSDiRIzkri4dqEHhyURvW5n06fmCTwLIY5ub+9Ssk0vLPb4//Uu 8OPw== X-Forwarded-Encrypted: i=1; AJvYcCUOGJPEBQu0RxHrhfTadWxfbLQSODK7UlEbW3YErKtXKY+dPLJ5odK0JuLJRykLk2sf5G4koONnfb0UG7o=@vger.kernel.org X-Gm-Message-State: AOJu0YzR0iMTXKSDPQZp8aotnwHkYlA3BaUk8GpqbwSuVQpW0LZdxdwy BIS7k7MW/gb5W3p6fAi5uYOxI9HrpGlbNmNYmGS8IDIGUz6Nxk317Pq1cGUmZqgC6PxB6IPcM0b eqe1l1x9Y1Qp7N/LcDQGIwvx01c3TBBr+t7Vce+Af0ghQ2gVDu30jcHNVU2/07fS/ib2H6kOtpx eBg2SWCQO8uhzO8JgbCCZ/9qhkMgjolk7lAx9jKb3sfXsMozpZn+C1n4aTbo9WmKmXs0rZabNwW qwQZ4NmrIn+pe38iQlibEKmTQ0M X-Gm-Gg: ASbGncsSn5EFF/LA+e9jj0ivM33RGqbjz085FT38Ovsxn52tvvwDP1CWcEaxNU3wqXl ScY+NWsxZH8kavWdprR2sOnn7x2h61AErOUSiarm3IWvwEOlhuq4C66Ofgt1QAWFWH5cl4mueFW gmPHK4wLrvk/mK2uoXCEuKoud7BmabUwx8pGh8sRo1gVZaeMrRsaqxPPguBt1++1NbMjremSdBj 5+q5n+Kt5loDEFcnXeSX32ULZOw6T6Qjb1OvwQHV6ENgi9GxqhT2kga3JyL20p2AGd+lwLo0QXQ bgMUo5woNLQp5RtlvkLxQ57/EL9p5KwhAwYuEk60pkZhG77B1KkYeh3mUrtuLXnFcLof8PAmkWQ SDfYLBIHtVnc5EHubiK55lNXOjNbJeezI7hZFavlRWJYnO2xG4z+jiDjzdbnV+mTxe8PrTimEkz f1/lv3FrJ9jOxR+aSOfWw8QS0UR2w5vg0bheQeihTVTbo= X-Google-Smtp-Source: AGHT+IH7qTtezGGESmC7h48+nbX8xZ3Ey9G4rh4oCla5VX1miaJDcYnuIafTVFIh5GyJrPPcAkd46WBeKKzB X-Received: by 2002:a05:6870:48a:b0:3d2:3344:3bfc with SMTP id 586e51a60fabf-3e833f7a3c8mr268435fac.5.1762894757499; Tue, 11 Nov 2025 12:59:17 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-101.dlp.protect.broadcom.com. [144.49.247.101]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-3e41f3295f2sm1071714fac.21.2025.11.11.12.59.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Nov 2025 12:59:17 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b993eb2701bso119915a12.0 for ; Tue, 11 Nov 2025 12:59:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1762894756; x=1763499556; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EhBhDYMouQQVQ5LiIxL7eMqigkNt/V1x95UUJwRltOI=; b=AekwG2hfz8EU3NvvDEmSEs4ERZcCqXpY5QrCdNjniEfJesdexCygCy8Cj0h8YO+P/6 hfSDmhaMstxtKdnAMIfJ7eA8CgO+LWV6ayU/8lo5GQapqotpy+asOx+1aCmCENj5rBfy FlvPcpoZaIBwRictNSRhpP37TNozolDWHX+NI= X-Forwarded-Encrypted: i=1; AJvYcCWJuIv+E9HK0dVT3R0cLqo3JcDaJ9oMwpjJVmd0+pjz+gZd5sGdAAyvHqiNX9BTjQYnKRQqFkbPbvDKEng=@vger.kernel.org X-Received: by 2002:a05:6a20:5493:b0:352:213a:a22c with SMTP id adf61e73a8af0-3590b02ac3fmr648036637.32.1762894756093; Tue, 11 Nov 2025 12:59:16 -0800 (PST) X-Received: by 2002:a05:6a20:5493:b0:352:213a:a22c with SMTP id adf61e73a8af0-3590b02ac3fmr648019637.32.1762894755654; Tue, 11 Nov 2025 12:59:15 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bbf18b53574sm497131a12.38.2025.11.11.12.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Nov 2025 12:59:15 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [net-next 04/12] bng_en: Handle an HWRM completion request Date: Wed, 12 Nov 2025 02:27:54 +0530 Message-ID: <20251111205829.97579-5-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251111205829.97579-1-bhargava.marreddy@broadcom.com> References: <20251111205829.97579-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Since the HWRM completion for a sent request lands on the NQ, add functions to handle the HWRM completion event. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 4 +- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + .../net/ethernet/broadcom/bnge/bnge_txrx.c | 44 ++++++++++++++++++- 3 files changed, 46 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c index 0b0c398e69a..86f37ca9762 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -18,6 +18,7 @@ #include #include "bnge.h" +#include "bnge_hwrm.h" #include "bnge_hwrm_lib.h" #include "bnge_ethtool.h" #include "bnge_rmem.h" @@ -2318,8 +2319,7 @@ static int bnge_open(struct net_device *dev) static int bnge_shutdown_nic(struct bnge_net *bn) { - /* TODO: close_path = 0 until we make NAPI functional */ - bnge_hwrm_resource_free(bn, 0); + bnge_hwrm_resource_free(bn, 1); return 0; } diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h index a85c251f7b4..8a881ed800e 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -78,6 +78,7 @@ struct tx_cmp { #define CMPL_BASE_TYPE_HWRM_FWD_REQ 0x22UL #define CMPL_BASE_TYPE_HWRM_FWD_RESP 0x24UL #define CMPL_BASE_TYPE_HWRM_ASYNC_EVENT 0x2eUL + #define CMPL_BA_TY_HWRM_ASY_EVT CMPL_BASE_TYPE_HWRM_ASYNC_EVENT #define TX_CMP_FLAGS_ERROR (1 << 6) #define TX_CMP_FLAGS_PUSH (1 << 7) u32 tx_cmp_opaque; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c index 41463d3825b..68ff9a8e277 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -392,6 +392,43 @@ static void __bnge_poll_work_done(struct bnge_net *bn, struct bnge_napi *bnapi, } } +static void +bnge_hwrm_update_token(struct bnge_dev *bd, u16 seq_id, + enum bnge_hwrm_wait_state state) +{ + struct bnge_hwrm_wait_token *token; + + rcu_read_lock(); + hlist_for_each_entry_rcu(token, &bd->hwrm_pending_list, node) { + if (token->seq_id == seq_id) { + WRITE_ONCE(token->state, state); + rcu_read_unlock(); + return; + } + } + rcu_read_unlock(); + dev_err(bd->dev, "Invalid hwrm seq id %d\n", seq_id); +} + +static int bnge_hwrm_handler(struct bnge_dev *bd, struct tx_cmp *txcmp) +{ + struct hwrm_cmpl *h_cmpl = (struct hwrm_cmpl *)txcmp; + u16 cmpl_type = TX_CMP_TYPE(txcmp), seq_id; + + switch (cmpl_type) { + case CMPL_BASE_TYPE_HWRM_DONE: + seq_id = le16_to_cpu(h_cmpl->sequence_id); + bnge_hwrm_update_token(bd, seq_id, BNGE_HWRM_COMPLETE); + break; + + case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT: + default: + break; + } + + return 0; +} + static int __bnge_poll_work(struct bnge_net *bn, struct bnge_cp_ring_info *cpr, int budget) { @@ -442,8 +479,11 @@ static int __bnge_poll_work(struct bnge_net *bn, struct bnge_cp_ring_info *cpr, rx_pkts++; else if (rc == -EBUSY) /* partial completion */ break; + } else if (unlikely(cmp_type == CMPL_BASE_TYPE_HWRM_DONE || + cmp_type == CMPL_BASE_TYPE_HWRM_FWD_REQ || + cmp_type == CMPL_BA_TY_HWRM_ASY_EVT)) { + bnge_hwrm_handler(bn->bd, txcmp); } - raw_cons = NEXT_RAW_CMP(raw_cons); if (rx_pkts && rx_pkts == budget) { @@ -560,6 +600,8 @@ int bnge_napi_poll(struct napi_struct *napi, int budget) work_done += __bnge_poll_work(bn, cpr, budget - work_done); nqr->has_more_work |= cpr->has_more_work; + } else { + bnge_hwrm_handler(bn->bd, (struct tx_cmp *)nqcmp); } raw_cons = NEXT_RAW_CMP(raw_cons); } -- 2.47.3