mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: "zheng.gong" <zheng.gong@samsung.com>
Cc: linux-scsi@vger.kernel.org, avri.altman@wdc.com,
	bvanassche@acm.org, quic_cang@quicinc.com,
	alim.akhtar@samsung.com, martin.petersen@oracle.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] scsi: ufs: crypto: Add ufs_hba_variant_ops::crypto_keyslot_remap
Date: Wed, 12 Nov 2025 03:10:35 +0000	[thread overview]
Message-ID: <20251112031035.GA2832160@google.com> (raw)
In-Reply-To: <20251112030524.3545394-2-zheng.gong@samsung.com>

On Wed, Nov 12, 2025 at 11:05:24AM +0800, zheng.gong wrote:
> Add a new variant operation crypto_keyslot_remap to allow platform-specific
> remapping of crypto keyslot indices before sending requests to the UFS
> controller. This is required on platforms that partition the UFS crypto
> engine's keyslots among multiple domains (e.g.virtual machines),
> where each domain has a keyslot offset.
> 
> To support this, pass the UFS HBA pointer to ufshcd_prepare_lrbp_crypto(),
> so the callback can access platform context.
> 
> This functionality is used on Samsung ExynosAuto UFS platforms, where
> keyslot allocation is per-VM and a runtime offset is applied based on
> the VM ID.
> 
> Signed-off-by: zheng.gong <zheng.gong@samsung.com>
> ---
>  drivers/ufs/core/ufshcd-crypto.h | 10 ++++++++--
>  drivers/ufs/core/ufshcd.c        |  9 +++++----
>  include/ufs/ufshcd.h             |  6 ++++++
>  3 files changed, 19 insertions(+), 6 deletions(-)

This doesn't make sense by itself.  The patch that uses this new method
needs to be submitted alongside it.

- Eric

  reply	other threads:[~2025-11-12  3:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251112030524.3545394-1-zheng.gong@samsung.com>
     [not found] ` <CGME20251112030559epcas5p13358e7b05ca6b39688530b9c8178527e@epcas5p1.samsung.com>
2025-11-12  3:05   ` zheng.gong
2025-11-12  3:10     ` Eric Biggers [this message]
     [not found]       ` <CGME20251127070712epcas5p4113a2d14bd4be7eaef6be6164b1f8cec@epcas5p4.samsung.com>
2025-11-27  7:06         ` [PATCH v2 0/2] scsi: ufs: Add crypto_keyslot_remap support zheng.gong
     [not found]           ` <CGME20251127070721epcas5p43dce5b0a0c4dd7258be71e96ed244359@epcas5p4.samsung.com>
2025-11-27  7:06             ` [PATCH v2 1/2] scsi: ufs: crypto: Add ufs_hba_variant_ops::crypto_keyslot_remap zheng.gong
     [not found]           ` <CGME20251127070724epcas5p40c7960e2a95fa94041225d691a20997e@epcas5p4.samsung.com>
2025-11-27  7:06             ` [PATCH v2 2/2] scsi: ufs: Add crypto keyslot remapping test module zheng.gong
2025-11-27 22:24           ` [PATCH v2 0/2] scsi: ufs: Add crypto_keyslot_remap support Eric Biggers
     [not found]       ` <CGME20251128033713epcas5p450da60155377b3ae43af4d38edb935b2@epcas5p4.samsung.com>
2025-11-28  3:37         ` [PATCH v3 0/1] scsi: ufs: Add crypto_keyslot_remap variant op zheng.gong
     [not found]           ` <CGME20251128033722epcas5p2d083b5b13b48ceabe95b33585e197d2a@epcas5p2.samsung.com>
2025-11-28  3:37             ` [PATCH v3 1/1] scsi: ufs: crypto: Add ufs_hba_variant_ops::crypto_keyslot_remap zheng.gong
2025-11-28  3:47           ` [PATCH v3 0/1] scsi: ufs: Add crypto_keyslot_remap variant op Eric Biggers
     [not found]       ` <CGME20260129031038epcas5p3975b1f66414a7393b85c362523ebe1b8@epcas5p3.samsung.com>
2026-01-29  3:10         ` [PATCH v4 0/3] scsi: ufs: Add crypto_keyslot_remap support zheng.gong
     [not found]           ` <CGME20260129031040epcas5p1446e3f496de82836acdf78a400e6b116@epcas5p1.samsung.com>
2026-01-29  3:10             ` [PATCH v4 1/3] scsi: ufs: crypto: Add ufs_hba_variant_ops::crypto_keyslot_remap zheng.gong
2026-01-29 16:43               ` Bart Van Assche
     [not found]           ` <CGME20260129031043epcas5p36dc864415f55b44ededa232c17d33f39@epcas5p3.samsung.com>
2026-01-29  3:10             ` [PATCH v4 2/3] scsi: ufs: exynos: Support crypto keyslot remapping via DT zheng.gong
     [not found]           ` <CGME20260129031046epcas5p2e13b31bc0b4c47b82020e08c45cb32ca@epcas5p2.samsung.com>
2026-01-29  3:10             ` [PATCH v4 3/3] dt-bindings: ufs: Add binding for ufs-keyslot-offset zheng.gong
2026-01-29  3:31           ` [PATCH v4 0/3] scsi: ufs: Add crypto_keyslot_remap support Eric Biggers
     [not found]       ` <CGME20260129061800epcas5p27ea107df6d3b296e4a63d948a8d6af17@epcas5p2.samsung.com>
2026-01-29  6:17         ` zheng.gong
2026-01-29  7:42           ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251112031035.GA2832160@google.com \
    --to=ebiggers@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=quic_cang@quicinc.com \
    --cc=zheng.gong@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®