From: Borislav Petkov <bp@alien8.de>
To: Michal Pecio <michal.pecio@gmail.com>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Eric DeVolder <eric.devolder@oracle.com>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH] x86/acpi/boot: Correct acpi_is_processor_usable() check again
Date: Wed, 12 Nov 2025 20:17:40 +0100 [thread overview]
Message-ID: <20251112191740.GGaRTdVGCKm06z0EnZ@fat_crate.local> (raw)
In-Reply-To: <20251112190518.2056dab3.michal.pecio@gmail.com>
On Wed, Nov 12, 2025 at 07:05:18PM +0100, Michal Pecio wrote:
> Nitpick: IMO logic would be easier to follow if written this way:
>
> if (lapic_flags & ACPI_MADT_ENABLED)
> return true;
>
> if (acpi_support_online_capable)
> return lapic_flags & ACPI_MADT_ONLINE_CAPABLE;
>
> /* we should say 'no' at this point, but VMs are crazy */
> return !hypervisor_is_type(X86_HYPER_NATIVE);
Sure, except I'd like to keep the original comment as that leaves more
breadcrumbs about why we're doing this insanity.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2025-11-12 19:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 14:53 Yazen Ghannam
2025-11-12 13:56 ` Borislav Petkov
2025-11-12 16:35 ` Mario Limonciello
2025-11-12 17:21 ` Borislav Petkov
2025-11-13 14:27 ` Borislav Petkov
2025-11-13 14:30 ` Mario Limonciello
2025-11-13 14:34 ` Borislav Petkov
2025-11-13 14:55 ` Mario Limonciello
2025-11-12 18:05 ` Michal Pecio
2025-11-12 19:17 ` Borislav Petkov [this message]
2025-11-14 16:23 ` Ricardo Neri
2025-11-14 16:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112191740.GGaRTdVGCKm06z0EnZ@fat_crate.local \
--to=bp@alien8.de \
--cc=eric.devolder@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michal.pecio@gmail.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®