From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AEB02C158F for ; Thu, 13 Nov 2025 19:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763061746; cv=none; b=NfIxGFkx3CYyEeSkvIHWGEr/HcDTq+8eBRjmga/xVhYJ774JsjkAHZjaxsU2YwJAphIf/a2QaPXTzulZ6/6o9KNBQ4dupAjkVO0arQ2njl10oKyOLvIeYuzMqTj4Vm9WuFrL5BDwpzicpZAKtqiKTwEto9ON+uHntDmjTohS4GI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763061746; c=relaxed/simple; bh=6GSPpH4JqV7cJATH5sxmvD3vVcA2TwGkxC88JIVFRIU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tdFVob7+8YsEGYuD4JDjMz/Rhkj8l8kw0Z3M1Usk7SJUT2ZzjafBihUMsdpqAjKkhbxPhaNJbFKvQ9NOWQVQlnZpyxAe/7oV+C6wwZMxum9jur+0DY+uFdFnBKl67DmFavjat6wf4gfKOyCFRjkZsdlB5jdUDR1S/JsV5co7txs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nLlvBkZJ; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nLlvBkZJ" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47778b23f64so9540315e9.0 for ; Thu, 13 Nov 2025 11:22:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763061743; x=1763666543; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=aP34M4Porl2Kml84YDC6rvjo3kn0PHOh2ZYJyPAftOg=; b=nLlvBkZJPrTwIxsI0ZNNIbwfvLRV9Kb2xEOrDkG6DAikc9u+6CDQUjE92csBocuyVn yN3qP2RpxTO/o1dfmj6twYseBTOAZJhMCgRUS4o8qOQ3b8JTF7Isqk99ZaQjIR9f9eBA bWckwyOU6ov1PahGIP/O7AaEtjrQwFrh8JxPN6g03DdVCDQkQgW43eVhImGMC89KicKz crd1uRkjNe77fWapS5QqEdtz/DD8XIHE0s/wCRNHitB5+zVlvhSZcr3CbtMFjakN7YLK ThjKWdTz+OK7pf38vNJlY0pFP7UOZnW3tan51ct/x7lemoKTLnyvoo/SGCC4YCTIKeJ5 piVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763061743; x=1763666543; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aP34M4Porl2Kml84YDC6rvjo3kn0PHOh2ZYJyPAftOg=; b=ekPYdQaBTQfLZBK2wsuV8u/DmhEunx1JDnG8hPrN5k6uBzjI/g2GBrhEQaZLRAR/jQ cvlHr79pNEWtFkmdQZEadRUj7pRwTjJJCFh86gzLp+QDTWeePZdnlL1ZTs7GQMk7Mrzi euN03vEIEQmjttv8i0LsM/ALGmVdyclHdptEWUp9cl2v0a0eiDO49mhflp23YoFQp8T8 GTHdaI6jXkJYS5ZGz6sxgG/+JrwjkWySRcrUk8O50GTTTaOanU5x9eulZldBQ5FLU90n u81UZSYaBTw5Rz8/3hHHccuIhZWxf6Fi+VD8JBLykfAO7UEZmUCzKscaqTWDMBAMYkWw WsXw== X-Forwarded-Encrypted: i=1; AJvYcCX63y8C/b4odoQX8RB2Ul6gzVMuvGr7nIeydzJ7P+nEe4W6uo1ZAb93LPLpt9qGMWs//wgr369D3DKI8BM=@vger.kernel.org X-Gm-Message-State: AOJu0YynVvrBIfpw0049WU7f8f4799Hulh0NCM/4hrwT6rDDY1ugte8r 137xEIZ9Hb2nhVjEdtaaIS2AA0s6J0rAHBT3XBNI2XYEHmvVgN1IBTo1 X-Gm-Gg: ASbGncsNn5OU2Rj/5tUvl6/Ta1FgeN3EZgUHH2pRzCfW2E2FJUdv6EJxdHIqPhNRBih ZQ04vi5JQHb0iQB+nkDa72YvCACYGdbmuVpuuEJHCuHDUofOQnS6VEi3Ae2PDtRYRfVgg9ZcvyJ 2MHeM0skdzbvqZAVHjrcLrZYfOaTCLoWDiNO9KzTvtXBJdeuq97xF1HDSZLaJEK4yIJym8gfJDO 48Nd+41ReixNZtyAa2U1Pk75kg9AfO5MNnZj7am/5LZKBAYGJv4HcXipxT8o33vgg9ZY6l7/jvw 9/ZuY4/JB0uOirHTrJ8KRkauj9DqPDHlj0eSIC5sI9/o5o6jksLsDA87nAgky+3pCM9CZ/2Xt6C A0/dF4Wbf7mb3dmbuidgg04i0jvMpZGLWmGVS6EEl4ws10uFNt8VavxM5A/E217VxbdfJp8zlzX Z30CryYakwgWAxbbpD/JyWhNjQIwp9SRyIxKACsUDFvYoLMRevTygk X-Google-Smtp-Source: AGHT+IFnzCac5LPqhF1dr/JQF1yR6r6fyY87UXe+SLTMp8uw4OIWkmG8Cr/NlSy5VqlWNjVFIrwUeA== X-Received: by 2002:a05:600c:8b43:b0:477:561f:6fc8 with SMTP id 5b1f17b1804b1-4778fe50f6dmr6586875e9.5.1763061742774; Thu, 13 Nov 2025 11:22:22 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778bcf75b8sm27665445e9.1.2025.11.13.11.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 11:22:22 -0800 (PST) Date: Thu, 13 Nov 2025 19:22:18 +0000 From: David Laight To: Shi Hao Cc: pavan.chebbi@broadcom.com, mchan@broadcom.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: broadcom: replace strcpy with strscpy Message-ID: <20251113192218.3c17dabc@pumpkin> In-Reply-To: <20251113082517.49007-1-i.shihao.999@gmail.com> References: <20251113082517.49007-1-i.shihao.999@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 13 Nov 2025 13:55:17 +0530 Shi Hao wrote: > Replace strcpy function calls with strscpy to ensure bounds checking > in the destination buffer, preventing buffer overflows and improving > security. This change aligns with current kernel coding guidelines > and best practices. > ... > - strcpy(tp->board_part_number, "BCM5717"); > + strscpy(tp->board_part_number, "BCM5717", TG3_BPN_SIZE); No one really knows that TG3_BPN_SIZE is in any way related to the destination. So this doesn't actually make the code that much better at all. Since tp->board_part_number is an array and "BCM5717" a constant I suspect there is already a compile-time check that the string fits. The strcpy() will also be converted to a memcpy(). So all, in all, this makes the code worse on several fronts. David