From: Fenglin Wu via B4 Relay <devnull+fenglin.wu.oss.qualcomm.com@kernel.org>
To: kernel@oss.qualcomm.com, Lee Jones <lee@kernel.org>,
Pavel Machek <pavel@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: Subbaraman Narayanamurthy
<subbaraman.narayanamurthy@oss.qualcomm.com>,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Fenglin Wu <fenglin.wu@oss.qualcomm.com>
Subject: [PATCH] leds: rgb: leds-qcom-lpg: Only enable TRILED when LPG is used by LED
Date: Fri, 14 Nov 2025 09:11:17 +0800 [thread overview]
Message-ID: <20251114-lpg_triled_fix-v1-1-9b239832c53c@oss.qualcomm.com> (raw)
From: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
Enabling the TRILED channel will cause a voltage increase on its power
supply, which is unnecessary if the LPG channel is not being used to
control an LED.
Fixes: 24e2d05d1b68 ("leds: Add driver for Qualcomm LPG")
Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
---
drivers/leds/rgb/leds-qcom-lpg.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
index 4f2a178e3d265a2cc88e651d3e2ca6ae3dfac2e2..234059b4c0f49d0398030ae5f86967fc1905206d 100644
--- a/drivers/leds/rgb/leds-qcom-lpg.c
+++ b/drivers/leds/rgb/leds-qcom-lpg.c
@@ -2,7 +2,7 @@
/*
* Copyright (c) 2017-2022 Linaro Ltd
* Copyright (c) 2010-2012, The Linux Foundation. All rights reserved.
- * Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
*/
#include <linux/bits.h>
#include <linux/bitfield.h>
@@ -1247,7 +1247,9 @@ static int lpg_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
lpg_apply(chan);
- triled_set(lpg, chan->triled_mask, chan->enabled ? chan->triled_mask : 0);
+ /* Only control TRILED if the LPG channel is used by TRILED */
+ if (chan->in_use && chan->triled_mask)
+ triled_set(lpg, chan->triled_mask, chan->enabled ? chan->triled_mask : 0);
out_unlock:
mutex_unlock(&lpg->lock);
---
base-commit: ea1c4c7e648d1ca91577071fc42fdc219521098c
change-id: 20251114-lpg_triled_fix-44491b49b340
Best regards,
--
Fenglin Wu <fenglin.wu@oss.qualcomm.com>
next reply other threads:[~2025-11-14 1:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 1:11 Fenglin Wu via B4 Relay [this message]
2025-11-14 4:58 ` Bjorn Andersson
2025-11-14 7:13 ` Fenglin Wu
2025-11-14 14:56 ` Bjorn Andersson
2025-11-17 2:22 ` Fenglin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114-lpg_triled_fix-v1-1-9b239832c53c@oss.qualcomm.com \
--to=devnull+fenglin.wu.oss.qualcomm.com@kernel.org \
--cc=andersson@kernel.org \
--cc=fenglin.wu@oss.qualcomm.com \
--cc=kernel@oss.qualcomm.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=pavel@kernel.org \
--cc=pavel@ucw.cz \
--cc=subbaraman.narayanamurthy@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®