mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maud Spierings via B4 Relay <devnull+maudspierings.gocontroll.com@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	 Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Maud Spierings <maudspierings@gocontroll.com>
Subject: [PATCH] net: phy: fix doc for rgii_clock()
Date: Fri, 14 Nov 2025 12:39:32 +0100	[thread overview]
Message-ID: <20251114-rgmii_clock-v1-1-e5c12d6cafa6@gocontroll.com> (raw)

From: Maud Spierings <maudspierings@gocontroll.com>

The doc states that the clock values also apply to the rmii mode,
"as the clock rates are identical". But as far as I can find the
clock rate for rmii is 50M at both 10 and 100 mbits/s [1].

Link: https://en.wikipedia.org/wiki/Media-independent_interface [1]

Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
This patch is also part question, I am working on an imx8mp based device
with the dwmac-imx driver. In imx_dwmac_set_clk_tx_rate() and
imx_dwmac_fix_speed() both rmii and mii are excluded from setting the
clock rate with this function.

But from what I can read only rmii should be excluded, I am not very
knowledgable with regards to networkinging stuff so my info is
coming from wikipedia.

I am adding this exclusion to the barebox bootloader, but I am not sure
if I should also be excluding mii as is being done upstream.
---
 include/linux/phy.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/phy.h b/include/linux/phy.h
index bf5457341ca8..e941b280c196 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -296,9 +296,9 @@ static inline const char *phy_modes(phy_interface_t interface)
  * @speed: link speed value
  *
  * Description: maps RGMII supported link speeds into the clock rates.
- * This can also be used for MII, GMII, and RMII interface modes as the
- * clock rates are identical, but the caller must be aware that errors
- * for unsupported clock rates will not be signalled.
+ * This can also be used for MII and GMII interface modes as the clock rates
+ * are identical, but the caller must be aware that errors for unsupported
+ * clock rates will not be signalled.
  *
  * Returns: clock rate or negative errno
  */

---
base-commit: 0f2995693867bfb26197b117cd55624ddc57582f
change-id: 20251114-rgmii_clock-1389d0667bf7

Best regards,
-- 
Maud Spierings <maudspierings@gocontroll.com>



             reply	other threads:[~2025-11-14 11:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 11:39 Maud Spierings via B4 Relay [this message]
2025-11-14 11:54 ` Maud Spierings
2025-11-14 12:48 ` Russell King (Oracle)
2025-11-14 14:10   ` Maud Spierings
2025-11-14 15:42     ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114-rgmii_clock-v1-1-e5c12d6cafa6@gocontroll.com \
    --to=devnull+maudspierings.gocontroll.com@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maudspierings@gocontroll.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®