From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C41928C035
	for <linux-kernel@vger.kernel.org>; Fri, 14 Nov 2025 21:53:05 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1763157185; cv=none; b=IUMajj2IOlNzH8jeonGaVT3daPkDKlVm5SwS0W/TQH26ShzB213DbRW85bkeF4yuTAABNK+WEC6/xA7WZmoYY7ze3GDTZSeohjbXLaTiCFy6SKqy0LQ8LmVutAvaB3K3RWa4KnP/Neyy0cGyP/eXoiAij5r180hNC5sNtFy4mEs=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1763157185; c=relaxed/simple;
	bh=OioRQDnf4lhCgkjSXiw+WwXRHc4hatCt51SsKc1i+ro=;
	h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:
	 Mime-Version:Content-Type; b=L37jYNlHsphL6T6Z4wwRrHvQsqhC/U9HLE+1LaDTDxmH259IETcETA4KqDDI804/1/qg/FUOHd78wwFnxSRNe2FgU4I4S2lJbMMcluttFkyWOsOjl0Wix/Lfa5dkjPwRyYFeyZmcAtgIfWxzED2ezl7EQxDoj9kDs/XGB+oAuaM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=1jjvEUtR; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="1jjvEUtR"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C113EC113D0;
	Fri, 14 Nov 2025 21:53:04 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1763157185;
	bh=OioRQDnf4lhCgkjSXiw+WwXRHc4hatCt51SsKc1i+ro=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=1jjvEUtRxgda6i5U406a00pzwyzeUzq5A45UQpyVxmP3DaCbefDV6VywV6bKKk4ql
	 DKA1isuTAJIAovWHvYZ4KcIX4whmhxzGiMvNCVNPOqn1u6/WSaBqWV1fQ4Fi9UNmgu
	 GPPg7UwpJmzFoNYBQDb2W8iBJip8MB452xJi5UM8=
Date: Fri, 14 Nov 2025 13:53:03 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: David Hildenbrand <david@kernel.org>, "Liam R . Howlett"
 <Liam.Howlett@oracle.com>, Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport
 <rppt@kernel.org>, Suren Baghdasaryan <surenb@google.com>, Michal Hocko
 <mhocko@suse.com>, Jann Horn <jannh@google.com>, Pedro Falcato
 <pfalcato@suse.de>, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] make VM_SOFTDIRTY a sticky VMA flag
Message-Id: <20251114135303.878b52f6db3dea4596f4c11a@linux-foundation.org>
In-Reply-To: <cover.1763142412.git.lorenzo.stoakes@oracle.com>
References: <cover.1763142412.git.lorenzo.stoakes@oracle.com>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 14 Nov 2025 17:53:17 +0000 Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:

> Currently we set VM_SOFTDIRTY when a new mapping is set up (whether by
> establishing a new VMA, or via merge) as implemented in __mmap_complete()
> and do_brk_flags().
> 
> However, when performing a merge of existing mappings such as when
> performing mprotect(), we may lose the VM_SOFTDIRTY flag.
> 

userspace-visible effects?

Documentation/admin-guide/mm/soft-dirty.rst tells me that this can
already happen in other circumstances so I guess it isn't very serious.
CRIU inefficiency.  perhaps?

Please review Documentation/admin-guide/mm/soft-dirty.rst, check that
it is complete and accurate?