From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67361326931 for ; Fri, 14 Nov 2025 14:31:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763130672; cv=none; b=pj6X6jQj7jsWFHnm6DYPpesC5ZbUqM06Z7WPtbPQcE2vUcwAXIq4zs6Egq1Q/3FhlE3ag2kcvsI8fNqFFyJD2rcvrWIK21aSpBj5TNy8W9C1oGMIR63tf8WK3aQYqHZ7gamu3GPxPND4rY4f6SFvw53VGu9IJd5nggReT+X5oAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763130672; c=relaxed/simple; bh=0Nd/5UcvGGQ3wMP5hcatUCUy3cHNlcIa0pLV8mrh2PI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fVVwRZzDmXLJ1EB66E6sDgo9lcluYrUgU5NOGwycxviAjp9Q7KGazZY3Lh1W1vOswWa1bCwwNGsERf4jEP/DGTj0miREaL4BQ2BUPWzck1IkcWI7Z9wlKh5BKUV0782WP3O4hMqKVI2J2b2YsCsVUVCfCEMlVJ4Jwimx61zFT3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bvLIYH1o; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bvLIYH1o" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47778b23f64so15526395e9.0 for ; Fri, 14 Nov 2025 06:31:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763130669; x=1763735469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=u6MM5TkUOF6yH5fMK7JZqRWlPSfFjm0LYdpGBKMINJc=; b=bvLIYH1o1IpNbLxVqQ6aKlD4aKiTsEHoZcqbtHJlN62d/tsdq3D/pHySBHF5h9P/XI bmdrO2y30oLWn02fNg8A5qRtfd/oMOy+f7qXKetyTRHwDFNJm0OBzc81uE5vUE6BVP8/ WngbtDT3ygRygnxn8DG0aL22SXE+umYDi+B64iPwpXdczMpGoLXZsN3kLULNkvhUJJ1k JQ7lmv7zMJQsHjHwn1jq7Vc9HOnNTCOdfpHrSZ9GzqHtt52sY0LkVdWtMoXfZXP94A9X ELbJZ3lw5A0Q8chudyvVZaBCVsiMimU1f6bLSKIvMqdoM8YbeeO84NYFL9iXzLhUgqZu Vx6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763130669; x=1763735469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=u6MM5TkUOF6yH5fMK7JZqRWlPSfFjm0LYdpGBKMINJc=; b=jTQ/+VfyirnwsdwJ0aamA9rVKAldputA2DFWtBjOmQjBwOhn6FwWul+W1I95jZOuUZ H5oC20SW677CHsrju6z9pqwzV79Y4zqobUotFkNTZCjrPrWYBM9LxxgPoLiwBsB3/xdP jAcqwu/yQE7cm2VzkVxRHNUx/i1PwKQhK94tp7eU/YsS97J3TVg1/fXy0jp8U+JTDXAH 9qRrqzIBSvACfBaXGBJlegtSY5AJX2qXA85LBWNm3adjAaAxdm7XstD856f/R3AjgNX2 J9yt3qIKmt9z7jCgdhVhcKogGwB/MvQ/HOLKYyjYCMG8RDG13Ka6YO7l7t0GSfSQjfwd w1BA== X-Forwarded-Encrypted: i=1; AJvYcCWVQTHBYt2SsdWSNCjcUyCu0Mn5CqbPBhHnxBd5ejZiTBbJoHIngnem2yNa/flR4Px6GsHFYo596lNlF30=@vger.kernel.org X-Gm-Message-State: AOJu0Yyn2UK9ojn6BuXsn8h5Etu1wXMmdwBZZXWh1VTyR5xYCEwr+D/e vH58IOjNJPHvWJlFVBqaImMh1stPvLA9ZLwWaMG4tt2d5farF7L0JH0R X-Gm-Gg: ASbGnct/PySa+RR9l2hlT9DeYgeigZWADy0MKNO7WNX5FJbNI6L1QO2Ew+d4bzWUh/m R6KVL7YnWzxnCB1G9ykFa69RN0A95kpmzYLhGUDgKf7vXA+lBwfJQR3wxDXbkE2cohfkSOX+R5y TxC5UtvqvgkYlZT5dUHMVtdVYAzXWsw9u+PGFHfriOX7leMxDGUipvDEU00QkW3i0syIb+U6NYf sYJ5IaNtljLRKxK/l4XMBsoYkZyYWpda46E03aVRQXxosZbh3ZCscsksiCfkSh2gRokflK6C/tw XcLusLU/xhDWAvQgRK91Li2VWjAOwfrH6Q8NJrh733175wOh2R5v1oIuH3tJ5A7CSj40VMnLV77 MphQ3dwrcSIhK81H0dHorV/W6W6/TTvgY/NjvI1L0ELIw9Ae1o+L+H4g0AmgpQdr1cBqDBIdLqe kHr+wyjzN8XKULzVu59gRHBg1HUUl4vyu5/llQaN0lfOZU+Und68IZ X-Google-Smtp-Source: AGHT+IEHrDuoHFECjPf0CKJ/87IcJrAsvvtIb2nB8T6rg1oWoh16xlEJf+x0ICRT7Ao9WTxW06pbKQ== X-Received: by 2002:a05:600c:4513:b0:477:2f7c:314f with SMTP id 5b1f17b1804b1-4778fe5c820mr32213275e9.10.1763130668582; Fri, 14 Nov 2025 06:31:08 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47795268e0asm9388645e9.6.2025.11.14.06.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 06:31:08 -0800 (PST) Date: Fri, 14 Nov 2025 14:31:04 +0000 From: David Laight To: Steven Rostedt Cc: Thorsten Blum , Josh Poimboeuf , Kees Cook , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] unwind deferred: Annotate struct unwind_cache with __counted_by Message-ID: <20251114143104.0d1aead3@pumpkin> In-Reply-To: <20251114084346.6469edc0@gandalf.local.home> References: <20251114122748.222833-1-thorsten.blum@linux.dev> <20251114084346.6469edc0@gandalf.local.home> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 14 Nov 2025 08:43:46 -0500 Steven Rostedt wrote: > On Fri, 14 Nov 2025 13:27:47 +0100 > Thorsten Blum wrote: > > > Add the __counted_by() compiler attribute to the flexible array member > > 'entries' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and > > CONFIG_FORTIFY_SOURCE. > > > > Signed-off-by: Thorsten Blum > > --- > > include/linux/unwind_deferred_types.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/unwind_deferred_types.h b/include/linux/unwind_deferred_types.h > > index 33b62ac25c86..d4b67f0116f3 100644 > > --- a/include/linux/unwind_deferred_types.h > > +++ b/include/linux/unwind_deferred_types.h > > @@ -5,7 +5,7 @@ > > struct unwind_cache { > > unsigned long unwind_completed; > > unsigned int nr_entries; > > - unsigned long entries[]; > > + unsigned long entries[] __counted_by(nr_entries); > > }; > > > > /* > > Wrong! > > I need to add a comment here that entries is not bound by nr_entries. > > https://lore.kernel.org/all/20250730093249.4833be14@gandalf.local.home/ > > Maybe this?: > > diff --git a/include/linux/unwind_deferred_types.h b/include/linux/unwind_deferred_types.h > index 33b62ac25c86..d05409bb14fa 100644 > --- a/include/linux/unwind_deferred_types.h > +++ b/include/linux/unwind_deferred_types.h > @@ -5,7 +5,7 @@ > struct unwind_cache { > unsigned long unwind_completed; Does that need to be 'long' - 'int' would fit in the padding on 64bit. > unsigned int nr_entries; > - unsigned long entries[]; > + unsigned long entries[]; /* Fixed size, not bound by nr_entries */ > }; Perhaps it should be: unsigned long entries[ /* MAX_UNWIND_ENTRIES */ ]; David > > /* > > > > -- Steve >