From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f225.google.com (mail-vk1-f225.google.com [209.85.221.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EFCA34A77C for ; Fri, 14 Nov 2025 19:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763150081; cv=none; b=IOngP0DSEwBeUIyufrs31gkzhazTpxIc1Bezbb3mRtE+nJsMOynb24TG+SFrBkMvq4xH7hfVcmhM5dq+qtzjoPEimObw8zl2HjlRUKomntIRJsZTuzJ8c76B5FQFoWoK7SeQGS7rMqZ91r0Rx/KTWkhVJ6CwRTaeAp+IQ7m7y1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763150081; c=relaxed/simple; bh=OrD9Ux1I7rP754bI5lNMmoREVCGshVzoAURrDF98QP0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sGIPxfkkhvDsmSAO2fWY/oVHkkOVf/pY3bLTYGmHCwbKwGfylPGW0ZbB2Bc6fSWHbl0PW4exUF4zuf5ZT3Y9qGOEok6reKXJwC/grEvNk0O1a4dpctbo/CKQrcdTzBhW+9D5HT5x3KHzd6eG/jLnCclSN+Q1UGB1z/a9tuqhaDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ZVEQFr8Q; arc=none smtp.client-ip=209.85.221.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ZVEQFr8Q" Received: by mail-vk1-f225.google.com with SMTP id 71dfb90a1353d-55b104727c8so630749e0c.0 for ; Fri, 14 Nov 2025 11:54:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763150078; x=1763754878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uto9E9SZ6tzS7AVoNvWU4Gi1aUc7ff/KJq+z0rhWh2o=; b=ikqK1dNnZFB9FSjvgSvqb6opT6pqqzqTtisqn3iMljykZYN87KS9pJQxpvtKhA6pDi l5uIUr/1A+aF264TdhRTigwO4nnlS+mLn3DRz/d759J2QDo0KJQlERqH9ZYlVAyjtEzV wZcs0kR45FVyVT12gQH+AXjS9SHxRTyWGAn8cdDbkxsv6Bg21TmHTksSc0RyNGlVOwj5 9+mFMB3P8b2SUukpMQoVHfIUSfLYiN7thOsVq7/Dtb0x7i3HKzHvN5/uE+kmI1hE0zWl GqrUAG+l323zBZWDbQ6ktcjhpclUDmxTpFQ28qLV8k/UYkW19RC+fHhwLl/RMZdsFAet G9dw== X-Forwarded-Encrypted: i=1; AJvYcCXC1W1NQ8fsR4166aaB+/I2GmGz6CJ2BNy99fH5hKXm2HeLLlG+RRASKG8/7147huas6Xidj7iyrREQTX0=@vger.kernel.org X-Gm-Message-State: AOJu0YzxIRZu/feBDP5pLQlZiu/VY6v0uALslUUa37UI393xTTikXlnA iQEfLXRS2NQ8DVDuV2RuK5/y0LraZxco6M8s/WMg3MoZL8/XeT5dOQR2/4UUyT4lx2LFw1A45cx gHDNpp2KaQ6fOnOeCh/iIo/TV+9btWZOKv649PPGbQrdhXx592s1tKYB67UX0GNMWcElTShY0hl 0+6rUDS4c1cuzsUGE2ri/eQcekYzZZMqJEGTH8gVO6hUO6fRA/dfoDNpmR2Kk1qQLBwjWLe2hDQ Smep2LrHLkmTtQcj3eePbf2gA== X-Gm-Gg: ASbGnctk/U7ENnR5SAB4tIV7HdhiDyHTFXao8TQfw84V9kOPDQxon/YaBuq20qBaq1T rcQ5hKZ7DI4q0YTWrGKHle1g5jMw/n8/U3+iuZSP7/yzbGoIbSYM20Hwrt6sC+sqSLZxVfqpdru EM6RwwciNgO3iTuNy1ub9HKk91yFo+WDbp+hWrN3txKpBr6cLVrBM6RF75iGIBHbK0y+7INuqR+ F3PVVCgnhMysqv9dYWAQILXczh7QXdNysdyMbp1/LfRRtz7EfuCx7IBOmYwMRcg0RK1LGKV5CBM zhEGAuJWSbOUJ701EdthQ0PXSzEKj3yWr0b5MYbymo96lsExiFiY/bp42c59w4FgQ+1/P+cNZBg sboRvsfflu91BmtNj8a+HEh8ERGHYQZCylSoxd3+rmKb5SQ3sD97lv164f+CZNN7xcsYOxvnhLd ecPdTR1Qbbztxzgj7vaUzJueZ1IJN8lg4pW/T7IYZxWG8= X-Google-Smtp-Source: AGHT+IGTdar129asS+BoWYpQPKyDynPgCFwn9Vw9WAE8Tgr/9223ZvHP/ppVkEXl0pCaRQqNVJYZxx4T6hMT X-Received: by 2002:a05:6122:328f:b0:55b:d85:507a with SMTP id 71dfb90a1353d-55b1bd67164mr1532579e0c.7.1763150077936; Fri, 14 Nov 2025 11:54:37 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-101.dlp.protect.broadcom.com. [144.49.247.101]) by smtp-relay.gmail.com with ESMTPS id 71dfb90a1353d-55b0f1e49b0sm643993e0c.0.2025.11.14.11.54.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Nov 2025 11:54:37 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29806c42760so78655795ad.2 for ; Fri, 14 Nov 2025 11:54:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1763150077; x=1763754877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uto9E9SZ6tzS7AVoNvWU4Gi1aUc7ff/KJq+z0rhWh2o=; b=ZVEQFr8QJv1dSTYsJLjDuILxwlL0IUHrfkbjtDRVKKZnzyKWQkBqwLQz6DNrE7jopj 7St50jD3MHlcbyCeS/TE1SPzzSxVPTRLriUp66mCMtQxO8fe745HcrP5cDtUfaYlXMTT 0oaS0tTvMvzQepGXyYAttm2jLDJ4EVqZ1klMo= X-Forwarded-Encrypted: i=1; AJvYcCW9Ki+waFb87F2JgWQyMJbgxxsS8LO/1k5pm7o3kTZ3ZyLvazEuJHEpNseLcCQiZTASv4rdaNUVMxouPdI=@vger.kernel.org X-Received: by 2002:a17:903:198d:b0:298:2de9:e312 with SMTP id d9443c01a7336-2986a76b898mr50608595ad.59.1763150076736; Fri, 14 Nov 2025 11:54:36 -0800 (PST) X-Received: by 2002:a17:903:198d:b0:298:2de9:e312 with SMTP id d9443c01a7336-2986a76b898mr50608365ad.59.1763150076341; Fri, 14 Nov 2025 11:54:36 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-343ea5f9fa4sm3108113a91.0.2025.11.14.11.54.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 11:54:35 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v2, net-next 11/12] bng_en: Create per-PF workqueue and timer for asynchronous events Date: Sat, 15 Nov 2025 01:22:59 +0530 Message-ID: <20251114195312.22863-12-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251114195312.22863-1-bhargava.marreddy@broadcom.com> References: <20251114195312.22863-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Use a dedicated workqueue and timer for each PF to handle events. This sets up the infrastructure for the next patch, which will implement the event handling logic. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- drivers/net/ethernet/broadcom/bnge/bnge.h | 10 ++++++ .../net/ethernet/broadcom/bnge/bnge_core.c | 35 ++++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 31 ++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 4 +++ 4 files changed, 79 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge.h b/drivers/net/ethernet/broadcom/bnge/bnge.h index 33b42408b1d..88b904246f5 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge.h @@ -136,6 +136,7 @@ struct bnge_dev { unsigned long state; #define BNGE_STATE_DRV_REGISTERED 0 #define BNGE_STATE_OPEN 1 +#define BNGE_STATE_IN_SP_TASK 2 u64 fw_cap; @@ -208,9 +209,18 @@ struct bnge_dev { u8 max_q; u8 port_count; + unsigned int current_interval; +#define BNGE_TIMER_INTERVAL HZ + + struct timer_list timer; struct bnge_irq *irq_tbl; u16 irqs_acquired; + struct workqueue_struct *bnge_pf_wq; + struct work_struct sp_task; + unsigned long sp_event; +#define BNGE_PERIODIC_STATS_SP_EVENT 0 + /* To protect link related settings during link changes and * ethtool settings changes. */ diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_core.c b/drivers/net/ethernet/broadcom/bnge/bnge_core.c index 2c72dd34d50..dfa501f912a 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_core.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_core.c @@ -238,6 +238,23 @@ static int bnge_map_db_bar(struct bnge_dev *bd) return 0; } +static struct workqueue_struct * +bnge_create_workqueue_thread(struct bnge_dev *bd, char thread_name[]) +{ + struct workqueue_struct *wq; + char *wq_name; + + wq_name = kasprintf(GFP_KERNEL, "%s-%s", thread_name, + dev_name(bd->dev)); + if (!wq_name) + return NULL; + + wq = create_singlethread_workqueue(wq_name); + + kfree(wq_name); + return wq; +} + static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent) { unsigned int max_irqs; @@ -277,6 +294,10 @@ static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_devl_free; } + INIT_WORK(&bd->sp_task, bnge_sp_task); + timer_setup(&bd->timer, bnge_timer, 0); + bd->current_interval = BNGE_TIMER_INTERVAL; + rc = bnge_init_hwrm_resources(bd); if (rc) goto err_bar_unmap; @@ -318,14 +339,24 @@ static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_config_uninit; } + bd->bnge_pf_wq = bnge_create_workqueue_thread(bd, "bnge_pf_wq"); + if (!bd->bnge_pf_wq) { + dev_err(&pdev->dev, "Unable to create workqueue.\n"); + rc = -ENOMEM; + goto err_free_irq; + } + rc = bnge_netdev_alloc(bd, max_irqs); if (rc) - goto err_free_irq; + goto err_free_workq; pci_save_state(pdev); return 0; +err_free_workq: + destroy_workqueue(bd->bnge_pf_wq); + err_free_irq: bnge_free_irqs(bd); @@ -356,6 +387,8 @@ static void bnge_remove_one(struct pci_dev *pdev) bnge_netdev_free(bd); + destroy_workqueue(bd->bnge_pf_wq); + bnge_free_irqs(bd); bnge_net_uninit_dflt_config(bd); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c index f00576dd5e0..872c8b6a9be 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -253,6 +253,33 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } +void bnge_timer(struct timer_list *t) +{ + struct bnge_dev *bd = timer_container_of(bd, t, timer); + struct bnge_net *bn = netdev_priv(bd->netdev); + struct net_device *dev = bd->netdev; + + if (!netif_running(dev) || !test_bit(BNGE_STATE_OPEN, &bd->state)) + return; + + if (atomic_read(&bn->intr_sem) != 0) + goto bnge_restart_timer; + +bnge_restart_timer: + mod_timer(&bd->timer, jiffies + bd->current_interval); +} + +void bnge_sp_task(struct work_struct *work) +{ + struct bnge_dev *bd = container_of(work, struct bnge_dev, sp_task); + + set_bit(BNGE_STATE_IN_SP_TASK, &bd->state); + smp_mb__after_atomic(); + + smp_mb__before_atomic(); + clear_bit(BNGE_STATE_IN_SP_TASK, &bd->state); +} + static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) { struct bnge_ring_struct *ring = &nqr->ring_struct; @@ -2111,6 +2138,7 @@ static void bnge_disable_int_sync(struct bnge_net *bn) struct bnge_dev *bd = bn->bd; int i; + atomic_inc(&bn->intr_sem); bnge_disable_int(bn); for (i = 0; i < bd->nq_nr_rings; i++) { int map_idx = bnge_cp_num_to_irq_num(bn, i); @@ -2124,6 +2152,7 @@ static void bnge_enable_int(struct bnge_net *bn) struct bnge_dev *bd = bn->bd; int i; + atomic_set(&bn->intr_sem, 0); for (i = 0; i < bd->nq_nr_rings; i++) { struct bnge_napi *bnapi = bn->bnapi[i]; struct bnge_nq_ring_info *nqr = &bnapi->nq_ring; @@ -2677,6 +2706,7 @@ static int bnge_open_core(struct bnge_net *bn) bnge_enable_int(bn); bnge_tx_enable(bn); + mod_timer(&bd->timer, jiffies + bd->current_interval); /* Poll link status and check for SFP+ module status */ mutex_lock(&bd->link_lock); bnge_get_port_module_status(bn); @@ -2718,6 +2748,7 @@ static void bnge_close_core(struct bnge_net *bn) clear_bit(BNGE_STATE_OPEN, &bd->state); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + timer_delete_sync(&bd->timer); bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h index 1b66e44c3b9..ad1cfd4e6f0 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -350,6 +350,8 @@ struct bnge_net { struct bnge_ethtool_link_info eth_link_info; + atomic_t intr_sem; + unsigned long state; #define BNGE_STATE_NAPI_DISABLED 0 @@ -894,4 +896,6 @@ int bnge_alloc_rx_netmem(struct bnge_net *bn, struct bnge_rx_ring_info *rxr, void bnge_get_ring_err_stats(struct bnge_net *bn, struct bnge_total_ring_err_stats *stats); void bnge_copy_hw_masks(u64 *mask_arr, __le64 *hw_mask_arr, int count); +void bnge_timer(struct timer_list *t); +void bnge_sp_task(struct work_struct *work); #endif /* _BNGE_NETDEV_H_ */ -- 2.47.3