From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A61C334D4E5 for ; Fri, 14 Nov 2025 19:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763150085; cv=none; b=Ue4vscegZ5Kc/W8dx33GD9c0GLRzdJPNbnGjinPCCc6g5VXKhUrAyz0wzFdL8C7zc4ixmVPJnzh1bcPu5GJglgCJAHn771OtlOFzoMXE+frLZGooxIKLmbkVmOp1sQ+BCG38XwEOCGiboXw6LzNER+n/h7Q/O7pjtO4OjYOf65U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763150085; c=relaxed/simple; bh=SMmxb//ePUD3hFrfAsPMLLG0BwdXmv2Mg0jkVsYrPVE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TZ05HOFcnZOIw28WwDIZBXcid9F0WCw1+6KCEFh9YdCN3KHuX1tfJTxzg/62XOB52GZvBT4t/huGpw3DoK798u++E2BVc9UEwdbbQuraxyJ3vUdw97NIdp+2UdAwGf1zrgkVg8HyqjhHVhMsisjLqTEZu3J1NBEXKUMCaIz/JQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=T3QOT7TA; arc=none smtp.client-ip=209.85.214.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="T3QOT7TA" Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-29844c68068so22021725ad.2 for ; Fri, 14 Nov 2025 11:54:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763150083; x=1763754883; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EJeHjbo0rkg1+MXurwHM1VKiMZc+qaqYqidGa0aqX60=; b=xRttVhJIfYG8EJGyS5B5Z1Q9MAzR6gUF0bDxqfgRiOuNbdKpcyGbW3wRMObCwKvJxx wleUPY/xQkrkxubOw5JTNClWoUbAu/30HnvwyQrgdWkldz3Y4hevieliSw9zfLNRWxXu T8fRL00pv1wwnZlrQw4jFRwxEeMMTYhYdvmNwKMVJ8Oen6UrZ8/4JvLrmxPtXuDc1Amm gnjzNeBhvmo5/8ZcdHXi2I62fU88rKrhGyVgSNUxc5UN+67urvcYbZ5kQfQx4vLm/9cZ R5chHN3rAZ227IXsBMVWNPzmwSd5ss8RtTsexXmMEChPD3VMGqFVuDHjZx43dMAxqbnX LewA== X-Forwarded-Encrypted: i=1; AJvYcCUpPtYD933LOcjdG5FW8YoQKj37zgoXdm9OUq8ybvkeCguGn2e3pf7zdOCL066XqFU2EGoRaezqBfnac/Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yxnk9Bv8CtOJMmyQ7/k8XpqtCVT/EdloRzMGv+2EAjL0DrvFHu/ d3pI4gWQ4pabjR1MTt/l6ThmJYEvpBofVnbIA0tPBTNtkB9XNCtHGV1M7GOaQE0wOU7xzoRhn45 pPiOf8lOAczMWl7PW3Vxj4p2/0LLjwYOdUEgSJph2gXJpYyFATsxyNViy4DU4MLPJdKkybV10Lh CuW/9PtdWWHbj2WdGhY7AcYP2dJjDQ05g7SGvqb2Ei1FjXO082oXiNw2PqX1sjwk5T8XPoJ2j+P zc7gCN3Ab/t9jVMFOob2Q8yuA== X-Gm-Gg: ASbGncvt8oiSzH7BpiYeE0WJJWJSsc6/Z3wUWek2eee9iVMRbXg9Gg4X8r2Sk8ozf8I 8QqrmvDsdajtSRvqQDQPr3EL3mgEzVDc9rIgEM5ExOw2t4v1059dBBj7F/JTpHIwpwVYJyjaDcg bA/PinPndEvn05ZT1kS8mJ894jCg2BKIuA9fStfN5v12WpjhhS+j5CFeFS5YoDnZEnrwBDrXVMg EELk+Z5RwiFOOmLK8D/88mNHvEOM0/7MTo9PqVlpM9m50m23Vh/q/PK4OfZXWZcAcCj6/FFzMNb MMzP9/wUOzgJ08rVLozWHsG0hpUpS1INHV9o33IAL1wtDB1HcbGuUvk1XStpBUwXf0sFW3PBXP/ BJLSFVQTkRfZYJe8WDoqGLIo8ifC1vR6F+1u5PHa4T4LpJydyeyJSztBVBZrCvmJPySbBnAkTL0 0BtCAcTdGMHUjv/XN+ppT7dEqMt+wgZt1ry183AAcrNjU= X-Google-Smtp-Source: AGHT+IH5uHo1DO0mB3zcQlOpY/wh2xzFLILXzHWJeJJgNGr6NUz1V4Pndb/sUmWGMepFTcSyccXu+V8wQQPI X-Received: by 2002:a17:902:da4f:b0:295:6d30:e26f with SMTP id d9443c01a7336-2986a6ec220mr46832915ad.22.1763150083098; Fri, 14 Nov 2025 11:54:43 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-118.dlp.protect.broadcom.com. [144.49.247.118]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2985c23458csm6479135ad.4.2025.11.14.11.54.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Nov 2025 11:54:43 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29809acd049so32498085ad.3 for ; Fri, 14 Nov 2025 11:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1763150081; x=1763754881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EJeHjbo0rkg1+MXurwHM1VKiMZc+qaqYqidGa0aqX60=; b=T3QOT7TA4iDP3fyAvLX6GMtLWt3qwzM89whTDtF5FcoLUjed62xixIIhW8d7cph8e9 9+FbpO5k+xLehC2JW4MB7fqfycoGnc64mmBnr66a7fpG0nI51P5xgUpSJ9rkWZPZse1z ZCjzsEwArI50iLgwa4LmSe3zgGBoaRHIMmtlE= X-Forwarded-Encrypted: i=1; AJvYcCVrI8oMnBVLxaWnKb4DN7JFhk1UBdN9qIY4UzJBdTBykf+U9yygGxT32qRrS0Gc250mpRkfH6fQbw8mXe4=@vger.kernel.org X-Received: by 2002:a17:903:18c:b0:297:df8f:b056 with SMTP id d9443c01a7336-2986a6ba482mr61214825ad.11.1763150081371; Fri, 14 Nov 2025 11:54:41 -0800 (PST) X-Received: by 2002:a17:903:18c:b0:297:df8f:b056 with SMTP id d9443c01a7336-2986a6ba482mr61214535ad.11.1763150080968; Fri, 14 Nov 2025 11:54:40 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-343ea5f9fa4sm3108113a91.0.2025.11.14.11.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 11:54:40 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v2, net-next 12/12] bng_en: Query firmware for statistics and accumulate Date: Sat, 15 Nov 2025 01:23:00 +0530 Message-ID: <20251114195312.22863-13-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251114195312.22863-1-bhargava.marreddy@broadcom.com> References: <20251114195312.22863-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Use the per-PF workqueue and timer infrastructure to asynchronously fetch statistics from firmware and accumulate them in the PF context. With this patch, ethtool -S exposes all hardware stats. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 95 +++++++++++++++++++ 1 file changed, 95 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c index 872c8b6a9be..dbca011db33 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -253,6 +253,17 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } +static void __bnge_queue_sp_work(struct bnge_dev *bd) +{ + queue_work(bd->bnge_pf_wq, &bd->sp_task); +} + +static void bnge_queue_sp_work(struct bnge_dev *bd, unsigned int event) +{ + set_bit(event, &bd->sp_event); + __bnge_queue_sp_work(bd); +} + void bnge_timer(struct timer_list *t) { struct bnge_dev *bd = timer_container_of(bd, t, timer); @@ -265,16 +276,100 @@ void bnge_timer(struct timer_list *t) if (atomic_read(&bn->intr_sem) != 0) goto bnge_restart_timer; + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bd, BNGE_PERIODIC_STATS_SP_EVENT); + bnge_restart_timer: mod_timer(&bd->timer, jiffies + bd->current_interval); } +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp; + + hw &= mask; + sw_tmp = (*sw & ~mask) | hw; + if (hw < (*sw & mask)) + sw_tmp += mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *masks, + int count) +{ + int i; + + for (i = 0; i < count; i++) { + u64 hw = le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] == -1ULL) + sw_stats[i] = hw; + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn = netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats; + int i; + + for (i = 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi = bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr = &bnapi->nq_ring; + stats = &nqr->stats; + if (!i) + ring0_stats = stats; + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8); + } + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats = &bn->port_stats; + __le64 *hw_stats = stats->hw_stats; + u64 *sw_stats = stats->sw_stats; + u64 *masks = stats->hw_masks; + int cnt; + + cnt = sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + + hw_stats += BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats += BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks += BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt = sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + } + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + void bnge_sp_task(struct work_struct *work) { struct bnge_dev *bd = container_of(work, struct bnge_dev, sp_task); set_bit(BNGE_STATE_IN_SP_TASK, &bd->state); smp_mb__after_atomic(); + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bd->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } smp_mb__before_atomic(); clear_bit(BNGE_STATE_IN_SP_TASK, &bd->state); -- 2.47.3