From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f99.google.com (mail-oa1-f99.google.com [209.85.160.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BA73340D9E for ; Fri, 14 Nov 2025 19:53:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763150039; cv=none; b=MFhX9jBxaZ4+/LyJk98C0gUobZF+tbje66HMgPuiy8Grdu9BZMzMW6CW3iqd4wq7/DxOmLqYbCPPVkIoWz5qB3H/aq97Pxc1HasuM/0lsAuAyyo0+YCF5Fuw1DNcz24NBdn9XmLKAZF+6+NzoIE5UtZ+mSBZfLFCt1L4EmrsvQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763150039; c=relaxed/simple; bh=mrDZkwdQ14Mwae8MarBh0NSIneeIVWIw2Dx2Nr6IlDU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L+Zt/ephmJiBy3U4AcjaNCJda4TPxKziTnXEbe7dt8xCehYLk4nMCGj5QSuLB0CRzDaSmeNVTsuIIinVlSKHjokMAdifVbHpMsHAcj2K25SZcGXR6lpfZUCww8H/bKY9gZgJJD+NaCgeb9Yj4HZe57mF3K2gNFA8lvrAb8LSXNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=WebSyHjv; arc=none smtp.client-ip=209.85.160.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="WebSyHjv" Received: by mail-oa1-f99.google.com with SMTP id 586e51a60fabf-3e7f68df436so1196642fac.1 for ; Fri, 14 Nov 2025 11:53:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763150037; x=1763754837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JyRmhC40tORy7magFBDMbFacme5UfcMblEolAfcxZG8=; b=c9vRKZFp4VYn8287Q/aYJJ2GrOye5dHA8QDYKnHUhs8DqAY1v2GorvUF37jZWu3ATE LErvxzq6umIuIvu31+ubQH0JJ3pNKegXyjLrA2vFozlOhxeLabkV5Q2fuoCO8KXJNsx9 rqjlukZ83baFZKFLWaP9Bva+1t2ZwvHQY7pjFGUJDXUGGAnubvdDfrIz6fOGXCHaUGbZ h8viyOh6NbW9g50xv9ksQLPOb4b9AP4YLYkfQhe03dipxLiCGePUItmz7zTBpWVG0MBW Lxw30IVt0rqUoXTBPohH5Euup1Vfc6shxh7tY3yRh8BOcbqiH0K2tXbnU7C9cy0D4H4Q VS/A== X-Forwarded-Encrypted: i=1; AJvYcCUu4K+DWLoHSO3KtDsQzOBNEOSfaKsySeK6196iLowYLXpDUYzx8rwre1YHAbJqLlijbrdPjagEZ1QUs0Q=@vger.kernel.org X-Gm-Message-State: AOJu0YycYVIsGIFgeYOu3RtmXnfUPGETOrXd8B6HONSqnPqSi33BZkNA xjU4Q0i4LP1s3KveZdy1SAhNwslw+lY8V7HId6WTMdkatAGig3QBnICNxKRAmgnLRDt24GJyQU2 ymxnCEishYpVU3v8rsVtrJ3HEcXFuynIjsWLydXFXBJtdXL/Be9I8dvXCS6vGJwJA+uE6IKwC6E w9sD10UFJA4rz7yBX5ej0FmiqMLctRePB5fWJqApQ16rtJOiff9U9x9jNbh5B9mbVPL0ndWM/6j vS8alW0qJYegn6AKKi6a25HmQ== X-Gm-Gg: ASbGncvsk2s/yqsDUNxNuk70imHCblU97xvVpJmSGnOYSa9hsi6FWKC0zBNbas6Eu9G wArqlhxP8SqJXe6ss/YG30UrkXDq7sJOU1Q4wfM3smkCOEWx5zlxWGpmG4eepTMRHbXYb0u6/aL 2aRikh7zWqBhwQBzdnFZ2a/Ie+xhc2+T/CfDRFQwvBemvmAzWb2+Q2Dk45kwyPd34vkTvLw3eMh /L7jSjdaYTkA0VgKReydfkU/45NAK8D8RFq09DX5uYMkDVdNsGffhJAyRTGeovnYQ3N0LmeB6wP u+V46cqNjKSh0Zm8SnD4SGoGuTiyFtJ719vmr6qvOEFagf8j7TqBtfG0DiaNnu4tH3x+Clq5rYa DfalGVEs5C5oAZsj++5A7ltvuQuSWgUgwM9LHT1yfmBTodgkVE42GOzNGG8g07zUY8yuDS6QpF+ qqplFKRk9Bnmu+d6ghxP8XiOd/6HY6hyxSwyTgpQETcUM= X-Google-Smtp-Source: AGHT+IGkzbQ0Gf8w7sIDpOF4YGBl603/nsBlKRLM9k8JuBkgUdNOqHUycQvJk5ao59Y+2bBFEbJCl/fnsByh X-Received: by 2002:a05:6870:9120:b0:3c9:a286:fb1c with SMTP id 586e51a60fabf-3e84c6ccc19mr4657258fac.24.1763150037155; Fri, 14 Nov 2025 11:53:57 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-101.dlp.protect.broadcom.com. [144.49.247.101]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-3e8522c77f1sm536937fac.19.2025.11.14.11.53.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Nov 2025 11:53:57 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-341cd35b0f3so4027467a91.0 for ; Fri, 14 Nov 2025 11:53:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1763150034; x=1763754834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JyRmhC40tORy7magFBDMbFacme5UfcMblEolAfcxZG8=; b=WebSyHjvrajZ2pr8oBjb6xRUovLQik+haZiuTy5lNIuA0yVe5S9aliZQY91DJazmsh jZo/Si3LiYvx2ucwSTumbh1Umery+3WlPSmVCzKV+AFlMyurSQpv9nLVKVlynXA+ZaCu Ux6DjYc+RLTuRkYQirEELh+brtDQDVDH8C5jc= X-Forwarded-Encrypted: i=1; AJvYcCUIrly4PFHbDfrVrQZRHB3t51fRW+FUvix/YpFevjcOUKbFAJk6gLczM+a8Q7ZD1IArqB0dka4b1awcJb8=@vger.kernel.org X-Received: by 2002:a17:90b:5905:b0:343:7410:5b66 with SMTP id 98e67ed59e1d1-343eac9cd2cmr9440015a91.11.1763150034358; Fri, 14 Nov 2025 11:53:54 -0800 (PST) X-Received: by 2002:a17:90b:5905:b0:343:7410:5b66 with SMTP id 98e67ed59e1d1-343eac9cd2cmr9439992a91.11.1763150033907; Fri, 14 Nov 2025 11:53:53 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-343ea5f9fa4sm3108113a91.0.2025.11.14.11.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 11:53:53 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v2, net-next 02/12] bng_en: Extend bnge_set_ring_params() for rx-copybreak Date: Sat, 15 Nov 2025 01:22:50 +0530 Message-ID: <20251114195312.22863-3-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251114195312.22863-1-bhargava.marreddy@broadcom.com> References: <20251114195312.22863-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Add rx-copybreak support in bnge_set_ring_params() Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 19 +++++++++++++++++-- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 5 +++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c index 4172278900b..8785bf57d82 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include @@ -2313,7 +2314,6 @@ void bnge_set_ring_params(struct bnge_dev *bd) rx_space = rx_size + ALIGN(NET_SKB_PAD, 8) + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); - bn->rx_copy_thresh = BNGE_RX_COPY_THRESH; ring_size = bn->rx_ring_size; bn->rx_agg_ring_size = 0; bn->rx_agg_nr_pages = 0; @@ -2352,7 +2352,10 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->rx_agg_ring_size = agg_ring_size; bn->rx_agg_ring_mask = (bn->rx_agg_nr_pages * RX_DESC_CNT) - 1; - rx_size = SKB_DATA_ALIGN(BNGE_RX_COPY_THRESH + NET_IP_ALIGN); + rx_size = max3(BNGE_DEFAULT_RX_COPYBREAK, + bn->rx_copybreak, + bn->netdev->cfg_pending->hds_thresh); + rx_size = SKB_DATA_ALIGN(rx_size + NET_IP_ALIGN); rx_space = rx_size + NET_SKB_PAD + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); } @@ -2385,6 +2388,17 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->cp_ring_mask = bn->cp_bit - 1; } +static void bnge_init_ring_params(struct bnge_net *bn) +{ + unsigned int rx_size; + + bn->rx_copybreak = BNGE_DEFAULT_RX_COPYBREAK; + /* Try to fit 4 chunks into a 4k page */ + rx_size = SZ_1K - + NET_SKB_PAD - SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); + bn->netdev->cfg->hds_thresh = max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2474,6 +2488,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) bn->rx_dir = DMA_FROM_DEVICE; bnge_set_tpa_flags(bd); + bnge_init_ring_params(bn); bnge_set_ring_params(bd); bnge_init_l2_fltr_tbl(bn); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h index 85c4f6f5371..b267f0b14c1 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -136,7 +136,8 @@ struct bnge_ring_grp_info { u16 nq_fw_ring_id; }; -#define BNGE_RX_COPY_THRESH 256 +#define BNGE_DEFAULT_RX_COPYBREAK 256 +#define BNGE_MAX_RX_COPYBREAK 1024 #define BNGE_HW_FEATURE_VLAN_ALL_RX \ (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_STAG_RX) @@ -187,7 +188,7 @@ struct bnge_net { u32 rx_buf_size; u32 rx_buf_use_size; /* usable size */ u32 rx_agg_ring_size; - u32 rx_copy_thresh; + u32 rx_copybreak; u32 rx_ring_mask; u32 rx_agg_ring_mask; u16 rx_nr_pages; -- 2.47.3