From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f98.google.com (mail-qv1-f98.google.com [209.85.219.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5561A347BCB for ; Fri, 14 Nov 2025 19:54:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763150050; cv=none; b=mANMHcMEUySX23ZrTBDrYwILphzXxHBMKL75C8gewc0wbAjQYwtPu0rjbV4v1ga+KWI8nn9z1MniINwrQ5X6cEBG2ThlgMQfltk4VkPwbKCLRx2Dw0HTd7F/FJF9vqRWgF0QsEVGQt8E5vOJFmiaFgLlabg1Eyz2i9flmBrFOdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763150050; c=relaxed/simple; bh=OwvR/dPLZK37K1BmREFFi1Wrd2L+JHV93zFie6DXuO0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YM+hn0J6y/qpGXLhjcyBLcsKO2R6Fi4dmpIlC+XmDJGDm5G3q7HzNDMTBFBgZSNslNC8drFT5YnhSnDAyIA1vrUHb8svXUFbgYL3hX+XZ9eyAkwYlugUFGC+1f+5oj2kmD8av26R71kZKJ+UcFTFOOlzaRVSKOKrInvV6oY7elk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=dn6dKda8; arc=none smtp.client-ip=209.85.219.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="dn6dKda8" Received: by mail-qv1-f98.google.com with SMTP id 6a1803df08f44-87c13813464so32087416d6.1 for ; Fri, 14 Nov 2025 11:54:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763150045; x=1763754845; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=arzdhcB0zbOBVOiM/6hbOwxYhTE0CSizIk0DE7KRy3g=; b=Q3zzBVQHo3cB14AbiGR3oMQ5X342aCDOv3cW10dm9MZAmlvzRciTG23eCqoKuC1xTo Sg2taQm2hJX6w3d3JCglcHC97weFsFnbafhW9XFzbil1mj/NNTeqWu8DYnFiI/B6nKVY zyJBU3//Pj65p0QlwhYsNntWOkaTMvi60XGCIq6IfdyaRq8cXOvcEBgUfr8A8CUMK5lm aM4cOvcJrxkizsi0BZAnoBK32roqz1lH0y8ac15VyP3lCFc6CPkyX/Xc0IGowUsaUSm6 ElS1JnsHUFbJtWDEDuzpU4WmuWo2vCR1YSIxUTSCEVt3r3Sh3QYWQZj1qwtF5HK5Vdc9 odBw== X-Forwarded-Encrypted: i=1; AJvYcCVEvuX+HRwuCD7O/OmFgKU4e53a6Q3c9qg9wGP1oJcbc92P4nVeOUyFOPE9hbj/e/tXOtexlyT3mEE3xuo=@vger.kernel.org X-Gm-Message-State: AOJu0YxEvcFr5ZqWmjL5uNOeJiAK0XJTjjhwNlTA7kRnB18N8Z/7v37E 45RU986PvsFv03yWDsY7lbda2JgOwL6a46hDYGLwc8C6qiJf5pqE17c0urlGCjMHyXITmnS9Sm/ z8HfwIW/b2qd1CkhFl50p5/FJLUd/zfS3D2LHfq1laF36ZknUTt77WuERPxg2AIMK0PU1PosAsY PvhiaoosSe6gDSUq7MIp5o218ApgPaqVLvVYhG2D/6ooS0mwbZQ1rKZD0sRj5S/7YOcl3vBSQB/ Ko6ZyDolfgT1B3brtdXNx6PgA== X-Gm-Gg: ASbGncuUHVPCoizYO+9Ze1LAVexh0KwRtCscAQTv6YfOrCF8V1WJ8Z3kkMWrjyX4HdJ KR69UTzGmDR8Swkoek8bP8B/Hw777Wk+URUDwmtlJdYsZ8RqLbXbiSu6/63D4LWecCMIAEQhU+F d2uFevZyMUSvlzwCaHrA3Py/YGPusoPKL6SOTWQz8nzzlYlkN7nVbNkkGhR5WKJSOUEXAaFF9xJ qIDSl3APnc9RpSmF+3GnOH/JyWn70fId+YXNJ58otiFB31U3aWhMjGQBagBBuIrAmMkJjMN0zPQ jzYri3nB1biqkUgollTI58h5OkuKddTWaQA85dNvGIZPgiivMuBVuWuZo+WVoca13AtBuj7IvLY s2/duFhJecWt3EAA1eCzgj60fVA6u/+6X+Zcl5OPnQRIF9SlsMqm0gfEC4AUGcp9LqRbPYkJEyZ V0D7kw2PpLYeK6RurGKgkFUbrZ679sCc61Q6n9BirFbrY= X-Google-Smtp-Source: AGHT+IEDP8Npr2IVSVBB1L35ooTessuGRVD7bs2N2VG+c1rhjMN9i27lGUD14ZYgcweE/L4q/ByAHhYrG/IS X-Received: by 2002:ad4:576c:0:b0:87d:cb8d:2a98 with SMTP id 6a1803df08f44-8829258f9a4mr65582746d6.2.1763150045119; Fri, 14 Nov 2025 11:54:05 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-101.dlp.protect.broadcom.com. [144.49.247.101]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-882862b3755sm6516536d6.3.2025.11.14.11.54.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Nov 2025 11:54:05 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-340c07119bfso6145513a91.2 for ; Fri, 14 Nov 2025 11:54:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1763150044; x=1763754844; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=arzdhcB0zbOBVOiM/6hbOwxYhTE0CSizIk0DE7KRy3g=; b=dn6dKda8qUBhn3yYaKfUW1nAJDwYd9BlbAMbZr2t1g/GXdsroMEUNKA78ZVURwkf0C x7P9wtw9dOB1rSGkqFwiqt+sA6Lnn2Tj4aAvB7yB+71GowvVt+utQyUvkaUZTcdDDb6w YZN3NwreqCSaRTqsI9/MSYt3ct6A8GaeuArU4= X-Forwarded-Encrypted: i=1; AJvYcCXrGJqhjmrcP6yW7xOfCTD/mKHpM0df/rHqGg7fqaNeWUA4LQKLvmR3HOpGiY3d+pR+FuW5juSeXElP+s8=@vger.kernel.org X-Received: by 2002:a17:90b:35d0:b0:340:48f2:5e2d with SMTP id 98e67ed59e1d1-343f9eb5052mr4740705a91.9.1763150043614; Fri, 14 Nov 2025 11:54:03 -0800 (PST) X-Received: by 2002:a17:90b:35d0:b0:340:48f2:5e2d with SMTP id 98e67ed59e1d1-343f9eb5052mr4740689a91.9.1763150043231; Fri, 14 Nov 2025 11:54:03 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-343ea5f9fa4sm3108113a91.0.2025.11.14.11.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 11:54:02 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v2, net-next 04/12] bng_en: Handle an HWRM completion request Date: Sat, 15 Nov 2025 01:22:52 +0530 Message-ID: <20251114195312.22863-5-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251114195312.22863-1-bhargava.marreddy@broadcom.com> References: <20251114195312.22863-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Since the HWRM completion for a sent request lands on the NQ, add functions to handle the HWRM completion event. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 4 +- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + .../net/ethernet/broadcom/bnge/bnge_txrx.c | 44 ++++++++++++++++++- 3 files changed, 46 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c index d7149f098a5..a8ebf889330 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -18,6 +18,7 @@ #include #include "bnge.h" +#include "bnge_hwrm.h" #include "bnge_hwrm_lib.h" #include "bnge_ethtool.h" #include "bnge_rmem.h" @@ -2315,8 +2316,7 @@ static int bnge_open(struct net_device *dev) static int bnge_shutdown_nic(struct bnge_net *bn) { - /* TODO: close_path = 0 until we make NAPI functional */ - bnge_hwrm_resource_free(bn, 0); + bnge_hwrm_resource_free(bn, 1); return 0; } diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h index d13c0c52553..8a38b022f7a 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -78,6 +78,7 @@ struct tx_cmp { #define CMPL_BASE_TYPE_HWRM_FWD_REQ 0x22UL #define CMPL_BASE_TYPE_HWRM_FWD_RESP 0x24UL #define CMPL_BASE_TYPE_HWRM_ASYNC_EVENT 0x2eUL + #define CMPL_BA_TY_HWRM_ASY_EVT CMPL_BASE_TYPE_HWRM_ASYNC_EVENT #define TX_CMP_FLAGS_ERROR (1 << 6) #define TX_CMP_FLAGS_PUSH (1 << 7) u32 tx_cmp_opaque; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c index 41463d3825b..68ff9a8e277 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -392,6 +392,43 @@ static void __bnge_poll_work_done(struct bnge_net *bn, struct bnge_napi *bnapi, } } +static void +bnge_hwrm_update_token(struct bnge_dev *bd, u16 seq_id, + enum bnge_hwrm_wait_state state) +{ + struct bnge_hwrm_wait_token *token; + + rcu_read_lock(); + hlist_for_each_entry_rcu(token, &bd->hwrm_pending_list, node) { + if (token->seq_id == seq_id) { + WRITE_ONCE(token->state, state); + rcu_read_unlock(); + return; + } + } + rcu_read_unlock(); + dev_err(bd->dev, "Invalid hwrm seq id %d\n", seq_id); +} + +static int bnge_hwrm_handler(struct bnge_dev *bd, struct tx_cmp *txcmp) +{ + struct hwrm_cmpl *h_cmpl = (struct hwrm_cmpl *)txcmp; + u16 cmpl_type = TX_CMP_TYPE(txcmp), seq_id; + + switch (cmpl_type) { + case CMPL_BASE_TYPE_HWRM_DONE: + seq_id = le16_to_cpu(h_cmpl->sequence_id); + bnge_hwrm_update_token(bd, seq_id, BNGE_HWRM_COMPLETE); + break; + + case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT: + default: + break; + } + + return 0; +} + static int __bnge_poll_work(struct bnge_net *bn, struct bnge_cp_ring_info *cpr, int budget) { @@ -442,8 +479,11 @@ static int __bnge_poll_work(struct bnge_net *bn, struct bnge_cp_ring_info *cpr, rx_pkts++; else if (rc == -EBUSY) /* partial completion */ break; + } else if (unlikely(cmp_type == CMPL_BASE_TYPE_HWRM_DONE || + cmp_type == CMPL_BASE_TYPE_HWRM_FWD_REQ || + cmp_type == CMPL_BA_TY_HWRM_ASY_EVT)) { + bnge_hwrm_handler(bn->bd, txcmp); } - raw_cons = NEXT_RAW_CMP(raw_cons); if (rx_pkts && rx_pkts == budget) { @@ -560,6 +600,8 @@ int bnge_napi_poll(struct napi_struct *napi, int budget) work_done += __bnge_poll_work(bn, cpr, budget - work_done); nqr->has_more_work |= cpr->has_more_work; + } else { + bnge_hwrm_handler(bn->bd, (struct tx_cmp *)nqcmp); } raw_cons = NEXT_RAW_CMP(raw_cons); } -- 2.47.3