From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 438042E1C4E for ; Fri, 14 Nov 2025 20:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763150712; cv=none; b=G1GSTFKLuWTtjUO4Ddq2j8irEXzdShKlUIdkzQolcq8+Tatrtid4WVFXY1PCWTiV38ARUjZGuXb67zIMQ5AO2MwOEJKSMdGJCCOmpg4wM//WHVj5efcQxlKi+j5Av4xT3BSLZFz9nM82zj+bvEaxjWs9onnGOd731MuHWKLU+XE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763150712; c=relaxed/simple; bh=+bFl4vLYEQ5YEtUjUTLngcy1U+h99DwXY7ZQztgNe+E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KiM4Xm+BjLFR9G2DMs0J8K0mfVxw9yeAACyNdDufxV6QR07iA967wKq16wRJPhD/1fk5Ovd0bSbTaWDMTljiiccy1P+AFRxQg9VKZTyETlk0tFf9F2VumeSHhKzpjjQ2XldQp/RnknQND1XkRdqHw/bg6HkGjEzTwuECnDbnPHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XhQNRTQE; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XhQNRTQE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763150709; x=1794686709; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+bFl4vLYEQ5YEtUjUTLngcy1U+h99DwXY7ZQztgNe+E=; b=XhQNRTQElTcwzfDEnXmup1Su7jv06nUXQTZQxiRHBqt/p3YsvCaYULTv ewYG9Nf0kbbL8SFrecnRzHMF4hPqg/lwWe08wy1+HCvL+jBXt8W9IMMYK +q0ZZEw+QvCW0pxXrJAn+EX2B0ybKhMMz13Ysj1aA3u/WcnaocW66/dXf +BCMMiWVhmBmtGacP3QV0gwllA1mf/z89GVm7rEyyIIBMRmjPfJcLlLGz YXoX40tBI7FToE0qEeWT6Z65Fq5JLyDZp5MFAYdIMdg20p9ia6jz568ba VUK/2L8wwvA6zlUcIvzd2Hw1vz7P5oh4CveKHMGZJQdDW+KIb90sbMUW/ g==; X-CSE-ConnectionGUID: zQ9HetKnRt+wT5qbfdCLdQ== X-CSE-MsgGUID: vemcWjJaStOKkWU3WPlKuQ== X-IronPort-AV: E=McAfee;i="6800,10657,11613"; a="76716352" X-IronPort-AV: E=Sophos;i="6.19,305,1754982000"; d="scan'208";a="76716352" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2025 12:05:07 -0800 X-CSE-ConnectionGUID: HxHLaQmlR5+TWZt+kL4PTA== X-CSE-MsgGUID: khFULcGgS36gh9+sU6Invw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,305,1754982000"; d="scan'208";a="194848493" Received: from guptapa-desk.jf.intel.com (HELO desk) ([10.165.239.46]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2025 12:05:07 -0800 Date: Fri, 14 Nov 2025 12:04:59 -0800 From: Pawan Gupta To: Borislav Petkov Cc: Josh Poimboeuf , "Kaplan, David" , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , Alexander Graf , Boris Ostrovsky , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86/bugs: Get rid of the forward declarations Message-ID: <20251114200459.sjh2n6iapyhhmcbx@desk> References: <20251013143444.3999-1-david.kaplan@amd.com> <20251013143444.3999-6-david.kaplan@amd.com> <20251103193130.GQaQkDEquEnEwb_cwC@fat_crate.local> <20251103202811.GMaQkQW54Gml6i1jQy@fat_crate.local> <20251105110318.GAaQsu9vGkzSxGbzzx@fat_crate.local> <20251105200447.GBaQut3w4dLilZrX-z@fat_crate.local> <20251114171414.GEaRdjZsEG9NAA_rLF@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251114171414.GEaRdjZsEG9NAA_rLF@fat_crate.local> On Fri, Nov 14, 2025 at 06:14:14PM +0100, Borislav Petkov wrote: > On Wed, Nov 05, 2025 at 09:04:47PM +0100, Borislav Petkov wrote: > > > We should put cpu_select_mitigations() at the bottom too, then all those > > > existing forward declarations can go away. > > > > That's a good idea. We should, if it doesn't get too hairy. > > That was easier than I expected. Only build-tested. > > --- > From: "Borislav Petkov (AMD)" > Date: Fri, 14 Nov 2025 18:10:04 +0100 > > Get rid of the forward declarations of the mitigation functions by > moving their single caller below them. > > No functional changes. > > Suggested-by: Josh Poimboeuf > Signed-off-by: Borislav Petkov (AMD) Indeed a nice cleanup. Reviewed-by: Pawan Gupta