From: Luigi Rizzo <lrizzo@google.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Luigi Rizzo <rizzo.unipi@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Sean Christopherson <seanjc@google.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Willem de Bruijn <willemb@google.com>,
Luigi Rizzo <lrizzo@google.com>
Subject: [PATCH v2 6/8] genirq: soft_moderation: helpers for per-driver defaults
Date: Sun, 16 Nov 2025 18:28:37 +0000 [thread overview]
Message-ID: <20251116182839.939139-7-lrizzo@google.com> (raw)
In-Reply-To: <20251116182839.939139-1-lrizzo@google.com>
Introduce helpers to implement per-driver module parameters to enable
moderation at boot/probe time.
No functional change.
Change-Id: I305aa42fa348055004cc2221ef6b055a0ab4b9d5
Signed-off-by: Luigi Rizzo <lrizzo@google.com>
---
include/linux/interrupt.h | 19 +++++++++++++++++++
kernel/irq/irq_moderation.c | 14 ++++++++++++++
2 files changed, 33 insertions(+)
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 51b6484c04934..17ce0aac181de 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -872,6 +872,25 @@ extern int early_irq_init(void);
extern int arch_probe_nr_irqs(void);
extern int arch_early_irq_init(void);
+#ifdef CONFIG_IRQ_SOFT_MODERATION
+
+/* helpers for per-driver moderation mode settings */
+#define DEFINE_IRQ_MODERATION_MODE_PARAMETER \
+ static bool soft_moderation; \
+ module_param(soft_moderation, bool, 0644); \
+ MODULE_PARM_DESC(soft_moderation, "0: off, 1: on")
+
+void irq_moderation_set_mode(int irq, bool enable);
+#define IRQ_MODERATION_SET_DEFAULT_MODE(_irq) \
+ irq_moderation_set_mode(_irq, READ_ONCE(soft_moderation))
+
+#else /* empty stubs to avoid conditional compilation */
+
+#define DEFINE_IRQ_MODERATION_MODE_PARAMETER
+#define IRQ_MODERATION_SET_DEFAULT_MODE(_irq)
+
+#endif
+
/*
* We want to know which function is an entrypoint of a hardirq or a softirq.
*/
diff --git a/kernel/irq/irq_moderation.c b/kernel/irq/irq_moderation.c
index 2d01e4cd4638b..c2542c92fbbd5 100644
--- a/kernel/irq/irq_moderation.c
+++ b/kernel/irq/irq_moderation.c
@@ -84,6 +84,10 @@ static inline bool posted_msi_supported(void) { return false; }
*
* echo "on" > /proc/irq/NN/soft_moderation # use "off" to disable
*
+ * For selected drivers, the default can also be supplied via module parameters
+ *
+ * ${DRIVER}.soft_moderation=1
+ *
* === MONITORING ===
*
* cat /proc/irq/soft_moderation shows per-CPU and global statistics.
@@ -307,6 +311,16 @@ static inline int set_moderation_mode(struct irq_desc *desc, bool enable)
return 0;
}
+/* irq_to_desc() is not exported. Wrap it for use in drivers. */
+void irq_moderation_set_mode(int irq, bool enable)
+{
+ struct irq_desc *desc = irq_to_desc(irq);
+
+ if (desc)
+ set_moderation_mode(desc, enable);
+}
+EXPORT_SYMBOL(irq_moderation_set_mode);
+
#pragma clang diagnostic error "-Wformat"
/* Print statistics */
static int moderation_show(struct seq_file *p, void *v)
--
2.52.0.rc1.455.g30608eb744-goog
next prev parent reply other threads:[~2025-11-16 18:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 18:28 [PATCH v2 0/8] platform wide software interrupt moderation Luigi Rizzo
2025-11-16 18:28 ` [PATCH v2 1/8] genirq: platform wide interrupt moderation: Documentation, Kconfig, irq_desc Luigi Rizzo
2025-11-16 18:28 ` [PATCH v2 2/8] genirq: soft_moderation: add base files, procfs Luigi Rizzo
2025-11-17 11:12 ` kernel test robot
2025-11-17 16:01 ` Thomas Gleixner
2025-11-17 16:16 ` Luigi Rizzo
2025-11-17 19:35 ` Thomas Gleixner
2025-11-17 21:56 ` kernel test robot
2025-11-16 18:28 ` [PATCH v2 3/8] genirq: soft_moderation: implement fixed moderation Luigi Rizzo
2025-11-17 19:30 ` Thomas Gleixner
2025-11-17 23:16 ` Thomas Gleixner
2025-11-17 23:59 ` Luigi Rizzo
2025-11-18 8:34 ` Thomas Gleixner
2025-11-18 10:09 ` Luigi Rizzo
2025-11-18 16:31 ` Thomas Gleixner
2025-11-18 18:25 ` Luigi Rizzo
2025-11-18 23:06 ` Luigi Rizzo
2025-11-19 14:43 ` Thomas Gleixner
2025-11-21 10:58 ` Luigi Rizzo
2025-11-21 14:33 ` Luigi Rizzo
2025-11-22 14:08 ` Thomas Gleixner
2025-11-16 18:28 ` [PATCH v2 4/8] genirq: soft_moderation: implement adaptive moderation Luigi Rizzo
2025-11-17 20:51 ` Thomas Gleixner
2025-11-17 21:34 ` Luigi Rizzo
2025-11-17 23:05 ` Thomas Gleixner
2025-11-18 9:00 ` Thomas Gleixner
2025-11-16 18:28 ` [PATCH v2 5/8] x86/irq: soft_moderation: add support for posted_msi (intel) Luigi Rizzo
2025-11-17 21:14 ` Thomas Gleixner
2025-11-17 21:36 ` kernel test robot
2025-11-16 18:28 ` Luigi Rizzo [this message]
2025-11-16 18:28 ` [PATCH v2 7/8] nvme-pci: add module parameter for default moderation mode Luigi Rizzo
2025-11-16 18:28 ` [PATCH v2 8/8] vfio-pci: " Luigi Rizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251116182839.939139-7-lrizzo@google.com \
--to=lrizzo@google.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pabeni@redhat.com \
--cc=rizzo.unipi@gmail.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®