From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Kathiravan Thirumoorthy
<kathiravan.thirumoorthy@oss.qualcomm.com>
Subject: [PATCH 09/10] soc: qcom: spm: Use __cleanup() for device_node pointers
Date: Mon, 17 Nov 2025 10:21:28 +0530 [thread overview]
Message-ID: <20251117-cleanup_node_put-v1-9-5f107071d171@oss.qualcomm.com> (raw)
In-Reply-To: <20251117-cleanup_node_put-v1-0-5f107071d171@oss.qualcomm.com>
Apply the __cleanup() attribute to device_node pointers to simplify
resource management and remove explicit of_node_put() calls.
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
drivers/soc/qcom/spm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c
index f75659fff2874fb6a29c48ceee862b05b1ba5802..a87a8593a8b7fb2c62b14eaa9c96f46fc5eba877 100644
--- a/drivers/soc/qcom/spm.c
+++ b/drivers/soc/qcom/spm.c
@@ -391,7 +391,8 @@ static int spm_get_cpu(struct device *dev)
bool found;
for_each_possible_cpu(cpu) {
- struct device_node *cpu_node, *saw_node;
+ struct device_node *cpu_node __free(device_node) = NULL;
+ struct device_node *saw_node __free(device_node) = NULL;
cpu_node = of_cpu_device_node_get(cpu);
if (!cpu_node)
@@ -399,8 +400,6 @@ static int spm_get_cpu(struct device *dev)
saw_node = of_parse_phandle(cpu_node, "qcom,saw", 0);
found = (saw_node == dev->of_node);
- of_node_put(saw_node);
- of_node_put(cpu_node);
if (found)
return cpu;
--
2.34.1
next prev parent reply other threads:[~2025-11-17 4:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 4:51 [PATCH 00/10] soc: qcom: " Kathiravan Thirumoorthy
2025-11-17 4:51 ` [PATCH 01/10] soc: qcom: aoss: " Kathiravan Thirumoorthy
2025-11-17 11:35 ` Konrad Dybcio
2025-11-18 11:39 ` Krzysztof Kozlowski
2025-11-18 12:25 ` Dmitry Baryshkov
2025-11-18 12:32 ` Krzysztof Kozlowski
2025-11-18 12:52 ` Dmitry Baryshkov
2025-11-18 13:16 ` Konrad Dybcio
2025-11-18 13:25 ` Krzysztof Kozlowski
2025-11-18 15:18 ` Kathiravan Thirumoorthy
2025-11-18 11:38 ` Krzysztof Kozlowski
2025-11-17 4:51 ` [PATCH 02/10] soc: qcom: gsbi: " Kathiravan Thirumoorthy
2025-11-17 11:35 ` Konrad Dybcio
2025-11-18 11:38 ` Krzysztof Kozlowski
2025-11-17 4:51 ` [PATCH 03/10] soc: qcom: pd-mapper: " Kathiravan Thirumoorthy
2025-11-17 11:36 ` Konrad Dybcio
2025-11-18 11:43 ` Krzysztof Kozlowski
2025-11-17 4:51 ` [PATCH 04/10] soc: qcom: rpm-proc: " Kathiravan Thirumoorthy
2025-11-17 11:36 ` Konrad Dybcio
2025-11-18 11:40 ` Krzysztof Kozlowski
2025-11-17 4:51 ` [PATCH 05/10] soc: qcom: rpm_master_stats: " Kathiravan Thirumoorthy
2025-11-17 11:37 ` Konrad Dybcio
2025-11-18 11:40 ` Krzysztof Kozlowski
2025-11-17 4:51 ` [PATCH 06/10] soc: qcom: smem: " Kathiravan Thirumoorthy
2025-11-17 11:37 ` Konrad Dybcio
2025-11-18 11:42 ` Krzysztof Kozlowski
2025-11-17 4:51 ` [PATCH 07/10] soc: qcom: smp2p: " Kathiravan Thirumoorthy
2025-11-17 11:37 ` Konrad Dybcio
2025-11-18 11:41 ` Krzysztof Kozlowski
2025-11-17 4:51 ` [PATCH 08/10] soc: qcom: smsm: " Kathiravan Thirumoorthy
2025-11-17 11:38 ` Konrad Dybcio
2025-11-18 11:42 ` Krzysztof Kozlowski
2025-11-17 4:51 ` Kathiravan Thirumoorthy [this message]
2025-11-17 11:38 ` [PATCH 09/10] soc: qcom: spm: " Konrad Dybcio
2025-11-18 11:42 ` Krzysztof Kozlowski
2025-11-17 4:51 ` [PATCH 10/10] soc: qcom: ubwc: " Kathiravan Thirumoorthy
2025-11-17 11:39 ` Konrad Dybcio
2025-11-18 11:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117-cleanup_node_put-v1-9-5f107071d171@oss.qualcomm.com \
--to=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®