From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C211528640B for ; Mon, 17 Nov 2025 03:05:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763348731; cv=none; b=oQVOimo1pIDgtp8/z/8FVQ5e0oBWfasZYrG1EkMa37obBUzTLYAotiN4L+PMjxLIi2gHrhHdZn4ZsXCyUOG3lqddnSc5Vi+2WSzqD1RAA8x8PLUrGWaFBw+I++Ih3XSF481OzaQnGil7pG2UtI6XTAphtcluJ6ax1OosLUdzWBo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763348731; c=relaxed/simple; bh=GGbK9ECcWnSvud1G7GM2LCbScsKBIMzhTrv8uQdSig4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MrOt9IIKAv82SdkO5s7ocgR/IAwGZQ85Ai8dQ3L0Ei2C7U33FQLAu/6y6LTyoLWRTY8unWk9Mfu8la1Z4ozEb5pV0xBK9zHFBVSqcFOugioD+zaU/nDLZuHwflhLnESOdYK2tKf0tpmZsM4dpXlJuJYTB+qLmiIbLLDvKXlbATE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SdYWwy2o; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SdYWwy2o" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7b8e49d8b35so4290075b3a.3 for ; Sun, 16 Nov 2025 19:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763348729; x=1763953529; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sFHK69IjsXe42YTtWu5KnFjBsmBAvrLt75kGLyypvsU=; b=SdYWwy2oHhz5mmyexE4dgAgmPwKaD3jCOfqQ3ehp9f9IPnA5zjTbkTCaGa7hlQL6sh +7MZO5cH7S69YiYbeqZ0SVa/6XeP/e0BcHeirBZVXw5nd4TKIE97dRslS2orMqe/eEK9 zAAlPhaUVW892Q2mlgtjrfhgQ8DrPGj3ZyVHXqnd5KURg9OP0AHn1T5nWGvCPEiQV2oo 8aDFgawCyNdALq32u2b8Lde7k+EaR5ARhKXz08epF2DNLfAefnkCQulc4b9nTmO23oq/ BJYYDMGWW/AOF+kmOP/xeHSR+zygE8jem9I+xxtIoDWtdpijv9jZIdZRgoOyUpr0K4Fh bbig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763348729; x=1763953529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sFHK69IjsXe42YTtWu5KnFjBsmBAvrLt75kGLyypvsU=; b=Th9me9hDm8jFbWkbzuKOdTgVxgw+Pgtzf+SRbZb73CPiTKq8vWNH5lLhHbNad9cPwe vg1BLKUYUIVRpoCCKvOQUcvZdQUCN6k2XVi7YKhckVrJHfYAJfnNQo3R3O2Dw2sR4LU/ v8bDeYieYDIwutVqcZmFHcDZUzSKWsnv0EdKyTanKtZ0C4FJKOx37K9yBYdNzQPKDZzB xaLKoVDNX/Uz2DNdUXESc8e+/G2nhBa4ITu2HgoXr1zy+3gb4k/s4vxt37DCzAPjm9VR PmcMYj+5vowHSvaLFcfD7ve+876QldEpa8x0v/hCgmCJKW7BdO+HxqHcmuz44utzsw7U TG7w== X-Gm-Message-State: AOJu0YxvslnIp2RPmetNmcZ5Dl8frRwJng5GB74cL2h0LdUporb6oaTJ hrKJSDewrlRlTEGIlMGMeotcitnB537bBo+JX3Fenm5SWzTFXLeHF9AyKHy+GWzf X-Gm-Gg: ASbGncvbsNlMHfxs1BlCCHpbvzCLYj9ZgC5g/4uHX0pVgttOWenZ43zlYxoU+TDFtyW T3pUQmbxWsd+0I0qLyAq1t+om6jY4s/pjd76fRZCZAs2wCIuuJfA1sehQYfUenIna8LG5I+JgYT urL4x/BL+E+rt9t5NwKvuRWV+bcRhMxndK0pqeBTv5u7HZXjbAZXojtC6xwmncFfPcWws4iRDKn gESmOpwRZjEc9j3bVrPbFtXWssVB9wQWMwjNlwI8lWKN4DbbiiEyEfcTs1dGKgqhs0JDSR7sGrh dMLP5pLaIj++YrB2jMfMYZbKbzU7EzQEc1G6gTPjY7mSj3PKioxSBc8kl02JqpW9OpOM75Ixjzb +NaQMNUbQAgS5rV7GJYmkZS0/RYNDJ31bA4tLSgKmHyz+QoF+z+WrY2HaF6WHHZ+C5yb5wnzGWy uoBclUfgPcYp0= X-Google-Smtp-Source: AGHT+IHT2izYwickM3Ho+5lGl71wKYcruQgoWi3wBiNgzJcCv02JquMF+bMVGQKzgE3ioggAG87qrg== X-Received: by 2002:a05:6a20:e0a:b0:35b:c38c:dd28 with SMTP id adf61e73a8af0-35bc38cfd1cmr9445774637.1.1763348728653; Sun, 16 Nov 2025 19:05:28 -0800 (PST) Received: from localhost ([240b:4000:bb:1700:7b36:494d:5625:5a1]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bc36f61bea9sm10387500a12.14.2025.11.16.19.05.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Nov 2025 19:05:27 -0800 (PST) From: Lai Jiangshan To: linux-kernel@vger.kernel.org Cc: Lai Jiangshan , Juri Lelli , Waiman Long , Tejun Heo , Lai Jiangshan Subject: [PATCH 2/3] workqueue: Let DISASSOCIATED workers follow unbound wq cpumask changes Date: Mon, 17 Nov 2025 11:09:12 +0800 Message-Id: <20251117030913.3084-3-jiangshanlai@gmail.com> X-Mailer: git-send-email 2.19.1.6.gb485710b In-Reply-To: <20251117030913.3084-1-jiangshanlai@gmail.com> References: <20251117030913.3084-1-jiangshanlai@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Lai Jiangshan When workqueue cpumask changes are committed, the DISASSOCIATED workers affinity is not touched and this might be a problem down the line for isolated setups when the DISASSOCIATED pools still have works to run after the cpu is offline. Make sure the workers' affinity is updated every time a workqueue cpumask changes, so these workers can't break isolation. Cc: Juri Lelli Cc: Waiman Long Signed-off-by: Lai Jiangshan --- kernel/workqueue.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 9da679c621dc..ccf03a0ff122 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -6967,6 +6967,10 @@ static int workqueue_apply_unbound_cpumask(const cpumask_var_t unbound_cpumask) } if (!ret) { + int cpu; + struct worker_pool *pool; + struct worker *worker; + mutex_lock(&wq_pool_attach_mutex); cpumask_copy(wq_unbound_cpumask, unbound_cpumask); /* rescuer needs to respect cpumask changes when it is not attached */ @@ -6974,6 +6978,15 @@ static int workqueue_apply_unbound_cpumask(const cpumask_var_t unbound_cpumask) if (wq->rescuer && !wq->rescuer->pool) unbind_worker(wq->rescuer); } + /* DISASSOCIATED worker needs to respect wq_unbound_cpumask */ + for_each_possible_cpu(cpu) { + for_each_cpu_worker_pool(pool, cpu) { + if (!(pool->flags & POOL_DISASSOCIATED)) + continue; + for_each_pool_worker(worker, pool) + unbind_worker(worker); + } + } mutex_unlock(&wq_pool_attach_mutex); } return ret; -- 2.19.1.6.gb485710b