From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 047BB32779B for ; Mon, 17 Nov 2025 09:39:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763372396; cv=none; b=JS+zPj4xlqgU2xnrmjlZo0vTeeKDXW7QhtGuVaQyTVpRwZ3BhVCcWTMj374bP0DtcInkLckxgLpqJKZn5wVl074B1MhHhD1zzfb15KxpswYlI9Gm1dI5lK4bpE+3J/X4KeTynrpNyT9IhZXaJycMi+le0r3drA3mBmp4oTwWcs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763372396; c=relaxed/simple; bh=4CnGodEfo32klWJ1L+LcOk9DiKn6L/+cggihvUTvzwg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U7B9m5Tw88XAwPMChHDo3GGJIvajPaf9Hufkk3oIKclMOnELODFXIkJ8AcugUz63F8xDrCU8/RZX5Q2n0GB9tqe9VYPI3g34kTWVeT6ta6ZxeH01jj/caWlG/zDqvrMSaW2afCREuLPnRFQcIz97FB5JhyccsFBPqGirx461A50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=S9EJEhks; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GSiUmxzH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S9EJEhks"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GSiUmxzH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763372394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6O3GnJt58R4gRECz0DYLzPCnFMbftw1gUSd0oervUlc=; b=S9EJEhksz0kYq4PNeQ1bhqrFolZ0LuH5QTQAOvPJzKahcv/uG+xIfw6A8k1zAANpxcq4uG BqmGKa2r2plGGsaqVOj6vQ8ircaM5MQ3zrMYKTwUtBgjcLou842txdnpk6nnj18PBHZbbO VWokIxlnMiA7CdRH71q0A7/jEB2VIlk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-zMSnWJ5zMYWbGI11fAZ6bA-1; Mon, 17 Nov 2025 04:39:52 -0500 X-MC-Unique: zMSnWJ5zMYWbGI11fAZ6bA-1 X-Mimecast-MFC-AGG-ID: zMSnWJ5zMYWbGI11fAZ6bA_1763372391 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-42b2b642287so2382500f8f.2 for ; Mon, 17 Nov 2025 01:39:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763372391; x=1763977191; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6O3GnJt58R4gRECz0DYLzPCnFMbftw1gUSd0oervUlc=; b=GSiUmxzHBLOrwoDJ5q/yrucd4okKb2oBuOUxCXJ6Vdo1Y1wcmwUY25Y67obKLBUrEm yDflohsw7D/RCFoPQSgQLHGl0t3ObUnJj8ljTG9vGrBkYCbne4/zi5JcbKTRuz4pLTwy bNr2uicCJ0c7aFWhKcS2AMyyJLKIASLs76edZzVLfgaOC6LP6eYx9v4Xo+1aYrrbe0ib FxAyJX6yRrdNmjasvx7awdvvPAa11FULHw8PMj5chq0vJ2KrT1WfS12ETwOsOboWuQxq dlpqcxHVc72NgiMocGhLW6K9CROEhoZUBKFDxuU7yR/kF361wRUB7pDdv7MXOLO2zRtW ZGfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763372391; x=1763977191; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6O3GnJt58R4gRECz0DYLzPCnFMbftw1gUSd0oervUlc=; b=BTPzuur+0KivKn0y8jLI3WH+0SuCqfmKT+yYopoaYytvbfyrQ7NOSOsU2LOXafaokX xxsH/un/QKjRXhlKJCcTnz56gsEIKz9i0fJ4r7xdLTFZ8iGUvLIRLwP6ipqf/zYCtVIR H6vN95f3jbfTVS5Tc483iB9IYJB1l3pkc3wxRCtj+894Ha4JXZ02Gm1qh8tTNMi5MBZN GqGS5p+F6kWibA0fXn8kPW+UDkUHtsCxN6QcXswcSCVwebSdefHiPQ00yu9RQVaThFRm BFSj0N4d97aiTgF2fVmbXwF+RD2ZjcGwFwlmEAouCBqKMbUpnN5qvCmbcfj9Fzxfi/7k fiUA== X-Forwarded-Encrypted: i=1; AJvYcCWzT1HLvVQ/WeiJodAAn3Kyywskl0CZy6cGvfu811/ZEeA8lZV4egKsHEovdkbPgVm3pMCwnPRDQ6S5V8U=@vger.kernel.org X-Gm-Message-State: AOJu0Ywl4AA98vUWdEKegjPK1zu8WL24WO4ei1H/Vtm6Q9As8jYzpNkT W4mHCmWa/T1FAdWSGQ3DuHLN/I1pd0DzOOLRMV9lAWjnQRSd0mjU8NELTh+fyFAsUrVzIS8LS5o 8ITnt4Ad3qI+Tu5hWfJMLvpGDWv+sKdrTYIVAprwUCiK4DHwEi/LHdPgid5+iFs3f7g== X-Gm-Gg: ASbGncsnsGfsKK7t8GihAu2oDDey4P/xvCSndhdiL3wrUiwL7XhCF28pv6wF/oqyUzU Ov28kphXEFB4BhpcvOHAniSMhpJkPQFKJE9xYfBI0HCsvXQn6Okz7oKthgXAiJM87Zdda4lLvwr fTlc2S+rBwGEHfFdqZr4f3Zf9ktj8Lk/bNQGYC6n20+yRSejSE5FFHin8bA+HMkfbCGA6XNiRxK 8s0mFH373+azC+laheBroAdI7hcVTHeFMRfHcU4EOymRhm50SQZgqYH8SqmNQdlbf1/ipyUpALL C8/AxHZmPb/FXq891ihYtsBa9dL7LJkbfCJM7TKpJCxgCLiJlvEDVpgSzVLWC5gsD49naBaQHGx 1Lwky6oiTncHLodTqcs8= X-Received: by 2002:a05:6000:1865:b0:42b:3246:1681 with SMTP id ffacd0b85a97d-42b59344ff4mr10484791f8f.18.1763372391156; Mon, 17 Nov 2025 01:39:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfj5Hn7516Tmt768MAQru4ZVgWKYpkloYkkGdb4oINmzL5NMh2IECxn7AyarfOQjldp/tMEg== X-Received: by 2002:a05:6000:1865:b0:42b:3246:1681 with SMTP id ffacd0b85a97d-42b59344ff4mr10484756f8f.18.1763372390614; Mon, 17 Nov 2025 01:39:50 -0800 (PST) Received: from redhat.com (IGLD-80-230-39-63.inter.net.il. [80.230.39.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b5ce849ddsm18828364f8f.14.2025.11.17.01.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 01:39:50 -0800 (PST) Date: Mon, 17 Nov 2025 04:39:47 -0500 From: "Michael S. Tsirkin" To: Sukrut Heroorkar Cc: Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , "open list:VIRTIO CORE AND NET DRIVERS" , open list , shuah@kernel.org, david.hunter.linux@gmail.com Subject: Re: [PATCH] virtio: document @vaddr in virtqueue_map_free_coherent kernel-doc comment Message-ID: <20251117043922-mutt-send-email-mst@kernel.org> References: <20251029033559.83145-1-hsukrut3@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251029033559.83145-1-hsukrut3@gmail.com> On Wed, Oct 29, 2025 at 09:05:58AM +0530, Sukrut Heroorkar wrote: > Building with W=1 reports: > Warning: drivers/virtio/virtio_ring.c:3174 function parameter 'vaddr' > not described in 'virtqueue_map_free_coherent' > > The @vaddr parameter was introduced when virtqueue_map_free_coherent > was added in order to provide map operations to virtio device, but it > was never documented. Document @vaddr to silence this warning. > > Fixes: bee8c7c24b73 ("virtio: introduce map ops in virtio core") > Signed-off-by: Sukrut Heroorkar I picked a different version that fixed a couple of other issues as well, but thanks! > --- > drivers/virtio/virtio_ring.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 7b6205253b46..d763060ff0f6 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -3166,6 +3166,7 @@ EXPORT_SYMBOL_GPL(virtqueue_map_alloc_coherent); > * @vdev: the virtio device we are talking to > * @map: metadata for performing mapping > * @size: the size of the buffer > + * @vaddr: virtual address of the buffer > * @map_handle: the mapped address that needs to be freed > * > */ > -- > 2.43.0