From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78FD42797BE for ; Mon, 17 Nov 2025 15:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763394044; cv=none; b=kv87Ka4f0MBuGtT2/SeRoQBpEVFczDrzNNAM1iZEaKc08ZGjV+9eVEKUE2LiqnxV7bQHl0HmMHPT6zjSTkfkANqfJIfDvmsEeDYUEG9YqVqfbhfOtzKU6mpavtQGiJy6Y2UJ3PRWGNbkavqTeWcgvq8HBp6vdgxwFrJhwP8eYG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763394044; c=relaxed/simple; bh=ChQbEagoh7jfm8vykBVMa68QYnmyT4H5QotFogcAr6A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pNw0oGA6Y4b0ihtpYn8wXLh6dRr/w5i4pztEIwQQFJm9+oMVQIzBuVjMTBesmmmDgqMM5xI5RZciuVR6x5f9KS92cqBqoBgOIbKQDRHlPqt89f1V3gNIjDjMFgZdJ5rlXmJor6MIinIxWsCnnTXMIOF4L09RRvIjWTu4Aa1atak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lUdtx4ri; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lUdtx4ri" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-29812589890so57649975ad.3 for ; Mon, 17 Nov 2025 07:40:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763394042; x=1763998842; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VsdVFJLfCqjp7kPVWfOamCJg5ZBrJZ4jVC22PdP5X6U=; b=lUdtx4rioTFKBQ4FFqr+p87r+aYWrzcWwc16ch0MydEwwtNQBYSvVmG/gd5ZYOEldH 1z7vxUwuupOyOFRRgDwcEOflPKsRlVGcHPXW01cNmPm/SyrD9FiaUKbqtB5Dywq3fi5a RDSZMthmYVWPCbVJWIIPU/7tFkwoG0Rz92BEdem7MVETG/6xYbDcnUbaw0AzaMn9r+De 29tQxHYtwRV4U3AKxHyRoJMCZSJLveA3wfjbpkp6oSmk/+ApaRD1pmBScZlULkjkUbOg xoHlK3P9MDKRoI2FpEGAULrJ9pmd3og+Df2f41lN+gY195YsxhC2oM1vMsxJI0zLEtKm /yAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763394042; x=1763998842; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VsdVFJLfCqjp7kPVWfOamCJg5ZBrJZ4jVC22PdP5X6U=; b=vPVLPiNoqAcyFj+ZfXSloPKCnY6ujV1GIjPs9okeWzVBPyYFcZH8Le5xBXzXbbKqCc uXvHYgRGrUe1owipo1SgB4/lJhC0vRsNZZfgZZJW3eOzHtOmN9K/5bWOiSNF/nel6Vts Vz9hgllou0cXhpHyJnW+UY2BCnyY29CyXEZq8tPhH6zdGFeabrDbS0E04BExUciefmod DAI09rhx83i7AInUUOOdFwm1NK2qBE9cGf5MUlp41lPWToXWSq7vGe8gEaR1iHIklrkC PpCnE2WV0RXgoNhsaSLfiC9TXluJMdtXKQlEX3b38dw7q+DMQi5pPlHReYqbALQloklm JLaQ== X-Forwarded-Encrypted: i=1; AJvYcCWFVgUIDa/wiZYtOZEXZwrUW+SiIcq/ZjGp3EDF7qFdjd8P8jRy796zP+zQi6e+klZaWsbkyd5SPGlaDdU=@vger.kernel.org X-Gm-Message-State: AOJu0YzVgcZVftOJm0+nF/UHkRjlqD2cwJrM+Qr1Gu2scstL/s+40S5B RCrYF11ZlAmn9LuzMgZIQSCV+M1Gy45E72zq/eRJQom3E8L3tRTpOfwd X-Gm-Gg: ASbGnctPj+4FmmOkStFaWJXeBHlSp68fzuPaVD6LBSrn4FkGsUcnu2mCyilWeFZz9s4 uLGNjl2SdKasjotNbIoG9MlMYwPw0sKcG9vS2pHhru6yt8kIQa70Z/xmPQSHePvpBmYzPclVmY+ qFeDGxFlamf71cpB7/ghN/ajntOW31U2482nnjDgJAVAUGX0UDd1/oZqe0ab7WW1DzeOwehCnSW D+cgvapZq8fkgN16pne1ad2XdjArzt0OpY1zYDwm44wsJ1JN6P5rlCPwa36NZDVNcb3nd6gb4vm n8vdQ3ab+ww7ZLERXar6lDGJMmYicRxG7UDQd3kFTMWAEPoOS8DZdy02oHpIQtYxduGw9BW7oGH YO7vgEjg6KKM8mPltp0wgUa8p0jJDFIKFsUUWAWyziJPQhlpUHHriWqHQRDTfsUcrzPPc X-Google-Smtp-Source: AGHT+IFPNgEbJ6B+3n4tiLjzMnfUNJLrtDcPSjekE1ddOjVG2ZTd3guzZRLo4qp9zp+ewSn9GFrwfA== X-Received: by 2002:a17:903:384c:b0:298:68e:4057 with SMTP id d9443c01a7336-2986a759838mr162730605ad.59.1763394041776; Mon, 17 Nov 2025 07:40:41 -0800 (PST) Received: from gmail.com ([117.147.72.154]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-299daf12fe9sm51167715ad.74.2025.11.17.07.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 07:40:41 -0800 (PST) From: Peng Li X-Google-Original-From: Peng Li To: linux-mm@kvack.org, akpm@linux-foundation.org Cc: david@redhat.com, osalvador@suse.de, jgg@ziepe.ca, jhubbard@nvidia.com, peterx@redhat.com, linux-kernel@vger.kernel.org, dan.j.williams@intel.com, Peng Li , David Hildenbrand Subject: [PATCH v3 1/2] selftests/mm: gup_test: stop testing FOLL_TOUCH Date: Mon, 17 Nov 2025 23:40:11 +0800 Message-ID: <20251117154012.197499-1-peng8420.li@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Peng Li commit 0f20bba1688b ("mm/gup: explicitly define and check internal GUP flags, disallow FOLL_TOUCH") marked FOLL_TOUCH as a GUP-internal flag. This causes a warning to fire when running gup_test, for example: $ ./gup_test -L -r 100 -z dmesg: WARNING: CPU: 1 PID: 117 at mm/gup.c:2512 is_valid_gup_args+0x66/0x8c Therefore, remove the "FOLL_TOUCH" test code from gup_test.c. Signed-off-by: Peng Li Reviewed-by: John Hubbard Reviewed-by: David Hildenbrand (Red Hat) --- tools/testing/selftests/mm/gup_test.c | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c index 8900b840c17a..75f7134d529d 100644 --- a/tools/testing/selftests/mm/gup_test.c +++ b/tools/testing/selftests/mm/gup_test.c @@ -19,7 +19,6 @@ /* Just the flags we need, copied from mm.h: */ #define FOLL_WRITE 0x01 /* check pte is writable */ -#define FOLL_TOUCH 0x02 /* mark page accessed */ #define GUP_TEST_FILE "/sys/kernel/debug/gup_test" @@ -93,7 +92,7 @@ int main(int argc, char **argv) { struct gup_test gup = { 0 }; int filed, i, opt, nr_pages = 1, thp = -1, write = 1, nthreads = 1, ret; - int flags = MAP_PRIVATE, touch = 0; + int flags = MAP_PRIVATE; char *file = "/dev/zero"; pthread_t *tid; char *p; @@ -170,10 +169,6 @@ int main(int argc, char **argv) case 'H': flags |= (MAP_HUGETLB | MAP_ANONYMOUS); break; - case 'z': - /* fault pages in gup, do not fault in userland */ - touch = 1; - break; default: ksft_exit_fail_msg("Wrong argument\n"); } @@ -244,18 +239,9 @@ int main(int argc, char **argv) else if (thp == 0) madvise(p, size, MADV_NOHUGEPAGE); - /* - * FOLL_TOUCH, in gup_test, is used as an either/or case: either - * fault pages in from the kernel via FOLL_TOUCH, or fault them - * in here, from user space. This allows comparison of performance - * between those two cases. - */ - if (touch) { - gup.gup_flags |= FOLL_TOUCH; - } else { - for (; (unsigned long)p < gup.addr + size; p += psize()) - p[0] = 0; - } + /* Fault them in here, from user space. */ + for (; (unsigned long)p < gup.addr + size; p += psize()) + p[0] = 0; tid = malloc(sizeof(pthread_t) * nthreads); assert(tid); -- 2.43.0