From: Alex Williamson <alex@shazbot.org>
To: <ankita@nvidia.com>
Cc: <jgg@ziepe.ca>, <yishaih@nvidia.com>, <skolothumtho@nvidia.com>,
<kevin.tian@intel.com>, <aniketa@nvidia.com>, <vsethi@nvidia.com>,
<mochs@nvidia.com>, <Yunxiang.Li@amd.com>, <yi.l.liu@intel.com>,
<zhangdongdong@eswincomputing.com>, <avihaih@nvidia.com>,
<bhelgaas@google.com>, <peterx@redhat.com>, <pstanner@redhat.com>,
<apopple@nvidia.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <cjia@nvidia.com>,
<kwankhede@nvidia.com>, <targupta@nvidia.com>, <zhiw@nvidia.com>,
<danw@nvidia.com>, <dnigam@nvidia.com>, <kjaju@nvidia.com>
Subject: Re: [PATCH v1 6/6] vfio/nvgrace-gpu: vfio/nvgrace-gpu: wait for the GPU mem to be ready
Date: Mon, 17 Nov 2025 17:45:25 -0700 [thread overview]
Message-ID: <20251117174525.3690c712.alex@shazbot.org> (raw)
In-Reply-To: <20251117124159.3560-7-ankita@nvidia.com>
On Mon, 17 Nov 2025 12:41:59 +0000
<ankita@nvidia.com> wrote:
> From: Ankit Agrawal <ankita@nvidia.com>
>
> Speculative prefetches from CPU to GPU memory until the GPU
> is not ready after reset can cause harmless corrected RAS events
> to be logged. It is thus expected that the mapping not be
> re-established until the GPU is ready post reset.
>
> Wait for the GPU to be ready on the first fault before establishing
> CPU mapping to the GPU memory. The GPU readiness can be checked
> through BAR0 registers as is already being done at the device probe.
>
> The state is checked on the first fault/huge_fault request using
> a flag. Unset the flag on every reset request.
>
> So intercept the following calls to the GPU reset, unset
> gpu_mem_mapped. Then use it to determine whether to wait before
> mapping.
> 1. VFIO_DEVICE_RESET ioctl call
> 2. FLR through config space.
If we need a stall after reset based on some device specific readiness
criteria, shouldn't we just implement a device specific reset? We can
create a reset callback that uses pcie_reset_flr() then pci_iomap()s
the BAR to poll the device. See for example delay_250ms_after_flr()
and nvme_disable_and_flr(). Thanks,
Alex
prev parent reply other threads:[~2025-11-18 0:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 12:41 [PATCH v1 0/6] vfio/nvgrace-gpu: Support huge PFNMAP and wait ankita
2025-11-17 12:41 ` [PATCH v1 1/6] vfio/nvgrace-gpu: Use faults to map device memory ankita
2025-11-17 12:41 ` [PATCH v1 2/6] vfio: export function to map the VMA ankita
2025-11-17 12:41 ` [PATCH v1 3/6] vfio/nvgrace-gpu: Add support for huge pfnmap ankita
2025-11-18 6:12 ` kernel test robot
2025-11-17 12:41 ` [PATCH v1 4/6] vfio: export vfio_find_cap_start ankita
2025-11-17 12:41 ` [PATCH v1 5/6] vfio/nvgrace-gpu: split the code to wait for GPU ready ankita
2025-11-17 12:41 ` [PATCH v1 6/6] vfio/nvgrace-gpu: vfio/nvgrace-gpu: wait for the GPU mem to be ready ankita
2025-11-18 0:45 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117174525.3690c712.alex@shazbot.org \
--to=alex@shazbot.org \
--cc=Yunxiang.Li@amd.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=apopple@nvidia.com \
--cc=avihaih@nvidia.com \
--cc=bhelgaas@google.com \
--cc=cjia@nvidia.com \
--cc=danw@nvidia.com \
--cc=dnigam@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kjaju@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochs@nvidia.com \
--cc=peterx@redhat.com \
--cc=pstanner@redhat.com \
--cc=skolothumtho@nvidia.com \
--cc=targupta@nvidia.com \
--cc=vsethi@nvidia.com \
--cc=yi.l.liu@intel.com \
--cc=yishaih@nvidia.com \
--cc=zhangdongdong@eswincomputing.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®