From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH 1/5] x86/insn-eval: Remove unused regs arg some functions
Date: Tue, 18 Nov 2025 09:47:21 +0100 [thread overview]
Message-ID: <20251118084721.GK3245006@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251117093137.572132-1-jolsa@kernel.org>
On Mon, Nov 17, 2025 at 10:31:32AM +0100, Jiri Olsa wrote:
> hi,
> regs argument is not used in several insn-eval functions, removing it.
>
> I have some changes based on these functions and it feels wrong to pass
> NULL in regs argument. Also I don't want to send 5 extra patches with
> my other change, so sending this separately.
>
> thanks,
> jirka
>
>
> ---
> Jiri Olsa (5):
> x86/insn-eval: Remove regs arg from pt_regs_offset
> x86/insn-eval: Remove regs arg from get_reg_offset
> x86/insn-eval: Remove regs arg from insn_get_modrm_rm_off
> x86/insn-eval: Remove regs arg from insn_get_modrm_reg_off
> x86/insn-eval: Remove regs arg from get_reg_offset_16
>
> arch/x86/coco/sev/vc-handle.c | 2 +-
> arch/x86/include/asm/insn-eval.h | 6 +++---
> arch/x86/kernel/cfi.c | 2 +-
> arch/x86/kernel/umip.c | 2 +-
> arch/x86/lib/insn-eval.c | 35 +++++++++++++++--------------------
> arch/x86/mm/extable.c | 2 +-
> 6 files changed, 22 insertions(+), 27 deletions(-)
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
prev parent reply other threads:[~2025-11-18 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 9:31 Jiri Olsa
2025-11-17 9:31 ` [PATCH 1/5] x86/insn-eval: Remove regs arg from pt_regs_offset Jiri Olsa
2025-11-17 9:31 ` [PATCH 2/5] x86/insn-eval: Remove regs arg from get_reg_offset Jiri Olsa
2025-11-17 9:31 ` [PATCH 3/5] x86/insn-eval: Remove regs arg from insn_get_modrm_rm_off Jiri Olsa
2025-11-17 9:31 ` [PATCH 4/5] x86/insn-eval: Remove regs arg from insn_get_modrm_reg_off Jiri Olsa
2025-11-17 9:31 ` [PATCH 5/5] x86/insn-eval: Remove regs arg from get_reg_offset_16 Jiri Olsa
2025-11-18 8:47 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118084721.GK3245006@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®