From: Harikrishna Shenoy <h-shenoy@ti.com>
To: <Laurent.pinchart@ideasonboard.com>, <airlied@gmail.com>,
<andrzej.hajda@intel.com>, <andy.yan@rock-chips.com>,
<aradhya.bhatia@linux.dev>, <devarsht@ti.com>,
<dianders@chromium.org>, <dri-devel@lists.freedesktop.org>,
<javierm@redhat.com>, <jernej.skrabec@gmail.com>,
<jonas@kwiboo.se>, <linux-kernel@vger.kernel.org>,
<linux@treblig.org>, <luca.ceresoli@bootlin.com>,
<lumag@kernel.org>, <lyude@redhat.com>,
<maarten.lankhorst@linux.intel.com>, <mordan@ispras.ru>,
<mripard@kernel.org>, <neil.armstrong@linaro.org>,
<rfoss@kernel.org>, <s-jain1@ti.com>, <simona@ffwll.ch>,
<tomi.valkeinen@ideasonboard.com>, <tzimmermann@suse.de>,
<u-kumar1@ti.com>
Subject: [PATCH v9 6/6] drm/bridge: cadence: cdns-mhdp8546-core: Reduce log level for DPCD read/write
Date: Tue, 18 Nov 2025 17:22:55 +0530 [thread overview]
Message-ID: <20251118115255.108225-7-h-shenoy@ti.com> (raw)
In-Reply-To: <20251118115255.108225-1-h-shenoy@ti.com>
From: Jayesh Choudhary <j-choudhary@ti.com>
Reduce the log level for cdns_mhdp_dpcd_read and cdns_mhdp_dpcd_write
errors in cdns_mhdp_transfer function as in case of failure, there is
flooding of these prints along with other indicators like EDID failure
logs which are fairly intuitive in themselves rendering these error logs
useless.
Also, the caller functions for the cdns_mhdp_transfer in drm_dp_helper.c
(which calls it 32 times), has debug log level in case transfer fails.
So having a superseding log level in cdns_mhdp_transfer seems bad.
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
---
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
index 002b4be3de674..120eb7ffe20c0 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
@@ -778,7 +778,7 @@ static ssize_t cdns_mhdp_transfer(struct drm_dp_aux *aux,
if (!ret)
continue;
- dev_err(mhdp->dev,
+ dev_dbg(mhdp->dev,
"Failed to write DPCD addr %u\n",
msg->address + i);
@@ -788,7 +788,7 @@ static ssize_t cdns_mhdp_transfer(struct drm_dp_aux *aux,
ret = cdns_mhdp_dpcd_read(mhdp, msg->address,
msg->buffer, msg->size);
if (ret) {
- dev_err(mhdp->dev,
+ dev_dbg(mhdp->dev,
"Failed to read DPCD addr %u\n",
msg->address);
--
2.34.1
next prev parent reply other threads:[~2025-11-18 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 11:52 [PATCH v9 0/6] MHDP8546 fixes related to DBANC usecase Harikrishna Shenoy
2025-11-18 11:52 ` [PATCH v9 1/6] drm/bridge: cadence: cdns-mhdp8546-core: Set the mhdp connector earlier in atomic_enable() Harikrishna Shenoy
2025-11-18 11:52 ` [PATCH v9 2/6] drm/bridge: cadence: cdns-mhdp8546-core: Add mode_valid hook to drm_bridge_funcs Harikrishna Shenoy
2025-11-18 11:52 ` [PATCH v9 3/6] drm/bridge: cadence: cdns-mhdp8546-core: Handle HDCP state in bridge atomic check Harikrishna Shenoy
2025-11-18 11:52 ` [PATCH v9 4/6] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge Harikrishna Shenoy
2025-11-18 11:52 ` [PATCH v9 5/6] cadence: cdns-mhdp8546*: Change drm_connector from structure to pointer Harikrishna Shenoy
2025-11-18 11:52 ` Harikrishna Shenoy [this message]
2025-11-18 12:40 ` [PATCH v9 0/6] MHDP8546 fixes related to DBANC usecase Maxime Ripard
2025-11-18 14:52 ` Tomi Valkeinen
2025-11-18 16:20 ` Maxime Ripard
2025-11-20 7:48 ` Harikrishna shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118115255.108225-7-h-shenoy@ti.com \
--to=h-shenoy@ti.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=aradhya.bhatia@linux.dev \
--cc=devarsht@ti.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=luca.ceresoli@bootlin.com \
--cc=lumag@kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mordan@ispras.ru \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=s-jain1@ti.com \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®