From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD94135BDD2 for ; Tue, 18 Nov 2025 14:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763475807; cv=none; b=kxCkUhcvAEyM6V0HfJl2EZ+qeIrxCyXOj3It/+LMtK4Cbu83LiZnoaDe4IYY2DZR6MWB4ND/AqsqKCH7Hj1ViVU9tSw9abK9njOo1miHwu3jgw00jqIxe3WdC//GrCsbebAcRKEZGGuUCPBm4yqoM82bPRFwM7+VwuRfc5xrVaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763475807; c=relaxed/simple; bh=zZSQe2ZxHutuqSiWUIg5Vy/daN/b64qg/IMIRlyyNxs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fogXv291hxBmc76nlJ8PfZhjHSWzpqRoZCsVqkYBJsjeonxmNTcNWnfTxnZqFh1BaseRvHPwSlWaEf9CCVrCmqjuBhxO5FkUq15u8WZ461Uuj8Am2U33yOSFGthTehPMwrj+TnYiDkpFVqkB2MzdskyGD7l57s6DMupsG2VRQYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nFDAZqRK; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nFDAZqRK" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-29808a9a96aso58614275ad.1 for ; Tue, 18 Nov 2025 06:23:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763475805; x=1764080605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i4UD0GpwQ8ZB6y6bn4+JVNJNgyJMPm3VDbXU5N9w4UY=; b=nFDAZqRKKuCqpEbzzB1UKQAvUOH/0Qzsto635lsIeOA/P0ZpfM+mt0tAnfhy+cozIe OcknJpT1XqktmZM1N03ds6zeX/zmbpvpnGDLxZSOn5PiKB3SerQufkvPjmuCjiS3MlG5 7x9IVz0FX4j2CHfCd6KqQazjfuRUC4npbzrER/qXYLQ4TUf1gGZtEr285wIkMsJmQe5h eQqKNVSUtwSi95QNeIkcrr41jEHyniIXf3hTjlUsnzaIFwSe3OtSb8DkBkVuGJuOIcI0 3UeqiD8wRMxTXz9McTPWU8SjQDE4+nExj6eqF8ZvFiji6mIPjRfNzwrWd06bpxXI/0of wRJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763475805; x=1764080605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i4UD0GpwQ8ZB6y6bn4+JVNJNgyJMPm3VDbXU5N9w4UY=; b=ozi8UDzsPpKtb8FdeceMUiuMJ8qCVwsPSG4XD0nhGmbjFdJ+zvjbLV5Oytuj0o+qFf puWGujHejKFQij1HCqo+gTctCfppRJLXGMpb40/dVSnfYOV9F01iY0EWr7clgsEPhRzW 9o2C5BfYvuBXfFpyVQCWn/Ut7NZsLjkxweBCEQcY0Fa8Sknb2q252P5jZaurvSk12v/L lLjeuz8MCYZ144he7P5PqumiNyG57EMjmTVhDjYeXQ7S2e/Y/8+SN9ewlaAjY0vBiG8a VqZmxuz5+VUIHgW7x6vxZAaOIxyEUDdUftTDJrjPglEjzdctUml9+bz3bJJGl7YCP2oH uwEw== X-Forwarded-Encrypted: i=1; AJvYcCUtDRqlEucjDPM2iF2wOHfuJQQAS05r7C5JpFdh5aefIn9rcS2x0/ojkpqvKj28parKGyQlWutMIjSuFfQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxMHEVEjH0L3irwJ0bEL4uJZIuqQgMlu0kAeX/xcADzsluVazjg BPsZs08ojV7hk3+1k+NCD/yHoNDAnOwcWHoWX+EDFN2Nr5Yk+JRzY0UU X-Gm-Gg: ASbGnct+c7WG5eCv6Xd2sQ4ILfcMiVoe6iZsSCqHn1VyAQjMZNnCeLJa8Y2T0OQ1ENA 26kgK1a7GPcpKVgw4fQjRaVgnbNu05OSrAmW4tYh1YoZGEUpLuoTD3nA/L39tELswKO+TR1GhsZ 3sHAWdguo72E/g6AlUxxyQ8hQwuzWyMm2yeCohU5zKYsKbfexbMDKUr51ijmfs28qLrMC9W8dDM vOcMKGKkCGmxwW08K2JhC2dC9BGR8mEoWeUig0AYV+a8rsZlllOR84CBMRdXkjS7amfEzQHYtG+ MP4WdJqgFrtarmtn7ujobK6eAv2zNU61DrFvMZYOvRox+G8aehNg3aELFuj4OlP3hh7O/iOJMwo +1nfxnwfFq7W4UDPNXI7FNcB8bGvJyXT6UvWuzyilMs6QGqKbFPUfLbAvuiYPKaU6NwpQCUq5eQ G/PPD4lY4MsvvYcuow X-Google-Smtp-Source: AGHT+IEC31C+/QdlNZ28QnBzgc25thMPM7VSRkpCkiti8OLZOlHrEqIdHvn57SdKvFQQebb6wsTr7A== X-Received: by 2002:a17:903:120b:b0:298:60d5:d27a with SMTP id d9443c01a7336-2986a73b975mr207046245ad.28.1763475804730; Tue, 18 Nov 2025 06:23:24 -0800 (PST) Received: from rakuram-MSI ([2405:201:d027:f05b:b076:498e:270b:2a02]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bc377414572sm15108698a12.35.2025.11.18.06.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 06:23:24 -0800 (PST) From: Rakuram Eswaran To: ulf.hansson@linaro.org, u.kleine-koenig@baylibre.com Cc: chenhuacai@kernel.org, dan.carpenter@linaro.org, david.hunter.linux@gmail.com, khalid@kernel.org, linux-kernel-mentees@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, lkp@intel.com, rakuram.e96@gmail.com, skhan@linuxfoundation.org, zhoubinbin@loongson.cn Subject: Re: [PATCH v3] mmc: pxamci: Simplify pxamci_probe() error handling using devm APIs Date: Tue, 18 Nov 2025 19:53:11 +0530 Message-ID: <20251118142317.12921-1-rakuram.e96@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: CAPDyKFoSX7QZGv78dL10C38wY0Sg5QC1qxvhyGXJ+VUYHihP3A@mail.gmail.com References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On Tue, 11 Nov 2025 at 23:06, Ulf Hansson wrote: > > On Thu, 23 Oct 2025 at 16:54, Rakuram Eswaran wrote: > > > > This patch refactors pxamci_probe() to use devm-managed resource > > allocation (e.g. devm_dma_request_chan) and dev_err_probe() for > > improved readability and automatic cleanup on probe failure. > > > > It also removes redundant NULL assignments and manual resource release > > logic from pxamci_probe(), and eliminates the corresponding release > > calls from pxamci_remove(). > > > > Reported-by: kernel test robot > > Reported-by: Dan Carpenter > > Closes: https://lore.kernel.org/r/202510041841.pRlunIfl-lkp@intel.com/ > > Fixes: 58c40f3faf742c ("mmc: pxamci: Use devm_mmc_alloc_host() helper") > > Suggested-by: Uwe Kleine-König > > Signed-off-by: Rakuram Eswaran > > Applied for fixes, thanks! > > Kind regards > Uffe > Hi Ulf Hansson, Thank you for applying to fixes branch. Hi Uwe, Shall I start to send the patch to remove the redundant if condition check from pxamic_remove() function? Link to prior discussion: https://lore.kernel.org/linux-mmc/pvid2ycmgbkbmegnnzwl4hyev6e2smusxk5olkuqxfwxzykz2e@jlvolirolrxl/ I can pull Uffe fixes branch to send the above patch? Any inputs will be really helpful to start working on this. Another point, I would like to ask is about the below discussion. You have mentioned about WIP suggestion for clk_get_rate(). Link to that discussion: https://lore.kernel.org/linux-mmc/20251020183209.11040-1-rakuram.e96@gmail.com/ Was my understanding is correct? Best Regards, Rakuram