From: Peng Li <peng8420.li@gmail.com>
To: linux-mm@kvack.org, akpm@linux-foundation.org
Cc: david@redhat.com, osalvador@suse.de, jgg@ziepe.ca,
jhubbard@nvidia.com, peterx@redhat.com,
linux-kernel@vger.kernel.org, dan.j.williams@intel.com,
Peng Li <peng8420.li@gmail.com>
Subject: [PATCH] mm/vmalloc: fix build error
Date: Tue, 18 Nov 2025 23:50:34 +0800 [thread overview]
Message-ID: <20251118155034.273696-1-peng8420.li@gmail.com> (raw)
From: Peng Li <peng8420.li@gmail.com>
commit 056b93566a35 ("mm/vmalloc: warn only once when vmalloc
detect invalid gfp flags") modify the function call from WARN to WARN_ONCE.
WARN_ONCE input parameter format error, missing ',' tag.
Resulting in the following compilation errors:
mm/vmalloc.c:3940:19: error: expected ‘)’ before ‘invalid_mask’
3940 | invalid_mask, &invalid_mask, flags, &flags);
After adding the "," tag, the compilation passed.
Signed-off-by: Peng Li <peng8420.li@gmail.com>
---
mm/vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index d78c4d09d6ea..0469ba2c230e 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3936,7 +3936,7 @@ static gfp_t vmalloc_fix_flags(gfp_t flags)
gfp_t invalid_mask = flags & ~GFP_VMALLOC_SUPPORTED;
flags &= GFP_VMALLOC_SUPPORTED;
- WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n"
+ WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n",
invalid_mask, &invalid_mask, flags, &flags);
return flags;
}
--
2.43.0
next reply other threads:[~2025-11-18 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 15:50 Peng Li [this message]
2025-11-21 0:16 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118155034.273696-1-peng8420.li@gmail.com \
--to=peng8420.li@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®