From: David Arcari <darcari@redhat.com>
To: lenb@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
David Arcari <darcari@redhat.com>
Subject: [PATCH 3/3] tools/power turbostat: allow turbostat to work when aperf is not available
Date: Tue, 18 Nov 2025 10:58:13 -0500 [thread overview]
Message-ID: <20251118155813.533424-4-darcari@redhat.com> (raw)
In-Reply-To: <20251118155813.533424-1-darcari@redhat.com>
Currently when aperf is not available the function has_amperf() still
returns true. The end result is that the program gets an error in
delta_thread() which causes turbostat to restart. We can avoid this
by not setting msr_counter_arch_infos[MSR_ARCH_INFO_APERF_INDEX].present
when aperf is not available allowing turbostat to execute normally.
Signed-off-by: David Arcari <darcari@redhat.com>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-kernel@vger.kernel.org
---
tools/power/x86/turbostat/turbostat.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 5567b9ecd516..b3f1e4ae5813 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -8592,6 +8592,10 @@ void msr_perf_init_(void)
continue;
if (cai->needed) {
+ /* check to see if APERF is available */
+ if (cidx == MSR_ARCH_INFO_APERF_INDEX && !has_aperf)
+ continue;
+
/* Use perf API for this counter */
if (add_msr_perf_counter(cpu, cci, cai) != -1) {
cci->source[cai->rci_index] = COUNTER_SOURCE_PERF;
--
2.51.0
next prev parent reply other threads:[~2025-11-18 15:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 15:58 [PATCH 0/3] tools/power turbostat: Fix segfault and restart loop issues David Arcari
2025-11-18 15:58 ` [PATCH 1/3] tools/power turbostat: avoid segfault referencing fd_instr_count_percpu David Arcari
2025-11-25 19:11 ` Len Brown
2025-12-01 14:13 ` David Arcari
2025-11-18 15:58 ` [PATCH 2/3] tools/power turbostat: avoid an infinite loop of restarts David Arcari
2025-11-25 19:12 ` Len Brown
2025-11-25 21:50 ` David Arcari
2025-11-27 17:45 ` Len Brown
2025-12-01 12:18 ` David Arcari
2025-11-18 15:58 ` David Arcari [this message]
2025-11-25 19:14 ` [PATCH 3/3] tools/power turbostat: allow turbostat to work when aperf is not available Len Brown
2025-11-25 21:55 ` David Arcari
2025-12-01 15:13 ` David Arcari
2025-12-01 19:53 ` Len Brown
2025-12-01 20:11 ` Len Brown
2025-12-02 12:55 ` David Arcari
2025-12-02 15:02 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118155813.533424-4-darcari@redhat.com \
--to=darcari@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®