mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: akpm@linux-foundation.org
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com,
	aliceryhl@google.com,  arnd@arndb.de, bjorn3_gh@protonmail.com,
	boqun.feng@gmail.com,  dakr@kernel.org, gary@garyguo.net,
	jhubbard@nvidia.com,  linux-kernel@vger.kernel.org,
	lossin@kernel.org, ojeda@kernel.org,
	 rust-for-linux@vger.kernel.org, tmgross@umich.edu,
	yury.norov@gmail.com
Subject: [PATCH] uaccess: gate _copy_[to|from]_user on !INLINE_COPY_FROM_USER
Date: Tue, 18 Nov 2025 17:32:50 +0000	[thread overview]
Message-ID: <20251118173250.2821388-1-aliceryhl@google.com> (raw)
In-Reply-To: <20251118091818.152ba4fc0c8a6f3092a36fbc@linux-foundation.org>

These methods only exist when INLINE_COPY_FROM_USER is disabled, so
update the header file to reflect that.

This fixes the following error on builds that enable both RUST and
INLINE_COPY_FROM_USER.

ERROR: modpost: "_copy_from_user" [samples/rust/rust_misc_device.ko] undefined!
ERROR: modpost: "_copy_to_user" [samples/rust/rust_misc_device.ko] undefined!

This error is triggered because when a method is available both as a
rust_helper_* and normal method, Rust will call the normal method.

Fixes: d99dc586ca7c ("uaccess: decouple INLINE_COPY_FROM_USER and CONFIG_RUST")
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
 include/linux/uaccess.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h
index 01cbd7dd0ba3..205e1e65f481 100644
--- a/include/linux/uaccess.h
+++ b/include/linux/uaccess.h
@@ -181,8 +181,10 @@ _inline_copy_from_user(void *to, const void __user *from, unsigned long n)
 	memset(to + (n - res), 0, res);
 	return res;
 }
+#ifndef INLINE_COPY_FROM_USER
 extern __must_check unsigned long
 _copy_from_user(void *, const void __user *, unsigned long);
+#endif
 
 static inline __must_check unsigned long
 _inline_copy_to_user(void __user *to, const void *from, unsigned long n)
@@ -196,8 +198,10 @@ _inline_copy_to_user(void __user *to, const void *from, unsigned long n)
 	}
 	return n;
 }
+#ifndef INLINE_COPY_FROM_USER
 extern __must_check unsigned long
 _copy_to_user(void __user *, const void *, unsigned long);
+#endif
 
 static __always_inline unsigned long __must_check
 copy_from_user(void *to, const void __user *from, unsigned long n)

base-commit: 3e4b89e970365db7fe2c4171be06c0e88e3bcbe6
-- 
2.52.0.rc1.455.g30608eb744-goog


  reply	other threads:[~2025-11-18 17:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 15:47 [PATCH v2] uaccess: decouple INLINE_COPY_FROM_USER and CONFIG_RUST Yury Norov (NVIDIA)
2025-10-24 16:16 ` Arnd Bergmann
2025-10-24 17:39 ` Miguel Ojeda
2025-11-18 10:39 ` Alice Ryhl
2025-11-18 17:18   ` Andrew Morton
2025-11-18 17:32     ` Alice Ryhl [this message]
2025-11-18 17:40       ` [PATCH] uaccess: gate _copy_[to|from]_user on !INLINE_COPY_FROM_USER Alice Ryhl
2025-11-18 19:51     ` [PATCH v2] uaccess: decouple INLINE_COPY_FROM_USER and CONFIG_RUST Yury Norov
2025-11-18 20:39       ` Alice Ryhl
2025-11-19  0:08         ` Philip Li
2025-11-19  0:07       ` Philip Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118173250.2821388-1-aliceryhl@google.com \
    --to=aliceryhl@google.com \
    --cc=a.hindborg@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex.gaynor@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®