From: Fenglin Wu via B4 Relay <devnull+fenglin.wu.oss.qualcomm.com@kernel.org>
To: kernel@oss.qualcomm.com, Lee Jones <lee@kernel.org>,
Pavel Machek <pavel@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Subbaraman Narayanamurthy
<subbaraman.narayanamurthy@oss.qualcomm.com>,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Fenglin Wu <fenglin.wu@oss.qualcomm.com>
Subject: [PATCH v3 0/2] leds: rgb: lpg: Don't enable TRILED when configuring PWM
Date: Wed, 19 Nov 2025 14:06:41 +0800 [thread overview]
Message-ID: <20251119-lpg_triled_fix-v3-0-84b6dbdc774a@oss.qualcomm.com> (raw)
The LPG channel can be used for only outputting PWM signal without the
need to enable TRILED. Update the DT binding document to explain that
usage and remove the TRILED enabling register write in the driver for
that use case.
Signed-off-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
---
Changes in v3:
- Add a DT binding change to clarify the standalone PWM usage according
to the suggestion from Bjorn.
- Link to v2: https://lore.kernel.org/r/20251118-lpg_triled_fix-v2-1-6d1e5831333f@oss.qualcomm.com
Changes in v2:
- Check "chan->in_use" flag in lpg_pwm_apply() is not correct, as it
indicates the channel is being used as a LED and this PWM API would
never get called. Instead, remove the code line which enables TRILED
in lpg_pwm_apply() and update the commit text to explain it clearly.
- Link to v1: https://lore.kernel.org/r/20251114-lpg_triled_fix-v1-1-9b239832c53c@oss.qualcomm.com
---
Fenglin Wu (2):
dt-bindings: leds: qcom-lpg: Explain standalone PWM usage
leds: rgb: leds-qcom-lpg: Don't enable TRILED when configuring PWM
Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 5 +++++
drivers/leds/rgb/leds-qcom-lpg.c | 4 +---
2 files changed, 6 insertions(+), 3 deletions(-)
---
base-commit: ea1c4c7e648d1ca91577071fc42fdc219521098c
change-id: 20251114-lpg_triled_fix-44491b49b340
Best regards,
--
Fenglin Wu <fenglin.wu@oss.qualcomm.com>
next reply other threads:[~2025-11-19 6:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 6:06 Fenglin Wu via B4 Relay [this message]
2025-11-19 6:06 ` [PATCH v3 1/2] dt-bindings: leds: qcom-lpg: Explain standalone PWM usage Fenglin Wu via B4 Relay
2025-11-19 21:51 ` Bjorn Andersson
2025-11-20 16:13 ` Rob Herring
2025-11-19 6:06 ` [PATCH v3 2/2] leds: rgb: leds-qcom-lpg: Don't enable TRILED when configuring PWM Fenglin Wu via B4 Relay
2025-11-19 21:52 ` Bjorn Andersson
2025-11-20 15:25 ` [PATCH v3 0/2] leds: rgb: lpg: " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119-lpg_triled_fix-v3-0-84b6dbdc774a@oss.qualcomm.com \
--to=devnull+fenglin.wu.oss.qualcomm.com@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fenglin.wu@oss.qualcomm.com \
--cc=kernel@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=pavel@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=subbaraman.narayanamurthy@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®