From: kernel test robot <lkp@intel.com>
To: Dmitry Skorodumov <skorodumov.dmitry@huawei.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, andrey.bokhanko@huawei.com,
edumazet@google.com,
Dmitry Skorodumov <skorodumov.dmitry@huawei.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 04/13] ipvlan: Support IPv6 in macnat mode.
Date: Wed, 19 Nov 2025 11:25:07 +0800 [thread overview]
Message-ID: <202511191026.AhVx4Zqc-lkp@intel.com> (raw)
In-Reply-To: <20251118100046.2944392-5-skorodumov.dmitry@huawei.com>
Hi Dmitry,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Skorodumov/ipvlan-Support-MACNAT-mode/20251118-180814
base: net-next/main
patch link: https://lore.kernel.org/r/20251118100046.2944392-5-skorodumov.dmitry%40huawei.com
patch subject: [PATCH net-next 04/13] ipvlan: Support IPv6 in macnat mode.
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20251119/202511191026.AhVx4Zqc-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251119/202511191026.AhVx4Zqc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511191026.AhVx4Zqc-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ipvlan/ipvlan_core.c: In function 'ipvlan_macnat_xmit_phydev':
>> drivers/net/ipvlan/ipvlan_core.c:343:25: warning: variable 'orig_skb' set but not used [-Wunused-but-set-variable]
343 | struct sk_buff *orig_skb = skb;
| ^~~~~~~~
vim +/orig_skb +343 drivers/net/ipvlan/ipvlan_core.c
e9103e24d10046 Dmitry Skorodumov 2025-11-18 337
26dcd46025738d Dmitry Skorodumov 2025-11-18 338 static int ipvlan_macnat_xmit_phydev(struct ipvl_port *port,
26dcd46025738d Dmitry Skorodumov 2025-11-18 339 struct sk_buff *skb,
26dcd46025738d Dmitry Skorodumov 2025-11-18 340 bool lyr3h_valid,
26dcd46025738d Dmitry Skorodumov 2025-11-18 341 void *lyr3h, int addr_type)
26dcd46025738d Dmitry Skorodumov 2025-11-18 342 {
26dcd46025738d Dmitry Skorodumov 2025-11-18 @343 struct sk_buff *orig_skb = skb;
26dcd46025738d Dmitry Skorodumov 2025-11-18 344
26dcd46025738d Dmitry Skorodumov 2025-11-18 345 skb = skb_unshare(skb, GFP_ATOMIC);
26dcd46025738d Dmitry Skorodumov 2025-11-18 346 if (!skb)
26dcd46025738d Dmitry Skorodumov 2025-11-18 347 return NET_XMIT_DROP;
26dcd46025738d Dmitry Skorodumov 2025-11-18 348
26dcd46025738d Dmitry Skorodumov 2025-11-18 349 /* Use eth-addr of main as source. */
26dcd46025738d Dmitry Skorodumov 2025-11-18 350 skb_reset_mac_header(skb);
26dcd46025738d Dmitry Skorodumov 2025-11-18 351 ether_addr_copy(skb_eth_hdr(skb)->h_source, port->dev->dev_addr);
26dcd46025738d Dmitry Skorodumov 2025-11-18 352
26dcd46025738d Dmitry Skorodumov 2025-11-18 353 if (!lyr3h_valid) {
26dcd46025738d Dmitry Skorodumov 2025-11-18 354 lyr3h = ipvlan_get_L3_hdr(port, skb, &addr_type);
26dcd46025738d Dmitry Skorodumov 2025-11-18 355 orig_skb = skb; /* no need to reparse */
26dcd46025738d Dmitry Skorodumov 2025-11-18 356 }
e9103e24d10046 Dmitry Skorodumov 2025-11-18 357 if (!lyr3h)
e9103e24d10046 Dmitry Skorodumov 2025-11-18 358 addr_type = -1;
e9103e24d10046 Dmitry Skorodumov 2025-11-18 359 else if (addr_type == IPVL_ARP)
e9103e24d10046 Dmitry Skorodumov 2025-11-18 360 ipvlan_macnat_patch_tx_arp(port, skb);
e9103e24d10046 Dmitry Skorodumov 2025-11-18 361 else if (addr_type == IPVL_ICMPV6 || addr_type == IPVL_IPV6)
e9103e24d10046 Dmitry Skorodumov 2025-11-18 362 ipvlan_macnat_patch_tx_ipv6(port, skb);
26dcd46025738d Dmitry Skorodumov 2025-11-18 363
26dcd46025738d Dmitry Skorodumov 2025-11-18 364 skb->dev = port->dev;
26dcd46025738d Dmitry Skorodumov 2025-11-18 365 return dev_queue_xmit(skb);
26dcd46025738d Dmitry Skorodumov 2025-11-18 366 }
26dcd46025738d Dmitry Skorodumov 2025-11-18 367
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-11-19 3:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251118100046.2944392-1-skorodumov.dmitry@huawei.com>
2025-11-18 10:00 ` [PATCH net-next 01/13] ipvlan: Support MACNAT mode Dmitry Skorodumov
2025-11-18 10:00 ` [PATCH net-next 02/13] ipvlan: macnat: Handle rx mcast-ip and unicast eth Dmitry Skorodumov
2025-11-18 10:00 ` [PATCH net-next 03/13] ipvlan: Forget all IP when device goes down Dmitry Skorodumov
2025-11-18 10:00 ` [PATCH net-next 04/13] ipvlan: Support IPv6 in macnat mode Dmitry Skorodumov
2025-11-19 1:23 ` Jakub Kicinski
2025-11-19 3:25 ` kernel test robot [this message]
2025-11-18 10:00 ` [PATCH net-next 05/13] ipvlan: Fix compilation warning about __be32 -> u32 Dmitry Skorodumov
2025-11-18 12:47 ` Eric Dumazet
2025-11-19 1:26 ` Jakub Kicinski
2025-11-20 11:15 ` Dmitry Skorodumov
2025-11-20 15:21 ` Jakub Kicinski
2025-11-18 10:00 ` [PATCH net-next 06/13] ipvlan: Make the addrs_lock be per port Dmitry Skorodumov
2025-11-18 10:00 ` [PATCH net-next 07/13] ipvlan: Take addr_lock in ipvlan_open() Dmitry Skorodumov
2025-11-18 10:00 ` [PATCH net-next 08/13] ipvlan: Don't allow children to use IPs of main Dmitry Skorodumov
2025-11-18 10:00 ` [PATCH net-next 09/13] ipvlan: const-specifier for functions that use iaddr Dmitry Skorodumov
2025-11-18 10:00 ` [PATCH net-next 10/13] ipvlan: Common code from v6/v4 validator_event Dmitry Skorodumov
2025-11-18 10:00 ` [PATCH net-next 11/13] ipvlan: common code to handle ipv6/ipv4 address events Dmitry Skorodumov
2025-11-18 10:00 ` [PATCH net-next 12/13] ipvlan: Ignore PACKET_LOOPBACK in handle_mode_l2() Dmitry Skorodumov
2025-11-18 10:00 ` [PATCH net-next 13/13] selftests: drv-net: selftest for ipvlan-macnat mode Dmitry Skorodumov
2025-11-19 1:25 ` Jakub Kicinski
2025-11-18 14:57 ` [syzbot ci] Re: ipvlan: support mac-nat mode syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202511191026.AhVx4Zqc-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrey.bokhanko@huawei.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=skorodumov.dmitry@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®