From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B2C32AAD1 for ; Wed, 19 Nov 2025 23:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763593911; cv=none; b=Rzf8Gz1bTL8ebFh1yYOz5mPmicv730pbYA8Pot8BoOljBn3SlEL9oNio3HKhs0Hl/2T9dPVaRP7geo7aZ/tIVw3opdfBV0TGZxe/U6eVtWDFber6RtPKT9W+Mablsks3hrj5EfiRJ5QS06OWaasTAQjDaKjpDLfZMXaH4hL4i18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763593911; c=relaxed/simple; bh=B4ogaSzeCTEfO2fyf8QMTYxTmdo61Vz7PJm9iZmEd3Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NU9EVY49eVDNY+PWJzgkqqY6ga3KLM/PrJisySY2ovd6jovzXqTgTMQ5Zi2A/yVca4OwyrXzNXyMhMG0/rz8a3l2e53Dh1DB4Gx/LeQ/6QJoy3iUIdgkYnphMtZARgW57Kgs3Z9JVyCX4gEnlh+o5hTAvCZg9ZwtyEBQjLr3Fjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=Lt1gjpav; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="Lt1gjpav" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b472842981fso38014666b.1 for ; Wed, 19 Nov 2025 15:11:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1763593906; x=1764198706; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZZaTR1bnryMwBTD6jnnFcRa6YP7RbWnYcC+dF48Y8gs=; b=Lt1gjpavpSK9inte/G57cwm4PSwPwttll4e+ymij3cyrakoFzX5zF+cp+l0Duw2unE Cj9YFP9FCAa6UL+1/iZCK4/U1HfDG8KMkkQFEWfA7LD1ZF0CHRoMFoX+wf2W2gkqNOSr baq3Jr8PZC6S8u47xPkFKIYIJlCGbhJHPK6xTeqzSx8ojhjE3YGndy+mljtrna6ezvl5 wOMrQah3zr0jrP7SlN2OC39R9K0P9FW7TU6F+rAXBFrBzC05zC/ASF+OjJmh1qoahNX8 XdhULDXE5nKDPxTooC340LvRvgbXlf5s/rs+yKg3nTTjdpM0HrZQHLUpF54qRCekB4Vp qFmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763593906; x=1764198706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZZaTR1bnryMwBTD6jnnFcRa6YP7RbWnYcC+dF48Y8gs=; b=r6QExIsPcaitukBy6ulVcowcEt8EVt7971S8qRn+BaCynEOQ2SVYWGuLpQDnUOJmBw Zz8RN0JvG3QnleuIbPY3OmNpsWaTHfwn0uqNklCJ8a54ZjxyDTwoPaDBf0ShBBJROURe cotZGSPWazo1C6zqDPj/ThXnz83gb7Q0PHmKG052kPhJuzoB+CXbvhqzFZEY+7bJMtDT adTXl+02TUex+mXXH5oYzPOapsIC5ZIX0s4DTtLw1n/zsUebgpupYAflK+ut/Rtadebv qDA2gbk1d3xfuct305OHRFLm2xtVRf9+caM3NBo+olUEtM0dFMmhQb799zzvK6vGKPGA Suaw== X-Forwarded-Encrypted: i=1; AJvYcCVdfuQXn9J8OnrTaCdMnmbvVvqWgEUr7JGKlVfOPZJjQXAA8YDuRPs+9gC6Eldseh4sQ4fAr4PfyyFyF9A=@vger.kernel.org X-Gm-Message-State: AOJu0YzAtMzD2dIvwevWXriDWptV27Gq7afjy7QELjKl8f0cYtDxujd/ tewrhiv1YgbusOiM/iqkyBD2XXuA/9wC9xtTpOmWKCOsmhDCC9+3NdcfRwqK0OB2Bs4= X-Gm-Gg: ASbGncvzCgICxYGxchJX5Va3fIqHElpZnkwDcfk+O6E93fxC9xsa8vxJp715pRe5v7O cWwaskasYs4sTNoxZgVX/cIXdWsWaGFNn1ivoX4b7bt8YrzWOpzswJ6MyAEnucVrl1VlM5cmdGa 6YQ9w0161klkLMDm+8fcjxhyLHFFGDxpIYIjPX/uuQ+PblMUQK09bP6RLpbXUZ/oOhYyerwddYW sj+rhdP/XmXvnzY4WnLOFtLyke+u/gBZdnLPn9lVMl/oZG1FKqqff2YqJIH4v9uSE67TW/H5BYg HRQ0jzVjkF40B9wLBXD8iooS4g+KZjDeUPNsG+9qxvt8YmCrtRHl8OS/RHjvniQLs2sKp69EwIg Bis7/U3AQveeH/egQxW66WJ6VexHwHidGj5M0ISirCn7fIvvwnbB6dk7uq0C/BGwuVbzW8TqICD qcYxgjEbWMXmMzskzmQO/nn/Ny2nWEcqrW4KWj X-Google-Smtp-Source: AGHT+IGsbJFAHX8SXEuf70GC/fdHzn+3vcHUS7IST+d0xdlWSQsiYTr0gIPPSua8jakHdIJ/TGNUrA== X-Received: by 2002:a17:907:2d20:b0:b73:572d:3aff with SMTP id a640c23a62f3a-b7654eaf8c8mr99610366b.35.1763593906003; Wed, 19 Nov 2025 15:11:46 -0800 (PST) Received: from dev-mattc2.dev.purestorage.com ([208.88.159.129]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b7654d80665sm54469166b.31.2025.11.19.15.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 15:11:45 -0800 (PST) From: Matthew W Carlis To: tariqt@nvidia.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com, gal@nvidia.com, kuba@kernel.org, leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, mattc@purestorage.com, mbloch@nvidia.com, moshe@nvidia.com, netdev@vger.kernel.org, pabeni@redhat.com, richardcochran@gmail.com, saeedm@nvidia.com Subject: Re: [PATCH net-next 1/5] net/mlx5: Refactor EEPROM query error handling to return status separately Date: Wed, 19 Nov 2025 16:11:15 -0700 Message-ID: <20251119231115.8722-1-mattc@purestorage.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <1763415729-1238421-2-git-send-email-tariqt@nvidia.com> References: <1763415729-1238421-2-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 17 Nov 2025 23:42:05 +0200, Gal Pressman said > Matthew and Jakub reported [1] issues where inventory automation tools > are calling EEPROM query repeatedly on a port that doesn't have an SFP > connected, resulting in millions of error prints. I'm not very familiar with the networking stack in general, but I poked around a little trying to be able to come up with a meaningful review. I noticed that in ethtool there are two methods registered for "ethtool -m".. Looks like it first prefers a netlink method, but also may fall back on an ioctl implementation. Will users who end up in the ioctl path expect to see the kernel message? In the case of users who run "ethtool -m" on a device without a transceiver installed I think we should expect to see something as follows? (Is this correct?) $ ethtool -m ethx "netlink error: mlx5: Query module eeprom by page failed, read xxx bytes, err xxx, status xxx" Thank you for helping on this issue. -Matt