From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97F703093D8 for ; Thu, 20 Nov 2025 10:09:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763633344; cv=none; b=S9ZjPDBGeXEjDffi//+mJz6wlXBnZkIYZTV+nccSiEwXk+z6CPwGofqEACIJFfqEveMX7/Ln7+mpqVZcsq6j1Avb/Of2bvitqKCt04i/pvLKbXU8lsJj5LSWrgwB5N0JQGgOcRIOvfR+36CRn4epunGMHu9gkziQUdwnYQeDkSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763633344; c=relaxed/simple; bh=P34/dtWZ85iwYvVzb40ddAYrunxyeUYqmW3I8Ge+J54=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nFhr5ZXNYTp4KVTViWABl7IvYuKSR6Z7FValBM0hnsAlBiYiLN3AHsBQQJVQjDRhFwrEZwsA0YBnDrigD3CD+sPCzJfYNdjW6ej7Y2O0dhusiZgaCgkOzLs2kG1QghpBOkr0bMH75wevzDp9Ibp7JhBgPC6cV0vJzwg2ZLSo9yY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=fsVFKf4p; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="fsVFKf4p" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47795f6f5c0so4558045e9.1 for ; Thu, 20 Nov 2025 02:09:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763633339; x=1764238139; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fGzgvPUJB5ULEnTHX9VsC7izg1nrPGM6c7p2oBs+2LE=; b=fsVFKf4pPJWlVszSY/dq9R6WbyFVPT0+tt3G3W3+v2ItVjwjmI8rYZK7l3p3X2erYs dfUak/MEWgQvjxueD/b73ehNpczQAK6abTyx0W2DdsMfXf4ndGpifaIXLDMIWfbYae+v GPXOxKCeZP3SBPlBpefZgoZNnq0CDA4unSdk6NFYxPenK/WI0DlpiCU4yWHnpBnrXoGp iY9S9zFJ7ORumS5D/Lq23Nyj3uUyGae2IzSra3WxA6ocfOLvc1weFwTjQB3SM+zbTtXE H0xgCStLe5yyo5+zLykZnSCqOdymkjN0moxZ5Ka4dMi4o4xXJLOGo1fjz7Dcv/txcvsQ g3pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763633339; x=1764238139; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fGzgvPUJB5ULEnTHX9VsC7izg1nrPGM6c7p2oBs+2LE=; b=WgxM7oEdPKDV2uIkFC+uCvt2ycfsNwcEEttBfZ5TSKUtWjjpo6MuWavE+WI245NrtM Qwion1UTfHJcfQuBWUIvSXZvjRqRmQneHXFu93B4ncCrS1B/2bX6G9jdekj3cp2f0FWS vEFffM6Dm/rNzyuMFgzNi8lOyWoQ+VopSuBOFn+M1jFOfdWW7+w91gYlY6Etd2EucpEK wFPETg5UsqFd97y+oqgDgyBFk124B3QMvQy3hvZGHjyAVgwB829gvlU86BIZnAeJ44Y2 wAwOXoJ/V/15EmCf2HNZRKBs4oFEA82lMOU6Fdc1KRm129Q5eSAuiF+00ALMiWTrhGWo hC4g== X-Gm-Message-State: AOJu0Yx6sqCLGActaYfzKhLDeJrPtZYDPEdmnexZbi0IaAPkw8LeHCez 2IBOiSp65A1QpsxzCqqzmudZ2oUyr3Kj2flzHy/FsnDsO11j3FD/zxGPmTqZOJ+ewO8IsWkKkL2 W605z X-Gm-Gg: ASbGncsoLDTVkuM6go53WuAYce7C+lsxX788BKrRcVrIFThJan+neSdJqAFwN6k9sLD ml1cuTi8eZK9pwa9P4DG56xh1dM4gaSTGg5WXPH/L6Fr9pdJTXyXiRWFBPbTn66sRyZ0oXJdgKh mKVM5Wp5TqVxbfoLhdwrbiNhOXD1VCamnMPXZemvo0Y5rfAJG0gmBfpj9sroeHAqmqIJpwRIPRO wiYMeXzjh7pSomWeTEUPZ37dJcI+R+OwbEHJQ3YHXZBpM3ZEBcz5dFSiDA+BYU21/r7cFchFAZ+ Olm7tXrXv8Fc4poKUrBl/tkaY7QzkoMWzPplIYuStNzQSpaHmjOgyjoVwnrMOhLQtpSEIUmirMh btYzD+fbKk9f2KplEh/z03W41FnkLS5dyQekeeoH7BuYavbFXFOdG6aZlBVUNzA3N5sL5YHaysO 1RnnowE95r7GD8IZgSgHdixT09KwUx4LKEQtk= X-Google-Smtp-Source: AGHT+IEIVsuwz31m+0qVQUSp4S609vYuCx16nlGVCdMnWLwnl/vHpXtGGdF6J1wnoMqJbxxq54IzPg== X-Received: by 2002:a05:600c:474c:b0:477:7b16:5fa6 with SMTP id 5b1f17b1804b1-477babc2044mr13065855e9.3.1763633339350; Thu, 20 Nov 2025 02:08:59 -0800 (PST) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9de46cdsm58914125e9.8.2025.11.20.02.08.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 02:08:58 -0800 (PST) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Miri Korenblit , Johannes Berg Subject: [PATCH v2 0/3] Replace uses of system_wq and system_unbound_wq Date: Thu, 20 Nov 2025 11:08:47 +0100 Message-ID: <20251120100850.66192-1-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, === Current situation: problems === Let's consider a nohz_full system with isolated CPUs: wq_unbound_cpumask is set to the housekeeping CPUs, for !WQ_UNBOUND the local CPU is selected. This leads to different scenarios if a work item is scheduled on an isolated CPU where "delay" value is 0 or greater then 0: schedule_delayed_work(, 0); This will be handled by __queue_work() that will queue the work item on the current local (isolated) CPU, while: schedule_delayed_work(, 1); Will move the timer on an housekeeping CPU, and schedule the work there. Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. === Recent changes to the WQ API === The following, address the recent changes in the Workqueue API: - commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") - commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag") The old workqueues will be removed in a future release cycle. === Introduced Changes by this series === 1) [P 1-2-3] Replace uses of system_unbound_wq and system_wq Switch to using system_dfl_wq and system_percpu_wq because system_unbound_wq and system_wq are going away as part of a workqueue restructuring. No intended behavior changes: system_wq -> system_percpu_wq system_unbound_wq -> system_dfl_wq Thanks! --- Changes in v2: - improved commit logs - P3: wrong commit log was about system_unbound_wq; subject changed with system_wq. Marco Crivellari (3): wifi: iwlwifi: replace use of system_unbound_wq with system_dfl_wq wifi: iwlwifi: fw: replace use of system_unbound_wq with system_dfl_wq wifi: iwlwifi: nvm: replace use of system_wq with system_percpu_wq drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 4 ++-- drivers/net/wireless/intel/iwlwifi/iwl-trans.h | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/tdls.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) -- 2.51.1