From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F88230505F for ; Thu, 20 Nov 2025 21:13:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763673230; cv=none; b=coz3HsPhT6MkPMfr25vzInxYHqFXK+Gjm1d5SqA6gfGxxprIiVmQqvJyHtw3KPVIWoh1ZFkvCJEJukkzqo6JlenQQtWgV5pz+d3sp+2kauGoacKjqrWiHI1dFcCVThy60bULWvRhmZaICy526ZHwK9DyJMKabP9Rxk/r2Zt1soU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763673230; c=relaxed/simple; bh=/QBHhu5/mf5VqkoFrsU7ZBKAZLJ0DAd9JGOgESKJEj4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sLhtDSQnRL8WoZ3ouYCSRLCjc1SXux13trCHxi4cAbHCmJF1tO861WNvqCrg6FuQFIm1CU53L1D2oU4gBKyKdkHE02str5qO/m5VjCP3PWjwmZEHv6j2hdNKzsiz1R/i6s7D0EoXuJ92TYJD1JntvZO+vjTBpFBniGOjSCjfJPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca; spf=pass smtp.mailfrom=marek.ca; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b=VSqwrmj3; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marek.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b="VSqwrmj3" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-8b2ed01b95dso129877485a.0 for ; Thu, 20 Nov 2025 13:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1763673228; x=1764278028; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fKI5rd+bNks7evkZ2sb5RD79CIhkTakhfZrmrMaIYvc=; b=VSqwrmj3U6kuX6Lxhl4OVVv6+R9iqunUDz9euDYO3DbVzivYR/MAdgWSNOrzMhTHd9 LZRnWnVCIyqTGsvHHza/xdIZEcvVq7AiOPDg52qZWOtw3urzEhGWeUl6R2P9fY3SAaZM /lS5b/vQLFBTKY1FniDMUNx9RLN171LlDUrdsnRtqhiYcdgOZzcBa7rCDp9hn/uljZkp O7uv+MX5IVrYfWRXwNsYmyCrcVW1HHohKeJFhsqcvBodJQztQTdASbYMWsMImiJxPi0d wVwiQJ8MEEl96P+Kfj6StCyLdNT3BaEYIt+f45nwBXuffMeOpOymmF+axXmwhtiTuk+R Gw/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763673228; x=1764278028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fKI5rd+bNks7evkZ2sb5RD79CIhkTakhfZrmrMaIYvc=; b=u8uAiux/Am3C61otFnpBkVDQkok7lhusblRbTmw3b0X3bSkmsZmZEJbUXMoDcBlm4G /v0XsrbCELAxtv9JRRo39nMesmvrLh9lOlFCx6exrt16XzfTf5lfv4+C/24Ovfo6XtDJ VzYccjdo8DvHuY3OQcDSQJsa8baTVQORrbQti6uoEZUso15SLjej5QMF6Fr3uNpbKpit eN6KYjHboME3bdEeXPJI94SzSp96K+zBtSDc0o+NZkaVNCfaRRN3ZHtMKvGwQ6o2gZya E4X1MO+1aIopRDLT+WrHKqXNvFL4gc4YjDdpg2n/F44XVIavSnWU/sStduNmaCsD13RX DpJw== X-Forwarded-Encrypted: i=1; AJvYcCXyxCehQ7J7TRsr6FCWVv3ca/FsPqjPyhntte4p7OKAKTysndWJoCYXX2kXHyx5DuEfiozYFKAhpE9nszo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3Jf1YLv8jBH7qlCY387uvh20LG8ZQTGf8iDFq2l22i+tUy4xR AtbbQ8W+swl9ofQXoHYICNdzHntYWXucwNlbaSCi6Spo8Cf/3NLFyq0qaOt5jAI8npXxN67JEHk O30kp X-Gm-Gg: ASbGncu2fT/GYDp09RTY8fPXGpEt4jkncX3/1mZZl29XNBFM882NcvTfMlMzste06fl qhPoEtuxv7ERykoz3W9mTSjUCjtz1F75N6fvyb0H/IsDqLVNyZ7DWTWsS8d3UrB7HjXWRlWxm1S NHT+IPVovaFh6BTDTSdnoYgSTcAPUCG3tu4BLuTd92WubnDH690RTIA5lbCWBlVQZVNOWQ3NN/b tnIXuyuZQvCEs+rs/BZq6ewTZ/Y4nbezGDWn9gElKtGReOIJ1TLBqzxgu4FSB1wKqwzXFp1nvK1 NPFeOJnQ3PcOijacTev0Jn0vyVLg7nrBp/EbJOummBnztCsxk1OddKEUCBR4tfnQS0HXZ3FB55J Th4st9PmjG7IUzFSATovkBTbSMfiuKGSPiO5z+y31se2q9r2EsWNxzS5yjAXa/YeZCkze/O+wup WKC0OTPHAFpoHPb9C6pgY+jcfWSUTEKJi8jvTsO5zNX45kdGgZzRt/jvmeuv91UI+/Yw== X-Google-Smtp-Source: AGHT+IGvwgDIhs39jzthQlsKnE3PoNiaSD7wWyoE+gOYX6zCfolKtDiYjS30zyf3wqexvj4RjVflig== X-Received: by 2002:a05:620a:29d6:b0:865:916b:2751 with SMTP id af79cd13be357-8b3385e943emr162330185a.14.1763673227980; Thu, 20 Nov 2025 13:13:47 -0800 (PST) Received: from localhost.localdomain (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b32953735dsm225958685a.24.2025.11.20.13.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 13:13:47 -0800 (PST) From: Jonathan Marek To: linux-arm-msm@vger.kernel.org Cc: Mark Brown , linux-spi@vger.kernel.org (open list:SPI SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 4/5] spi-geni-qcom: initialize mode related registers to 0 Date: Thu, 20 Nov 2025 16:12:01 -0500 Message-ID: <20251120211204.24078-4-jonathan@marek.ca> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251120211204.24078-1-jonathan@marek.ca> References: <20251120211204.24078-1-jonathan@marek.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit setup_fifo_params assumes these will be zero, it won't write these registers if the initial mode is zero. Signed-off-by: Jonathan Marek --- drivers/spi/spi-geni-qcom.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index 575b112d4acb1..53229150b86b5 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -675,6 +675,12 @@ static int spi_geni_init(struct spi_geni_master *mas) case 0: mas->cur_xfer_mode = GENI_SE_FIFO; geni_se_select_mode(se, GENI_SE_FIFO); + /* setup_fifo_params assumes that these registers start with a zero value */ + writel(0, se->base + SE_SPI_LOOPBACK); + writel(0, se->base + SE_SPI_DEMUX_SEL); + writel(0, se->base + SE_SPI_CPHA); + writel(0, se->base + SE_SPI_CPOL); + writel(0, se->base + SE_SPI_DEMUX_OUTPUT_INV); ret = 0; break; } -- 2.51.0