From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FBFE214A9B for ; Fri, 21 Nov 2025 01:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763689327; cv=none; b=o7rtd/REIney7QmqlcXmdI1i1Hy1T+tBgSiGjctqKvJKmfaMcDy1kyzIiB6PcJS/gzF78bZEJVNVbUtq/NJihw7Kh2BuCISF1Sxz1Bk/UsTrQc7q6G68ww4KaAXJmcQTSOvN71HeXSteLTEWF2OTUXlaeuFpX2pij8anPjOYn3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763689327; c=relaxed/simple; bh=H5IeIodtSnxgkULtRM08GYwKpOM7MhVP+ZZoALsPL/Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l11gpXi1TX+wx8Y/1cH3aH0rE4qfaanhgBnayG46rjfNo6BC1uFkMBC5xTuVhh2UTcURQIwM3PiuIuq86PUlY9w/ZLE4AQ9ykmeBJO47aGYzOiGvbo2EO8TKJcf27jSt4mNJEyfgbJD5Br+AK/EUY2cr4KRMPU/MyQsV+PWjebQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iCkKQt8u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iCkKQt8u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCE1FC4CEF1; Fri, 21 Nov 2025 01:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763689327; bh=H5IeIodtSnxgkULtRM08GYwKpOM7MhVP+ZZoALsPL/Q=; h=From:To:Cc:Subject:Date:From; b=iCkKQt8uBHQqOEyvzmKYLwKjFQWdZxszn4TFQRfEpvAfDeag6BOjewlJsecYa3txz 2jS37Gxdp65o6RjRyH7gLls+e0cgm0GM5e25C6q6Z9R7cJtHZyj/g4XZSjC4z74ZV3 MPU40EBxaXGOPp0mzX7XepfISIay0Xbt05tkkOLLEdGLyQwQs1cgv4ptpZDC1IXkrS JK6kMf2tkm0MtBKfyMrqaM/Dn/4v431WiZX6bzO7MrMdMN4T6BNrp/Nth06/kac96w qF+F2v7dTlO4a2/fKNDE93pJItOVpd3zjF/gE3L/pfKzOeB/mLjv7DULUrx3xmLmjh fYo5SguULawew== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH 1/2] f2fs: improve readahead for POSIX_FADV_WILLNEED Date: Fri, 21 Nov 2025 01:42:01 +0000 Message-ID: <20251121014202.1969909-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.52.0.487.g5c8c507ade-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch boosts readahead for POSIX_FADV_WILLNEED. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++ fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 9 +++++--- 3 files changed, 68 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index a0433c8a4d84..d95974d79fb3 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2710,6 +2710,67 @@ static void f2fs_readahead(struct readahead_control *rac) f2fs_mpage_readpages(inode, rac, NULL); } +int f2fs_readahead_pages(struct file *file, loff_t offset, loff_t len) +{ + struct inode *inode = file_inode(file); + struct address_space *mapping = file->f_mapping; + pgoff_t start_index = offset >> PAGE_SHIFT; + loff_t endbyte = offset + len; + pgoff_t end_index; + unsigned long nrpages; + unsigned long ra_pages = (16 * 1024 * 1024) / PAGE_SIZE; + DEFINE_READAHEAD(ractl, NULL, &file->f_ra, mapping, start_index); + + if (!S_ISREG(inode->i_mode)) + return -EOPNOTSUPP; + + /* Should be read only. */ + if (!(file->f_mode & FMODE_READ)) + return -EBADF; + + /* Do not support compressed file for large folio. */ + if (f2fs_compressed_file(inode)) + return -EINVAL; + + if (!mapping || len < 0) + return -EINVAL; + + if (unlikely(!mapping->a_ops->read_folio && !mapping->a_ops->readahead)) + return -EINVAL; + + /* Load extent cache at the first readahead. */ + f2fs_precache_extents(inode); + + /* + * Careful about overflows. Len == 0 means "as much as possible". Use + * unsigned math because signed overflows are undefined and UBSan + * complains. + */ + if (!len || endbyte > i_size_read(inode) || endbyte < len) + endbyte = i_size_read(inode) - 1; + else + endbyte--; /* inclusive */ + + /* First and last PARTIAL page! */ + end_index = endbyte >> PAGE_SHIFT; + + if (start_index > end_index) + return 0; + + nrpages = end_index - start_index + 1; + + while (nrpages) { + unsigned long this_chunk = min(nrpages, ra_pages); + + ractl.ra->ra_pages = this_chunk; + + page_cache_sync_ra(&ractl, this_chunk << 1); + + nrpages -= this_chunk; + } + return 0; +} + int f2fs_encrypt_one_page(struct f2fs_io_info *fio) { struct inode *inode = fio_inode(fio); diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 3340db04a7c2..934287cc5624 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4047,6 +4047,7 @@ int f2fs_init_bio_entry_cache(void); void f2fs_destroy_bio_entry_cache(void); void f2fs_submit_read_bio(struct f2fs_sb_info *sbi, struct bio *bio, enum page_type type); +int f2fs_readahead_pages(struct file *file, loff_t offset, loff_t len); int f2fs_init_write_merge_io(struct f2fs_sb_info *sbi); void f2fs_submit_merged_write(struct f2fs_sb_info *sbi, enum page_type type); void f2fs_submit_merged_write_cond(struct f2fs_sb_info *sbi, diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index d7047ca6b98d..b6f71efd6d2a 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -5305,9 +5305,12 @@ static int f2fs_file_fadvise(struct file *filp, loff_t offset, loff_t len, filp->f_mode &= ~FMODE_RANDOM; spin_unlock(&filp->f_lock); return 0; - } else if (advice == POSIX_FADV_WILLNEED && offset == 0) { - /* Load extent cache at the first readahead. */ - f2fs_precache_extents(inode); + } else if (advice == POSIX_FADV_WILLNEED) { + if (offset == 0 && len == -1) { + f2fs_precache_extents(inode); + return 0; + } + return f2fs_readahead_pages(filp, offset, len); } err = generic_fadvise(filp, offset, len, advice); -- 2.52.0.487.g5c8c507ade-goog