mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: libaokun@huaweicloud.com
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
	linux-kernel@vger.kernel.org, kernel@pankajraghav.com,
	mcgrof@kernel.org, ebiggers@kernel.org, willy@infradead.org,
	yi.zhang@huawei.com, yangerkun@huawei.com,
	chengzhihao1@huawei.com, libaokun1@huawei.com,
	libaokun@huaweicloud.com
Subject: [PATCH v4 16/24] ext4: support large block size in ext4_mpage_readpages()
Date: Fri, 21 Nov 2025 17:06:46 +0800	[thread overview]
Message-ID: <20251121090654.631996-17-libaokun@huaweicloud.com> (raw)
In-Reply-To: <20251121090654.631996-1-libaokun@huaweicloud.com>

From: Baokun Li <libaokun1@huawei.com>

Use the EXT4_PG_TO_LBLK() macro to convert folio indexes to blocks to avoid
negative left shifts after supporting blocksize greater than PAGE_SIZE.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/readpage.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
index f329daf6e5c7..e7f2350c725b 100644
--- a/fs/ext4/readpage.c
+++ b/fs/ext4/readpage.c
@@ -213,9 +213,7 @@ int ext4_mpage_readpages(struct inode *inode,
 {
 	struct bio *bio = NULL;
 	sector_t last_block_in_bio = 0;
-
 	const unsigned blkbits = inode->i_blkbits;
-	const unsigned blocks_per_page = PAGE_SIZE >> blkbits;
 	const unsigned blocksize = 1 << blkbits;
 	sector_t next_block;
 	sector_t block_in_file;
@@ -251,9 +249,8 @@ int ext4_mpage_readpages(struct inode *inode,
 
 		blocks_per_folio = folio_size(folio) >> blkbits;
 		first_hole = blocks_per_folio;
-		block_in_file = next_block =
-			(sector_t)folio->index << (PAGE_SHIFT - blkbits);
-		last_block = block_in_file + nr_pages * blocks_per_page;
+		block_in_file = next_block = EXT4_PG_TO_LBLK(inode, folio->index);
+		last_block = EXT4_PG_TO_LBLK(inode, folio->index + nr_pages);
 		last_block_in_file = (ext4_readpage_limit(inode) +
 				      blocksize - 1) >> blkbits;
 		if (last_block > last_block_in_file)
-- 
2.46.1


  parent reply	other threads:[~2025-11-21  9:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21  9:06 [PATCH v4 00/24] ext4: enable block size larger than page size libaokun
2025-11-21  9:06 ` [PATCH v4 01/24] ext4: remove page offset calculation in ext4_block_zero_page_range() libaokun
2025-11-21  9:06 ` [PATCH v4 02/24] ext4: remove page offset calculation in ext4_block_truncate_page() libaokun
2025-11-21  9:06 ` [PATCH v4 03/24] ext4: remove PAGE_SIZE checks for rec_len conversion libaokun
2025-11-21  9:06 ` [PATCH v4 04/24] ext4: make ext4_punch_hole() support large block size libaokun
2025-11-21  9:06 ` [PATCH v4 05/24] ext4: enable DIOREAD_NOLOCK by default for BS > PS as well libaokun
2025-11-21  9:06 ` [PATCH v4 06/24] ext4: introduce s_min_folio_order for future BS > PS support libaokun
2025-11-21  9:06 ` [PATCH v4 07/24] ext4: support large block size in ext4_calculate_overhead() libaokun
2025-11-21  9:06 ` [PATCH v4 08/24] ext4: support large block size in ext4_readdir() libaokun
2025-11-21  9:06 ` [PATCH v4 09/24] ext4: add EXT4_LBLK_TO_B macro for logical block to bytes conversion libaokun
2025-11-21  9:06 ` [PATCH v4 10/24] ext4: add EXT4_LBLK_TO_PG and EXT4_PG_TO_LBLK for block/page conversion libaokun
2025-11-21  9:06 ` [PATCH v4 11/24] ext4: support large block size in ext4_mb_load_buddy_gfp() libaokun
2025-11-21  9:06 ` [PATCH v4 12/24] ext4: support large block size in ext4_mb_get_buddy_page_lock() libaokun
2025-11-21  9:06 ` [PATCH v4 13/24] ext4: support large block size in ext4_mb_init_cache() libaokun
2025-11-21  9:06 ` [PATCH v4 14/24] ext4: prepare buddy cache inode for BS > PS with large folios libaokun
2025-11-21  9:06 ` [PATCH v4 15/24] ext4: rename 'page' references to 'folio' in multi-block allocator libaokun
2025-11-21  9:06 ` libaokun [this message]
2025-11-21  9:06 ` [PATCH v4 17/24] ext4: support large block size in ext4_block_write_begin() libaokun
2025-11-21  9:06 ` [PATCH v4 18/24] ext4: support large block size in mpage_map_and_submit_buffers() libaokun
2025-11-21  9:06 ` [PATCH v4 19/24] ext4: support large block size in mpage_prepare_extent_to_map() libaokun
2025-11-21  9:06 ` [PATCH v4 20/24] ext4: support large block size in __ext4_block_zero_page_range() libaokun
2025-11-21  9:06 ` [PATCH v4 21/24] ext4: make data=journal support large block size libaokun
2025-11-21  9:06 ` [PATCH v4 22/24] ext4: support verifying data from large folios with fs-verity libaokun
2025-11-21  9:06 ` [PATCH v4 23/24] ext4: add checks for large folio incompatibilities when BS > PS libaokun
2025-11-21  9:06 ` [PATCH v4 24/24] ext4: enable block size larger than page size libaokun
2025-11-21 10:26 ` [PATCH v4 00/24] " Ojaswin Mujoo
2025-11-22  0:13   ` Baokun Li
2025-12-01 16:23 ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251121090654.631996-17-libaokun@huaweicloud.com \
    --to=libaokun@huaweicloud.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=chengzhihao1@huawei.com \
    --cc=ebiggers@kernel.org \
    --cc=jack@suse.cz \
    --cc=kernel@pankajraghav.com \
    --cc=libaokun1@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=tytso@mit.edu \
    --cc=willy@infradead.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®