From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 880152C0F69 for ; Fri, 21 Nov 2025 19:27:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763753228; cv=none; b=O8uMtcmMWqDVRErUAm87flr9wl6SZS+u327W4d8AVxQbwnNjP1Chvof1eFNRpcOF7digVOrmg5t0YzylO5e3ZNMG4IQAT/r/dppSc6Yr7ZqTRE5aW/YFXzjZX8wSuOGisvzY5ezKoMi+R3dupB1TDaafDdoixGwwKZIg//151jo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763753228; c=relaxed/simple; bh=FpPmrNBuKiuzYquOiGtXWIrHTqyVgbm4VpSHg+nibLk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dcXX5GAsq5TApYrbPmLHU7wOLQ2EWoIdMikO2PZ6T62LLmZDm8endrLrCB3HbaNL9l9l6ks3b3Y8laGwkNO9zCpv3NqZKddSLWSnF/g4hObgB49JmzlmOBshwGQpjOCiMxi/9CMogip5FotkVzxLSaHfOTWb5/wumHP0Od6al9w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NUmURNMk; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NUmURNMk" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-42b2dd19681so282817f8f.3 for ; Fri, 21 Nov 2025 11:27:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763753225; x=1764358025; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ky8MNRO/KnATv6ZPDH12/iyZld6BKAT4bhit2Vz/NhE=; b=NUmURNMkSSSvu/Pt6XrIvcoVrYsa+RYkvGHH+1jx6uywXx8A1PiN/H/Cwyrk40dmEH S/iRmkHfSBzpaz+vWnM/aKo4xJSwRe0TdbOrCJLdjlfqSdgvaSjI69fEn0duBILZy+cE y5VPz7xTI3x9k++cpiQgFAo/zlnchHgEOgJwJGs9IidFQkA8KMSXgV4tu9uV+KaEgbH3 930Fo4NQzD1ktM5fvXAzwCVN5WS17MVP5r4FN2G1k01C+wDkj31HuujZWfbthOAwNDHu 0AL9TzvgCN7zQ6JibJvuse3opHfD+jhmmxW8VSY4SFPjFw480j3vw7/M5iLjbln3KlWF d0ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763753225; x=1764358025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ky8MNRO/KnATv6ZPDH12/iyZld6BKAT4bhit2Vz/NhE=; b=MRQSu0SCLaB6qD+9eGFYFLckC/BRHs5W4KTYe4TfPvhd/0ZSIKCPqsjTavyNEnxHkC lPXPEXvnnV4Ks3CyLaEa7ODxORKkS7ZIbpV+V/iq/fNTJ5LOAFo4/iRgS/dw2X4FfC9h pcjjdOFChy7QM2lqQlv9xttvGwzODjlWDhuFuQbVaj73IusmF5yxigJa/K0UCArjYHg/ 7guj7HMPJYnR+aGOBuDx1SvW3weTcHbqPPhDfxktGNbJZZ9cx5evvseEj9dpYhDlmPGH NPzPxpyO6wE1mg9MCUnYBk3Jgj3t8ONFNwKTyhbD5Ugl8Rp7CK5atqaIOdShPd/1qKnk ZiNw== X-Forwarded-Encrypted: i=1; AJvYcCVy3/naP02zcao5oaEkXv/aEdvom69giDu+4OYOrm6MRO2dTi2AlOqCQGJqt0sXIE/IYhheDWyvZ05duCo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/dUzZ8SavHzOL/I2pIXeblSQiJhszrPssFpGEKosJZQ0ADSJn ZGgPXei1YipZVhauPQhSI6y/aCv54MiG5jA2976Dcw1/NRuwTa7IwW3p X-Gm-Gg: ASbGncv1xYll3FiC6NWKiCazbGq6E2g8+DE26XsqAaKXFemms69ottOHn01h9/uDY9x nHACzvKpSaILm8QrPWDrYpTuyrYtDddEqdDesxxdQ/v4/Q5TXdGppuvNsuW23PdG5llrGEECp0X M9Mt7AjhPKrllar6WhB4+sX11KrBOmKICQGAim4am07kEINxDNfmD0Ldz7UICWkOJaubAVgmIKH COhw9viz4jea6s6MaSndx1+lP4u56ktfIDmkC+RBlUkjQACqhhk8O3XoaT5SZe98e6W4F7bbXQI WplkH+eCpndm3fVBpIsRrNPutD/ktUJugLnTtOVi1qutC7RUSSWqp0osjtbUQx2kMqJnXKMj5m9 ZRGlR9zuCoEBdyIw/rD6J904ZXObXiVCVbLKgcvcOw6fRAjmc+ZB0NCteoKqYuCJ9bIFvBSh+oB XSqG4= X-Google-Smtp-Source: AGHT+IE348ikYusVnT2VGIZWl+evV/447ueHW9w22vcPuRfWXrW3lvJtPVVGuCPdYxsayq5bsL3b5A== X-Received: by 2002:a05:6000:1863:b0:429:d725:40f0 with SMTP id ffacd0b85a97d-42cc1d13128mr1881881f8f.5.1763753224516; Fri, 21 Nov 2025 11:27:04 -0800 (PST) Received: from skbuf ([2a02:2f04:d106:d600:b19f:2efa:e88a:a382]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f34fddsm13036413f8f.14.2025.11.21.11.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 11:27:03 -0800 (PST) Date: Fri, 21 Nov 2025 21:27:00 +0200 From: Vladimir Oltean To: Prabhakar Cc: =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Philipp Zabel , Russell King , Geert Uytterhoeven , Magnus Damm , linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar Subject: Re: [PATCH net-next 02/11] net: dsa: tag_rzn1_a5psw: Add RZ/T2H ETHSW tag protocol and register ethsw tag driver Message-ID: <20251121192700.3eg5h2eqk7bruxeu@skbuf> References: <20251121113553.2955854-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20251121113553.2955854-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20251121113553.2955854-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <20251121113553.2955854-3-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251121113553.2955854-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <20251121113553.2955854-3-prabhakar.mahadev-lad.rj@bp.renesas.com> On Fri, Nov 21, 2025 at 11:35:28AM +0000, Prabhakar wrote: > From: Lad Prabhakar > > Add an explicit tag protocol for the RZ/T2H ETHSW and register a separate > ethsw tag driver so the existing A5PSW tag implementation can be reused > for RZ/T2H without code duplication. > > The ETHSW IP on RZ/T2H shares substantial commonality with the A5PSW IP on > RZ/N1, and the current tag driver does not touch the register fields that > differ between the two blocks. Tagging protocol drivers are specifically written to not deal with register fields. I would like a clarification that this is a phrasing mistake and you mean the packet header fields that differ between the ETHSW and the A5PSW tag format. > Expose a distinct DSA protocol and a second dsa_device_ops to let > consumers select the RZ/T2H tag format while keeping the proven A5PSW > handling unchanged. > > Signed-off-by: Lad Prabhakar > ---