From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9E97306489 for ; Fri, 21 Nov 2025 21:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763759113; cv=none; b=pa3M8Sg5xv+c/uBmhLI8x9r1iHC1qd3DM7Zo1/EbU5PSPRmOTFPOMe/QAeyc8IVCG3pRm6OEQTHfWeug/qJZCOKi1xOCbXKpBPocLQ9DxSSU+3WOrTmlcZKKDG2fx5hLoVX2p5oy6ydws5jN5RkiPKRBnPQMrlHMaVXwObbiePA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763759113; c=relaxed/simple; bh=ikocOw5rSrWvxBWEQdFtppjYN11mom4HHhas6/T9J2g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bGMorxFLeFzdq004EU1Tfhg6EOy5rqc1r+Xn1AE1mv5lGscxqcEHtwcTeYQFQzRVmOHHZ1qQK9NUyIoL0WaBW16/ovijEV283U4wArCtHq/DMx6aDrg+1dt+j4fnGsvxsV5GNbszofRIvXH8homKDct5/qLVEMyYxXGXMkCRLdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kvus6StE; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kvus6StE" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42b53b336e6so207028f8f.1 for ; Fri, 21 Nov 2025 13:05:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763759108; x=1764363908; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JM0Mreiq32b+LPITrWPP1aT6vTsdSPOWG4QtqrPmPSQ=; b=Kvus6StEPYOK5Nn9yT9sJpo1VRUIp3KQK79bcMq9Yh55IrwEPQoOoe8iwDeryiWUXl Dr29xuT4qBbPvsKO/1v/c2z1nv9UEkmCSS0k0pVNhcxpB2PSzaWQ/D1DdBTD1Bja7hzM LZ6O+hfbpOPovUN7n/Btv3wjDQYtEpC2IRDB9+6Kkt9YLOuhJzDNYDMbKmyLEh5RMwWi s/6ug5j6nNJTuZxtvLzwCk8hlH5XI5FSLJrVkUau+2WFbOvrNoOnNd4WnrE6LQ6iTJd3 HbcW2EEKOzFSvYY0wqpu1t1rDqU/h/ZWq7fDTEfC+vUiobsM5396nB9jNehUS7s7ecQt hfVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763759108; x=1764363908; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JM0Mreiq32b+LPITrWPP1aT6vTsdSPOWG4QtqrPmPSQ=; b=EdkK1VGdvIdw2q5ER+hyS6YNvqV1fgdSfgYZsPQAZCxKQt10K1mDluPsKG9u4keiko YA2+zW4ficH2cD2VGb6Zn8gYedGZHHgU24jeqV/Oj8qpW8kx4PUc/oQhNxedAQJ+hJHh w8QOrm962stD9FxFY1wSWy5xgY3fLODS4rvniBhuttLM+V8ABMbWvO2dlMCXK0L8V/A1 HR6CfoLaCga2QXPr/ipuf7Qnb3jIAh3uG5pbwEIAmTeHqa9Pd0bdKLzOlZxj/bJ/hIsv EKqtD3u8FJKA+ySMMC3Mk3u6SnXc8jdoAURzWfHl674emT8pu8fQCeEZe0tJBwXfCUW2 jppQ== X-Forwarded-Encrypted: i=1; AJvYcCUHO52Int9N4VDu0YSOJcjJgYABTin9dFUlbw73pEsGx3p8rW4QaJReFpRaR2gFI7hyYKEjEIauNdZCCAE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz30POLrvP2CFNSx/ICVhrstmcs2PbI93pO7VhepuOJ3JJz8GWI exSm/NEXv2bEYzh2a1TEsfNuUM5a59kyB1F5hG9rmr6leonT0bFTJJyM X-Gm-Gg: ASbGncubCpkCqaVoMd47ZJyoXPKPXFv+DjFGngI0KSyrKmlisTsMsXCXev/6JA3mKbM bhgIT75TwwFduc/ELgdsRyjRV1/Wu9SVM3wV9qmqsqQ3AhEW6FIclSDpY26LBByWFm7gTKTJHt+ NMEPSpWYI8OAJPBKl972IqJYe2n/MI4qAID/ykS7CzAJtlzFv5kZdUibMWjwCV4uW2zO4D7BHLy DyKmVf8IU6EzB+v1hPA90u6XW8A+6I7NeVJhYNfe9ch75lcHni9CMHLon7m5hXn2JjU7Waq58Dq CyJxKTrT3qsST436xKocmnfLk/rr/RBTwugH0d06Q3AgWXr5tSRMw8q4NMmsMA9pc9faYvbRRFq jDfzzX68qtd4tRcv5gj80KotbgbaehOF7es5FBj85ksTGu4ucwXCWdtp1TF2y+2jl7nSCrxdovW mpZOw= X-Google-Smtp-Source: AGHT+IFS3P2oYUjpO8Y/WJHNkwI++Z16Q0FgFLqrouu1RpHsouIxJV7ZSaPDknXEWFmL4yz0PFSImg== X-Received: by 2002:a05:6000:4382:b0:429:c711:22b5 with SMTP id ffacd0b85a97d-42cc3eda99cmr1814532f8f.1.1763759108146; Fri, 21 Nov 2025 13:05:08 -0800 (PST) Received: from skbuf ([2a02:2f04:d106:d600:b19f:2efa:e88a:a382]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f49a7bsm12836295f8f.19.2025.11.21.13.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 13:05:07 -0800 (PST) Date: Fri, 21 Nov 2025 23:05:04 +0200 From: Vladimir Oltean To: Prabhakar Cc: =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Philipp Zabel , Russell King , Geert Uytterhoeven , Magnus Damm , linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar Subject: Re: [PATCH net-next 09/11] net: dsa: rzn1-a5psw: Add support for management port frame length adjustment Message-ID: <20251121210504.ljeejnltaawahqtv@skbuf> References: <20251121113553.2955854-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20251121113553.2955854-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20251121113553.2955854-10-prabhakar.mahadev-lad.rj@bp.renesas.com> <20251121113553.2955854-10-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251121113553.2955854-10-prabhakar.mahadev-lad.rj@bp.renesas.com> <20251121113553.2955854-10-prabhakar.mahadev-lad.rj@bp.renesas.com> On Fri, Nov 21, 2025 at 11:35:35AM +0000, Prabhakar wrote: > From: Lad Prabhakar > > Extend the RZN1 A5PSW driver to support SoC-specific adjustments to the > management (CPU) port frame length. Some SoCs, such as the RZ/T2H and > RZ/N2H, require additional headroom on the management port to account > for a special management tag added to frames. Without this adjustment, > frames may be incorrectly detected as oversized and subsequently > discarded. > > Introduce a new field, `management_port_frame_len_adj`, in > `struct a5psw_of_data` to represent this adjustment, and apply it in > `a5psw_port_change_mtu()` when configuring the frame length for the > CPU port. > > This change prepares the driver for use on RZ/T2H and RZ/N2H SoCs. In the next change you set this to 40. What's the reason behind such a high value (need to set the management port A5PSW_FRM_LENGTH value to 1574 bytes to pass L2 payload of 1500 bytes)? It sounds like this needs to be called out more clearly for what it is - a hardware bug.