From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFA4F23741 for ; Sun, 23 Nov 2025 01:50:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763862630; cv=none; b=ZW5W/QbnSsL9KyNXtbh+nLah6jJFM3Y+5g1BM9Q5KSDkyqSLp/6QF7TyF1T4lMHp8AaaAkwpwJJJeYvburC+O5Ez6ckMek99MMDUErCy4KEGbT8h/HljdpBN0GAqC+zoPMdGg5NmIiGpAWJGDAxCmS1ZtrrhP89FO4dUwystH6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763862630; c=relaxed/simple; bh=PmTZ3YE54D7jB7Nns04dml/raL6xVOdNFsQTHrkNXgI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d4hNKT21fXg6SyO179DPKhY2rpAHue2FJ8tM/9qdNsV5y5yTCbemcfv/tz9RGpJr43bQkbHkxauN8/i5F+jRVFm/UzGJQNVAhN3kzHM7qz9yfh22WlLjRHk1ZbPfBE8S+PMNZTlNFDvcf4OSm8JQhy394DgrIpV5xCv31j4bxgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gx5tspTR; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gx5tspTR" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-64080ccf749so5147736a12.2 for ; Sat, 22 Nov 2025 17:50:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763862627; x=1764467427; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fZRMmt4pu0dDVkazc6ojxwyXbSgwN1XagjCsYx65qUw=; b=Gx5tspTR8zoJnvJCGljXz0cgAJj6mAe6/rNC88GqoEptlFDecnOgyynkz6Glb2Anlf cnGZHjayiQtzt+5l/NcknPDvvdmHSFBRadzTCd4hRYLIIstOTJJB5qanEBMkIWfe1v2+ cePgG7V/Th0Bgj/d5HQ3cX3imx4x0RpvsUCZLaPqcFyK3232tr+HDS/UcMviDPQLIA4+ r1zHT/aNvJdVt8Ucag4Pt4xPgZCtb8aYe62X0we97fGMwE8Zc3jnfDk3bERw0UsnZ5jR RfJYcAmft35q17SWkUPLD5wLiP6z4Q5odU9MMnnF/P0fkDed3SqL2wdalXuU3Y7BvsKH fDYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763862627; x=1764467427; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fZRMmt4pu0dDVkazc6ojxwyXbSgwN1XagjCsYx65qUw=; b=gkbJShGsGxraTaFPWjEtPjdOyx4azfGfRwG25CNdyNTpo7CJIKJ49rUBhgdMBMJXey PINX9TRA8MMJykuhKmwxc/9qKtfEkTik/KJCLG+D/RV5oQ0H9c6xNOhWgrmySqgMkCqi MZsCes7OEHS6MN38B0qsa6mGQEYHEC6d0yBqdVF/9qXMh9P1Pf74V0phU0EJgy3y40Oq UV3XBVQW7rRmteZU0ZKKTJ1rWZGZov2PhI++HoPxjRaCAcDstpa/C+LRq9r59IeLAJ8R ig3HyyWtLw621D80XmMVIEqul3/bLXoWbFMg/ea9h2zvcmVtZXLU9QrSKafnL3E0nJrm CgwA== X-Forwarded-Encrypted: i=1; AJvYcCVwsRnG+fQPk91cqcS6usQWtz2e5AJTEz8uVaoTdEHDEyj0MVIREFEQU6AljkJ81N5Hcqt9O/0d41UeYLI=@vger.kernel.org X-Gm-Message-State: AOJu0YxbhMltE9eihDxwv4v5E4MdE1Z3/04hId4u2FHxhM9N386yK0T8 C2Pugy3ihyN8S8bCMPKhhm7BvOI82PfWxNyzaKrQQu83YKjlol+5ENN3 X-Gm-Gg: ASbGncvlsMuEJDKK9J04jAGAkiCl7Mw7IHcd9lcTmrxYxsqpopQIvUuBYIQzXtfwRho H5tNZtzormz1dyoeWKLlU+ouIv93aL1kvBMcTC6tE8UjAs2e3lSaiA5r9yWsXri7BdksXYULBaA BshWw/wSugOAG/sF482fwJpX/icFtaLMOIjOojc/2iv7hHXeOS1ZYq/M0CTnT+bLclXCzhWEf4o 3kZgdW8NXJhEWEPkGBMzINSfGEnQ/Xz3whBVYArTgUPwUErW5s3/8KEFsMmRJqb+hbglhFf45Qs k/Mm63adfbAGRSsEcnHb/2iKh5SK4YxRNCofBf6SwAZ9V6wWp6Pks8XtVDgu5yMkd23LZTnP1HM sGDeuscU+EWizsEFanhSkXSFUUPsHWJz874ueKigGYCITu4piaA/h1TDvYG2EPcSRhOqbJR6rFG 4iHR2M8cl/pouhDnqFKY56fwEw X-Google-Smtp-Source: AGHT+IHZ4O8wdhJM+yoOYvYZf6LNE4a2WojGsAeFRR0CdKN+TtxymyN3cBZQC1n8qSaPgcVxqeqO3A== X-Received: by 2002:a17:907:7f08:b0:b41:4e72:309f with SMTP id a640c23a62f3a-b76719d84femr659491766b.50.1763862626935; Sat, 22 Nov 2025 17:50:26 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b765c1379ddsm790854666b.0.2025.11.22.17.50.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Nov 2025 17:50:26 -0800 (PST) Date: Sun, 23 Nov 2025 01:50:25 +0000 From: Wei Yang To: Zi Yan Cc: David Hildenbrand , Lorenzo Stoakes , Andrew Morton , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Miaohe Lin , Naoya Horiguchi , Wei Yang , Balbir Singh , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] mm/huge_memory: change folio_split_supported() to folio_check_splittable() Message-ID: <20251123015025.cbwijhb6rhvtuxzu@master> Reply-To: Wei Yang References: <20251122025529.1562592-1-ziy@nvidia.com> <20251122025529.1562592-2-ziy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251122025529.1562592-2-ziy@nvidia.com> User-Agent: NeoMutt/20170113 (1.7.2) On Fri, Nov 21, 2025 at 09:55:26PM -0500, Zi Yan wrote: >folio_split_supported() used in try_folio_split_to_order() requires >folio->mapping to be non NULL, but current try_folio_split_to_order() does >not check it. There is no issue in the current code, since >try_folio_split_to_order() is only used in truncate_inode_partial_folio(), >where folio->mapping is not NULL. > >To prevent future misuse, move folio->mapping NULL check (i.e., folio is >truncated) into folio_split_supported(). Since folio->mapping NULL check >returns -EBUSY and folio_split_supported() == false means -EINVAL, change >folio_split_supported() return type from bool to int and return error >numbers accordingly. Rename folio_split_supported() to >folio_check_splittable() to match the return type change. > >While at it, move is_huge_zero_folio() check and folio_test_writeback() >check into folio_check_splittable() and add kernel-doc. > >Signed-off-by: Zi Yan LGTM, Thanks Reviewed-by: Wei Yang -- Wei Yang Help you, Help me