From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5B1E3A1D2 for ; Sun, 23 Nov 2025 01:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763862674; cv=none; b=jiM2IAsg3CLTaZl40mbtZPONp5HThop1S1CpUcHWGR74X6Eh50Eaml4o6n50Xr6uhkO7GR+xaHknp32AbSdFkWyCLtTrOqFRjaoynHeRzN7uf4ypk0k4kKhCBONOSG5xJ9UHW0ZEcDMUY+DjkbGcONGDHye9IuP4MGEfhdIB+OA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763862674; c=relaxed/simple; bh=juRI9qXel+mndFNUR1+NvIcJXdAF33QVut1Vlb8M7Mc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aDcaIImCk2wxfOMne/fouKLaQpjSOa6FdeuiTMh+d9yFC/raqW05NdtOxOLwy5YVcf7L0cVdw8SNeRg1C4wN2DYGtwlw82qWM2JTi4hKmKdANe1VVhc7rnmB0YjLtjbmttKeilHHsMc78DL//o4HviLnPzoMxCW0iqivhoG2cWw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rg567s/4; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rg567s/4" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-6431b0a1948so5360638a12.3 for ; Sat, 22 Nov 2025 17:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763862671; x=1764467471; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6nVpiFdX7itUjcz/kHm7teZ1ePNKGm4Y4akUt0BwQhs=; b=Rg567s/4ujcNERV6FlgjESnCx+Kfa6E7NmNzfbhupvHZ5MSRObHl70Pknsh0N4hRcf vnjDa2FL9v1nthOKpxWTTcs+Gpr0wd9Os863W/4g3g+EajbwF6caqaOnVpiqqOPiIKrL R+eXaw7X6FQyRlVir8ZZYBtmVYsGe5WN+yEsx+HImdC5NyIr74KHW0ewN6pbso5e6jS/ jU8PqETsXw9oMHanB1ubLrzVzmD8id67Cj1aRvM74FOmHccKmbGraFhZ7byHG9fpg7bD y/DS9c2LnE/0fm7sp/RJvNVFTARjI6C5ddl8h0V0WVQ+qpEqc2haXd4r7/xHrBgL7xcc P9sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763862671; x=1764467471; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6nVpiFdX7itUjcz/kHm7teZ1ePNKGm4Y4akUt0BwQhs=; b=WDTsH7fEnjLv3vOf0zx8pjTjKqnPSC6wlPvVsoO0/LOgab4oj8E3KDqlUSwZCS7sJV 18oYo90W+kYvZ46Usl4qYpSm4hohQD8uRxuCh6tTPHieOwVR+C18Eewb8GYvPOB0JJkj QL2gNS1V3X+YnPtGbWgN5oe2891Kn7bjlu1n2Jf2sUwlIDcbd6dliYHecwFmeG/BqcNV +ixj28SakiN9Cm+ZFOR+Q0TMFkIKO6HrsMMmPYovPs4QTZZkQ6ObDnfAiO6eAfpqhM0w z+Ppkdd9Vl0tFXMaiFOKutt0/YaAuD8r3HxcC/FgbeJQChhp8MurSj4JizFHV0THIhXQ 0xsg== X-Forwarded-Encrypted: i=1; AJvYcCV+CsRxKVQtPhp6GDw5MP60NInSHkcQFGi6dzGrin6+72oXmmvOJtcnJUcOHOzy0ACcBED7YjkPiczPmlg=@vger.kernel.org X-Gm-Message-State: AOJu0YzGoadQGQEG2fGdvIpNP5WX3FALbv0FAju97Fro5287OW/zPrrV JN7j0a0+FtFm0KRo6SXiCAut+S1z9Jhmc7EdthkTefN33JXNw8xrfWxB X-Gm-Gg: ASbGncuG9f9dWJh3/J2x2WxmtGhZ4NLmeEGL40AiLamtJaV93LAWNEpj+lWDFVLa6bf dSwtQMCX7xJItLElyUSD4SVaYHRDbvy1vTJ7iY/UO0P0ua16AxlDm/kuzwYEjDwEEX5DKV1hTEF 5NaTVnJ8j4OmKze9HNDKYqzZ6LnCkVXZF5bcEENsvrSvqcOwP8kR8ZVS/NcqJ9Y5sME7Jbjmwap WIEYutLJytBzWn5w2jU0eGsHMDHYyvxkZDMEZMrlNm3xOzuwFJ7BwBLpyuT51hUDygCMIfkMzRl Aej9s7xSrZnCf/VnnRxG9lrKXR9EjbtYC6lc7+Y6vTTEE8O3WD1MNqXecI6PgXgagPWZ5nrn63x 8UYNn33KS3T10ZPHA7oNGzPh+Yz7bUlU45jgkhvysZLnULweF9Y/T9yluvz0Dc0GO9wkkaWH3Ps jzHN2jNUBGiinQnw== X-Google-Smtp-Source: AGHT+IGDbJxR38k0CDgJ6xIfXSvddpH6S6Qzkfm01XRydYuyQe1EOms7msfODKCix83hDBowWzuBgA== X-Received: by 2002:a05:6402:1ed6:b0:637:ee0d:383d with SMTP id 4fb4d7f45d1cf-645543495b8mr7201615a12.3.1763862671082; Sat, 22 Nov 2025 17:51:11 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64536442993sm8555273a12.27.2025.11.22.17.51.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Nov 2025 17:51:10 -0800 (PST) Date: Sun, 23 Nov 2025 01:51:08 +0000 From: Wei Yang To: Zi Yan Cc: David Hildenbrand , Lorenzo Stoakes , Andrew Morton , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Miaohe Lin , Naoya Horiguchi , Wei Yang , Balbir Singh , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] mm/huge_memory: replace can_split_folio() with direct refcount calculation Message-ID: <20251123015108.wxb7oyk7vlfrjlbi@master> Reply-To: Wei Yang References: <20251122025529.1562592-1-ziy@nvidia.com> <20251122025529.1562592-3-ziy@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251122025529.1562592-3-ziy@nvidia.com> User-Agent: NeoMutt/20170113 (1.7.2) On Fri, Nov 21, 2025 at 09:55:27PM -0500, Zi Yan wrote: >can_split_folio() is just a refcount comparison, making sure only the >split caller holds an extra pin. Open code it with >folio_expected_ref_count() != folio_ref_count() - 1. For the extra_pins >used by folio_ref_freeze(), add folio_cache_references() to calculate it. > >Suggested-by: David Hildenbrand (Red Hat) >Signed-off-by: Zi Yan LGTM, Thanks Reviewed-by: Wei Yang -- Wei Yang Help you, Help me